Project: v8 Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users
Status: Fixed
Owner:
Closed: Jul 2015
Cc:
HW: ----
OS: ----
Priority: 2
Type: Bug



Sign in to add a comment
Improve typed array performance
Project Member Reported by jochen@chromium.org, Mar 31 2015 Back to list
When the embedder just wants to copy the bytes from a small typed array, we should not have to externalize it.

 
Project Member Comment 1 by bugdroid1@chromium.org, Apr 2 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2a5eb8299b2fa13d57d1d4741d4f121df1c3e883

commit 2a5eb8299b2fa13d57d1d4741d4f121df1c3e883
Author: jochen <jochen@chromium.org>
Date: Thu Apr 02 09:36:37 2015

Expose an API on ArrayBufferView to copy out content w/o changing the buffer

BUG=v8:3996
LOG=y
R=dslomov@chromium.org,kbr@chromium.org,hpayer@chromium.org

Review URL: https://codereview.chromium.org/1041403003

Cr-Commit-Position: refs/heads/master@{#27580}

[modify] http://crrev.com/2a5eb8299b2fa13d57d1d4741d4f121df1c3e883/include/v8.h
[modify] http://crrev.com/2a5eb8299b2fa13d57d1d4741d4f121df1c3e883/src/api.cc
[modify] http://crrev.com/2a5eb8299b2fa13d57d1d4741d4f121df1c3e883/test/cctest/cctest.gyp
[add] http://crrev.com/2a5eb8299b2fa13d57d1d4741d4f121df1c3e883/test/cctest/test-typedarrays.cc

Project Member Comment 2 by bugdroid1@chromium.org, Apr 13 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ada32ae63651f544801647b7a6fe16f0f6146996

commit ada32ae63651f544801647b7a6fe16f0f6146996
Author: jochen <jochen@chromium.org>
Date: Mon Apr 13 11:28:02 2015

Expose ArrayBufferView::HasBuffer

This allows the embedder to decide whether it's worthwhile to copy the
contents to avoid materializing a buffer.

BUG=v8:3996
R=dslomov@chromium.org,kbr@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/1084513002

Cr-Commit-Position: refs/heads/master@{#27782}

[modify] http://crrev.com/ada32ae63651f544801647b7a6fe16f0f6146996/include/v8.h
[modify] http://crrev.com/ada32ae63651f544801647b7a6fe16f0f6146996/src/api.cc
[modify] http://crrev.com/ada32ae63651f544801647b7a6fe16f0f6146996/test/cctest/test-typedarrays.cc

Project Member Comment 3 by bugdroid1@chromium.org, Apr 14 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/835eeafe32f442d7b43fe175237de2c70ed7ceef

commit 835eeafe32f442d7b43fe175237de2c70ed7ceef
Author: jochen <jochen@chromium.org>
Date: Tue Apr 14 10:55:22 2015

Revert "Remove early bail-out in VisitWeakList to investigate chrasher."

>  BUG=468601
>  LOG=n
>
>  Review URL: https://codereview.chromium.org/1016353002
>
>  Cr-Commit-Position: refs/heads/master@{#27317}

R=hpayer@chromium.org
BUG=v8:3996,chromium:468601
LOG=n

Review URL: https://codereview.chromium.org/1080303002

Cr-Commit-Position: refs/heads/master@{#27814}

[modify] http://crrev.com/835eeafe32f442d7b43fe175237de2c70ed7ceef/src/heap/objects-visiting.cc

Project Member Comment 4 by bugdroid1@chromium.org, Apr 16 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fd7d881e2be920cb1c020a5663bad400833770ee

commit fd7d881e2be920cb1c020a5663bad400833770ee
Author: jochen <jochen@chromium.org>
Date: Thu Apr 16 21:00:12 2015

Revert of Revert "Remove early bail-out in VisitWeakList to investigate chrasher." (patchset #1 id:1 of https://codereview.chromium.org/1080303002/)

Reason for revert:
Still doesn't work

Original issue's description:
> Revert "Remove early bail-out in VisitWeakList to investigate chrasher."
>
> >  BUG=468601
> >  LOG=n
> >
> >  Review URL: https://codereview.chromium.org/1016353002
> >
> >  Cr-Commit-Position: refs/heads/master@{#27317}
>
> R=hpayer@chromium.org
> BUG=v8:3996,chromium:468601
> LOG=n
>
> Committed: https://crrev.com/835eeafe32f442d7b43fe175237de2c70ed7ceef
> Cr-Commit-Position: refs/heads/master@{#27814}

TBR=hpayer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996,chromium:468601

Review URL: https://codereview.chromium.org/1092783002

Cr-Commit-Position: refs/heads/master@{#27902}

[modify] http://crrev.com/fd7d881e2be920cb1c020a5663bad400833770ee/src/heap/objects-visiting.cc

Comment 5 by jochen@chromium.org, Apr 20 2015
Summary: Improve typed array performance (was: avoid externalizing small typed arrays if possible)
Plan of action
- remove support for external arrays in v8 api
- remove weak view list, instead use indirection to check for neutering
- remove weak buffer list, instead collect pointers during marking
- unify how external arrays and fixed arrays access to get rid of polymorphism
- fix any performance regression introduced during the steps above
Comment 6 by jochen@chromium.org, Apr 20 2015
Cc: titzer@chromium.org bmeu...@chromium.org verwa...@chromium.org
Issue 3828 has been merged into this issue.
Project Member Comment 7 by bugdroid1@chromium.org, Apr 20 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/53cc6486df3e787898294664c0991f00ce57dcef

commit 53cc6486df3e787898294664c0991f00ce57dcef
Author: jochen <jochen@chromium.org>
Date: Mon Apr 20 13:31:38 2015

Remove support for externally backed elements from the API

Embedders should use ArrayBuffers instead

BUG=v8:3996
LOG=y
R=verwaest@chromium.org,dslomov@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1092923002

Cr-Commit-Position: refs/heads/master@{#27939}

[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/include/v8.h
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/src/api.cc
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/src/api.h
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/src/d8.h
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/src/objects.h
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/test/cctest/compiler/test-simplified-lowering.cc
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/test/cctest/test-api.cc
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/test/cctest/test-heap.cc
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/test/unittests/test-utils.cc
[modify] http://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef/test/unittests/test-utils.h

Project Member Comment 8 by bugdroid1@chromium.org, Apr 21 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126

commit 6d79ceb2945bc23a33ac5c93285a2cab2ba2e126
Author: jochen <jochen@chromium.org>
Date: Tue Apr 21 13:07:32 2015

LayoutDescriptor should inherit from JSTypedArray

It can't just inherit from a FixedTypedArray-like type, as we soon
assume that a FixedTypedArray-like type is always held by an
ArrayBufferView-like type

BUG=v8:3996
R=ishell@chromium.org,verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1084793004

Cr-Commit-Position: refs/heads/master@{#27964}

[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/src/factory.cc
[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/src/factory.h
[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/src/layout-descriptor-inl.h
[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/src/layout-descriptor.cc
[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/src/layout-descriptor.h
[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/src/objects-inl.h
[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/src/objects-printer.cc
[modify] http://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126/test/cctest/test-unboxed-doubles.cc

Project Member Comment 9 by bugdroid1@chromium.org, Apr 21 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8a309a1eaedd8034d6b60908c01a0d188bceee1d

commit 8a309a1eaedd8034d6b60908c01a0d188bceee1d
Author: jochen <jochen@chromium.org>
Date: Tue Apr 21 14:03:09 2015

Revert of LayoutDescriptor should inherit from JSTypedArray (patchset #1 id:1 of https://codereview.chromium.org/1084793004/)

Reason for revert:
breaks mjsunit on debug bots

Original issue's description:
> LayoutDescriptor should inherit from JSTypedArray
>
> It can't just inherit from a FixedTypedArray-like type, as we soon
> assume that a FixedTypedArray-like type is always held by an
> ArrayBufferView-like type
>
> BUG=v8:3996
> R=ishell@chromium.org,verwaest@chromium.org
> LOG=n

TBR=ishell@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1073053006

Cr-Commit-Position: refs/heads/master@{#27968}

[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/src/factory.cc
[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/src/factory.h
[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/src/layout-descriptor-inl.h
[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/src/layout-descriptor.cc
[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/src/layout-descriptor.h
[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/src/objects-inl.h
[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/src/objects-printer.cc
[modify] http://crrev.com/8a309a1eaedd8034d6b60908c01a0d188bceee1d/test/cctest/test-unboxed-doubles.cc

Project Member Comment 10 by bugdroid1@chromium.org, Apr 21 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d20660e05eb9329cd7a0349b6afcbc794bc737c1

commit d20660e05eb9329cd7a0349b6afcbc794bc737c1
Author: jochen <jochen@chromium.org>
Date: Tue Apr 21 15:21:57 2015

Reland "LayoutDescriptor should inherit from JSTypedArray"

Original issue's description:
> LayoutDescriptor should inherit from JSTypedArray
>
> It can't just inherit from a FixedTypedArray-like type, as we soon
> assume that a FixedTypedArray-like type is always held by an
> ArrayBufferView-like type
>
> BUG=v8:3996
> R=ishell@chromium.org,verwaest@chromium.org
> LOG=n

BUG=v8:3996
R=ishell@chromium.org,verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1094333002

Cr-Commit-Position: refs/heads/master@{#27973}

[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/src/factory.cc
[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/src/factory.h
[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/src/layout-descriptor-inl.h
[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/src/layout-descriptor.cc
[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/src/layout-descriptor.h
[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/src/objects-inl.h
[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/src/objects-printer.cc
[modify] http://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1/test/cctest/test-unboxed-doubles.cc

Project Member Comment 11 by bugdroid1@chromium.org, Apr 21 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1692380f9374e1afdf506b52006cd3b1b7eb18aa

commit 1692380f9374e1afdf506b52006cd3b1b7eb18aa
Author: jochen <jochen@chromium.org>
Date: Tue Apr 21 15:58:20 2015

Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset #3 id:40001 of https://codereview.chromium.org/1094333002/)

Reason for revert:
Breaks gbemu

Original issue's description:
> Reland "LayoutDescriptor should inherit from JSTypedArray"
>
> Original issue's description:
> > LayoutDescriptor should inherit from JSTypedArray
> >
> > It can't just inherit from a FixedTypedArray-like type, as we soon
> > assume that a FixedTypedArray-like type is always held by an
> > ArrayBufferView-like type
> >
> > BUG=v8:3996
> > R=ishell@chromium.org,verwaest@chromium.org
> > LOG=n
>
> BUG=v8:3996
> R=ishell@chromium.org,verwaest@chromium.org
> LOG=n

TBR=ishell@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1080403004

Cr-Commit-Position: refs/heads/master@{#27975}

[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/src/factory.cc
[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/src/factory.h
[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/src/layout-descriptor-inl.h
[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/src/layout-descriptor.cc
[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/src/layout-descriptor.h
[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/src/objects-inl.h
[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/src/objects-printer.cc
[modify] http://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa/test/cctest/test-unboxed-doubles.cc

Project Member Comment 12 by bugdroid1@chromium.org, Apr 22 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5ae083a05a6743d6cb91585f449539f7846a5d8c

commit 5ae083a05a6743d6cb91585f449539f7846a5d8c
Author: jochen <jochen@chromium.org>
Date: Wed Apr 22 09:19:38 2015

Remove the weak list of views from array buffers

Instead, views have to check their array buffer for whether
it's neutered or not.

BUG=v8:3996
R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1094863002

Cr-Commit-Position: refs/heads/master@{#27995}

[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/accessors.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/elements.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/elements.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/factory.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/factory.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/heap-snapshot-generator.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/heap/heap.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/heap/heap.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/heap/objects-visiting.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/hydrogen-instructions.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/hydrogen.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/hydrogen.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/objects-debug.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/objects-inl.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/objects.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/objects.h
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/src/snapshot/serialize.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/test/cctest/test-api.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/test/cctest/test-heap-profiler.cc
[modify] http://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c/test/cctest/test-weaktypedarrays.cc

Project Member Comment 13 by bugdroid1@chromium.org, Apr 22 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169

commit 47f2dfa9bd29e5a2f9f362e49bb0d0711f774169
Author: jochen <jochen@chromium.org>
Date: Wed Apr 22 15:03:25 2015

Revert of Remove the weak list of views from array buffers (patchset #6 id:100001 of https://codereview.chromium.org/1094863002/)

Reason for revert:
I'm reverting this while working on the regression fix

Original issue's description:
> Remove the weak list of views from array buffers
>
> Instead, views have to check their array buffer for whether
> it's neutered or not.
>
> BUG=v8:3996
> R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
> LOG=n
>
> Committed: https://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c
> Cr-Commit-Position: refs/heads/master@{#27995}

TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1061753008

Cr-Commit-Position: refs/heads/master@{#28014}

[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/accessors.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/elements.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/elements.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/factory.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/factory.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/heap-snapshot-generator.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/heap/heap.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/heap/heap.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/heap/objects-visiting.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/hydrogen-instructions.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/hydrogen.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/hydrogen.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/objects-debug.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/objects-inl.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/objects.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/objects.h
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/src/snapshot/serialize.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/test/cctest/test-api.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/test/cctest/test-heap-profiler.cc
[modify] http://crrev.com/47f2dfa9bd29e5a2f9f362e49bb0d0711f774169/test/cctest/test-weaktypedarrays.cc

Project Member Comment 14 by bugdroid1@chromium.org, Apr 23 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/655b04637e9da2749f53c866bca8f5f6abb05a3f

commit 655b04637e9da2749f53c866bca8f5f6abb05a3f
Author: jochen <jochen@chromium.org>
Date: Thu Apr 23 13:02:53 2015

Reland "Remove the weak list of views from array buffers"

Original description:
> Instead, views have to check their array buffer for whether
> it's neutered or not.
>
> BUG=v8:3996
> R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
> LOG=n

BUG=v8:3996
R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1093183004

Cr-Commit-Position: refs/heads/master@{#28029}

[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/accessors.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/accessors.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/code-stubs-hydrogen.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/code-stubs.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/elements.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/elements.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/factory.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/factory.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/heap-snapshot-generator.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/heap/heap.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/heap/heap.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/heap/objects-visiting.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/hydrogen-instructions.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/hydrogen.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/hydrogen.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/ic/ic.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/objects-debug.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/objects-inl.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/objects.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/objects.h
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/src/snapshot/serialize.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/test/cctest/test-api.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/test/cctest/test-heap-profiler.cc
[modify] http://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f/test/cctest/test-weaktypedarrays.cc

Project Member Comment 15 by bugdroid1@chromium.org, Apr 24 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/41098dbb0773cd5baeacadbaa3bdb35336be7944

commit 41098dbb0773cd5baeacadbaa3bdb35336be7944
Author: jochen <jochen@chromium.org>
Date: Fri Apr 24 06:46:38 2015

Revert of Reland "Remove the weak list of views from array buffers" (patchset #2 id:20001 of https://codereview.chromium.org/1093183004/)

Reason for revert:
still working on perf

Original issue's description:
> Reland "Remove the weak list of views from array buffers"
>
> Original description:
> > Instead, views have to check their array buffer for whether
> > it's neutered or not.
> >
> > BUG=v8:3996
> > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
> > LOG=n
>
> BUG=v8:3996
> R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
> LOG=n
>
> Committed: https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f
> Cr-Commit-Position: refs/heads/master@{#28029}

TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org,dcarney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1053203007

Cr-Commit-Position: refs/heads/master@{#28038}

[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/accessors.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/accessors.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/code-stubs-hydrogen.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/code-stubs.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/elements.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/elements.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/factory.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/factory.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/heap-snapshot-generator.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/heap/heap.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/heap/heap.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/heap/objects-visiting.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/hydrogen-instructions.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/hydrogen.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/hydrogen.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/ic/ic.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/objects-debug.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/objects-inl.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/objects.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/objects.h
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/src/snapshot/serialize.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/test/cctest/test-api.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/test/cctest/test-heap-profiler.cc
[modify] http://crrev.com/41098dbb0773cd5baeacadbaa3bdb35336be7944/test/cctest/test-weaktypedarrays.cc

Project Member Comment 16 by bugdroid1@chromium.org, Apr 27 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3383f6280e4861f09d70118f14d86de5eee102cb

commit 3383f6280e4861f09d70118f14d86de5eee102cb
Author: jochen <jochen@chromium.org>
Date: Mon Apr 27 09:28:16 2015

Reland "Remove the weak list of views from array buffers"

Original description:
> Instead, views have to check their array buffer for whether
> it's neutered or not.
>
> BUG=v8:3996
> R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
> LOG=n

BUG=v8:3996
R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1107843002

Cr-Commit-Position: refs/heads/master@{#28060}

[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/accessors.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/accessors.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/code-stubs-hydrogen.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/code-stubs.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/elements.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/elements.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/factory.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/factory.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/heap-snapshot-generator.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/heap/heap.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/heap/heap.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/heap/objects-visiting.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/hydrogen-instructions.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/hydrogen.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/hydrogen.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/ic/ic.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/objects-debug.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/objects-inl.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/objects.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/objects.h
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/src/snapshot/serialize.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/test/cctest/test-api.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/test/cctest/test-heap-profiler.cc
[modify] http://crrev.com/3383f6280e4861f09d70118f14d86de5eee102cb/test/cctest/test-weaktypedarrays.cc

Project Member Comment 17 by bugdroid1@chromium.org, Apr 27 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6a62e321381e1a212983804c4197068e842b240f

commit 6a62e321381e1a212983804c4197068e842b240f
Author: jochen <jochen@chromium.org>
Date: Mon Apr 27 16:18:16 2015

Make it possible to hoist the neutering check for TA property accesses

Also correctly set up the dependency between propoerty and elements
accesses and the checks

BUG=v8:3996
R=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1107993002

Cr-Commit-Position: refs/heads/master@{#28087}

[modify] http://crrev.com/6a62e321381e1a212983804c4197068e842b240f/src/hydrogen.cc

Project Member Comment 18 by bugdroid1@chromium.org, Apr 27 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3f27bb218860586859ae7b6bdea75dbbd0a73a1d

commit 3f27bb218860586859ae7b6bdea75dbbd0a73a1d
Author: machenbach <machenbach@chromium.org>
Date: Mon Apr 27 16:56:31 2015

Revert of Make it possible to hoist the neutering check for TA property accesses (patchset #1 id:1 of https://codereview.chromium.org/1107993002/)

Reason for revert:
[Sheriff] Breaks benchmarks:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/3403

Original issue's description:
> Make it possible to hoist the neutering check for TA property accesses
>
> Also correctly set up the dependency between propoerty and elements
> accesses and the checks
>
> BUG=v8:3996
> R=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/6a62e321381e1a212983804c4197068e842b240f
> Cr-Commit-Position: refs/heads/master@{#28087}

TBR=hpayer@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1108823003

Cr-Commit-Position: refs/heads/master@{#28088}

[modify] http://crrev.com/3f27bb218860586859ae7b6bdea75dbbd0a73a1d/src/hydrogen.cc

Project Member Comment 19 by bugdroid1@chromium.org, Apr 28 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a2e6f970c766c4e197a20eb7badd251757249355

commit a2e6f970c766c4e197a20eb7badd251757249355
Author: jochen <jochen@chromium.org>
Date: Tue Apr 28 13:42:54 2015

Add HArrayBufferNotNeutered instruction

This instruction can be hoisted out of loops even though it contains a branch.

BUG=v8:3996
R=bmeurer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1108313003

Cr-Commit-Position: refs/heads/master@{#28109}

[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/arm/lithium-arm.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/arm/lithium-arm.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/arm/lithium-codegen-arm.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/arm64/lithium-arm64.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/arm64/lithium-arm64.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/arm64/lithium-codegen-arm64.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/hydrogen-instructions.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/hydrogen-instructions.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/hydrogen.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/ia32/lithium-codegen-ia32.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/ia32/lithium-ia32.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/ia32/lithium-ia32.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/mips/lithium-codegen-mips.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/mips/lithium-mips.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/mips/lithium-mips.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/mips64/lithium-codegen-mips64.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/mips64/lithium-mips64.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/mips64/lithium-mips64.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/ppc/lithium-codegen-ppc.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/ppc/lithium-ppc.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/ppc/lithium-ppc.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/x64/lithium-codegen-x64.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/x64/lithium-x64.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/x64/lithium-x64.h
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/x87/lithium-codegen-x87.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/x87/lithium-x87.cc
[modify] http://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355/src/x87/lithium-x87.h

Project Member Comment 20 by bugdroid1@chromium.org, Apr 29 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2d39709cf5ee17637f6f2d75380a9e61ae0b342b

commit 2d39709cf5ee17637f6f2d75380a9e61ae0b342b
Author: jochen <jochen@chromium.org>
Date: Wed Apr 29 13:04:43 2015

Remove the weak list of array buffers

Instead, collect live array buffers during marking and free pointers we
no longer found.

BUG=v8:3996
R=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1114563002

Cr-Commit-Position: refs/heads/master@{#28132}

[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/api.cc
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/heap-snapshot-generator.cc
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/heap/heap.cc
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/heap/heap.h
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/heap/mark-compact.cc
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/heap/objects-visiting.cc
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/heap/objects-visiting.h
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/objects-inl.h
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/objects.h
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/runtime/runtime.h
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/src/snapshot/serialize.cc
[modify] http://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b/test/cctest/cctest.gyp
[delete] http://crrev.com/cec53692d17f21374fbd2df1fcef6f60adf7dd96/test/cctest/test-weaktypedarrays.cc

Comment 21 by habl...@google.com, Apr 29 2015
Status: Assigned
Project Member Comment 22 by bugdroid1@chromium.org, Apr 30 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3e25666c79373789bf020a2f9ef4be5e8d96dc6c

commit 3e25666c79373789bf020a2f9ef4be5e8d96dc6c
Author: machenbach <machenbach@chromium.org>
Date: Thu Apr 30 08:38:18 2015

Revert of Remove the weak list of array buffers (patchset #8 id:140001 of https://codereview.chromium.org/1114563002/)

Reason for revert:
[Sheriff] Crashes in layout tests:
https://chromegw.corp.google.com/i/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2668

Original issue's description:
> Remove the weak list of array buffers
>
> Instead, collect live array buffers during marking and free pointers we
> no longer found.
>
> BUG=v8:3996
> R=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b
> Cr-Commit-Position: refs/heads/master@{#28132}

TBR=dslomov@chromium.org,hpayer@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1115043005

Cr-Commit-Position: refs/heads/master@{#28148}

[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/api.cc
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/heap-snapshot-generator.cc
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/heap/heap.cc
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/heap/heap.h
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/heap/mark-compact.cc
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/heap/objects-visiting.cc
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/heap/objects-visiting.h
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/objects-inl.h
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/objects.h
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/runtime/runtime.h
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/src/snapshot/serialize.cc
[modify] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/test/cctest/cctest.gyp
[add] http://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c/test/cctest/test-weaktypedarrays.cc

Project Member Comment 23 by bugdroid1@chromium.org, Apr 30 2015
Labels: merge-merged-4.3
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b33a56cbc17f2821764663a00532173fe0a84109

commit b33a56cbc17f2821764663a00532173fe0a84109
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Apr 30 09:41:57 2015

Version 4.3.61.15 (cherry-pick)

Merged 2a5eb8299b2fa13d57d1d4741d4f121df1c3e883

Expose an API on ArrayBufferView to copy out content w/o changing the buffer

BUG=v8:3996
LOG=N
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/1119513003

Cr-Commit-Position: refs/branch-heads/4.3@{#18}
Cr-Branched-From: f5c0a23a505616796a628d64f4ffe377d1fc4bcf-refs/heads/4.3.61@{#1}
Cr-Branched-From: 0a7d4f496a554028de0ab5a963c3a004e693b4cb-refs/heads/master@{#27508}

[modify] http://crrev.com/b33a56cbc17f2821764663a00532173fe0a84109/include/v8-version.h
[modify] http://crrev.com/b33a56cbc17f2821764663a00532173fe0a84109/include/v8.h
[modify] http://crrev.com/b33a56cbc17f2821764663a00532173fe0a84109/src/api.cc
[modify] http://crrev.com/b33a56cbc17f2821764663a00532173fe0a84109/test/cctest/cctest.gyp
[add] http://crrev.com/b33a56cbc17f2821764663a00532173fe0a84109/test/cctest/test-typedarrays.cc

Project Member Comment 24 by bugdroid1@chromium.org, Apr 30 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/92a4588a7bc9210eeda261dfb6a8f5bd7030c67f

commit 92a4588a7bc9210eeda261dfb6a8f5bd7030c67f
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Apr 30 09:47:34 2015

Version 4.3.61.16 (cherry-pick)

Merged ada32ae63651f544801647b7a6fe16f0f6146996

Expose ArrayBufferView::HasBuffer

BUG=v8:3996
LOG=N
R=danno@chromium.org

Review URL: https://codereview.chromium.org/1110713004

Cr-Commit-Position: refs/branch-heads/4.3@{#19}
Cr-Branched-From: f5c0a23a505616796a628d64f4ffe377d1fc4bcf-refs/heads/4.3.61@{#1}
Cr-Branched-From: 0a7d4f496a554028de0ab5a963c3a004e693b4cb-refs/heads/master@{#27508}

[modify] http://crrev.com/92a4588a7bc9210eeda261dfb6a8f5bd7030c67f/include/v8-version.h
[modify] http://crrev.com/92a4588a7bc9210eeda261dfb6a8f5bd7030c67f/include/v8.h
[modify] http://crrev.com/92a4588a7bc9210eeda261dfb6a8f5bd7030c67f/src/api.cc
[modify] http://crrev.com/92a4588a7bc9210eeda261dfb6a8f5bd7030c67f/test/cctest/test-typedarrays.cc

Project Member Comment 25 by bugdroid1@chromium.org, Apr 30 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ac1c88a9b27973e6976a9f72ac84a0ebf940293e

commit ac1c88a9b27973e6976a9f72ac84a0ebf940293e
Author: jochen <jochen@chromium.org>
Date: Thu Apr 30 10:57:44 2015

Reland "Remove the weak list of array buffers"

Original issue's description:
> Remove the weak list of array buffers
>
> Instead, collect live array buffers during marking and free pointers we
> no longer found.
>
> BUG=v8:3996
> R=hpayer@chromium.org
> LOG=n

BUG=v8:3996
TBR=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1115853004

Cr-Commit-Position: refs/heads/master@{#28156}

[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/api.cc
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/heap-snapshot-generator.cc
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/heap/heap.cc
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/heap/heap.h
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/heap/mark-compact.cc
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/heap/objects-visiting.cc
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/heap/objects-visiting.h
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/objects-inl.h
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/objects.h
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/runtime/runtime.h
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/src/snapshot/serialize.cc
[modify] http://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e/test/cctest/cctest.gyp
[delete] http://crrev.com/a338f2738a81a32476261218f18a60db3706e7ec/test/cctest/test-weaktypedarrays.cc

Project Member Comment 26 by bugdroid1@chromium.org, Apr 30 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/98140318fac953e675369d0e97dc8f8646324060

commit 98140318fac953e675369d0e97dc8f8646324060
Author: jochen <jochen@chromium.org>
Date: Thu Apr 30 13:46:27 2015

Unify internal and external typed arrays a bit

Just give internal ones an ArrayBuffer with a NULL backing store. This
simplifies the access checks a lot.

BUG=v8:3996
R=hpayer@chromium.org,verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1109353003

Cr-Commit-Position: refs/heads/master@{#28168}

[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/include/v8.h
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/api.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/arm/lithium-codegen-arm.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/arm64/lithium-codegen-arm64.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/bootstrapper.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/contexts.h
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/factory.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/hydrogen-instructions.h
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/hydrogen.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/hydrogen.h
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/ia32/lithium-codegen-ia32.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/mips/lithium-codegen-mips.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/mips64/lithium-codegen-mips64.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/objects-inl.h
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/objects.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/ppc/lithium-codegen-ppc.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/x64/lithium-codegen-x64.cc
[modify] http://crrev.com/98140318fac953e675369d0e97dc8f8646324060/src/x87/lithium-codegen-x87.cc

Project Member Comment 27 by bugdroid1@chromium.org, May 7 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e5ad1b1d53754d7c92c012c7ca69a315cc706944

commit e5ad1b1d53754d7c92c012c7ca69a315cc706944
Author: jochen <jochen@chromium.org>
Date: Thu May 07 05:44:47 2015

Make sure fixed typed array is always double aligned for doubles

Allows for getting rid of the special casing for float64 and is probably
faster.

BUG=v8:3996
R=verwaest@chromium.org,dslomov@chromium.org,plind44@gmail.com
LOG=n

Review URL: https://codereview.chromium.org/1128433006

Cr-Commit-Position: refs/heads/master@{#28281}

[modify] http://crrev.com/e5ad1b1d53754d7c92c012c7ca69a315cc706944/src/globals.h
[modify] http://crrev.com/e5ad1b1d53754d7c92c012c7ca69a315cc706944/src/heap/heap.cc
[modify] http://crrev.com/e5ad1b1d53754d7c92c012c7ca69a315cc706944/src/hydrogen.cc
[modify] http://crrev.com/e5ad1b1d53754d7c92c012c7ca69a315cc706944/src/objects-inl.h
[modify] http://crrev.com/e5ad1b1d53754d7c92c012c7ca69a315cc706944/src/objects.h

Project Member Comment 28 by bugdroid1@chromium.org, May 8 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/18beb5009aa1822d5a9cb16c0eb6e0c3de34734b

commit 18beb5009aa1822d5a9cb16c0eb6e0c3de34734b
Author: jochen <jochen@chromium.org>
Date: Fri May 08 13:30:55 2015

Add support for on-heap typed arrays to HLoadKeyed::InferRange

BUG=v8:3996
R=bmeurer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1126413005

Cr-Commit-Position: refs/heads/master@{#28319}

[modify] http://crrev.com/18beb5009aa1822d5a9cb16c0eb6e0c3de34734b/src/hydrogen-instructions.cc

Project Member Comment 29 by bugdroid1@chromium.org, Jun 1 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f91df1f25dec4f1982c40af6118da8b699777475

commit f91df1f25dec4f1982c40af6118da8b699777475
Author: jochen <jochen@chromium.org>
Date: Mon Jun 01 10:07:09 2015

Re-enable on-heap typed array allocation

BUG=v8:3996
R=mstarzinger@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/1166433004

Cr-Commit-Position: refs/heads/master@{#28722}

[modify] http://crrev.com/f91df1f25dec4f1982c40af6118da8b699777475/src/hydrogen.cc

Project Member Comment 30 by bugdroid1@chromium.org, Jun 1 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3be8651fccba6479908df22a32a2adff2c49a1f4

commit 3be8651fccba6479908df22a32a2adff2c49a1f4
Author: bmeurer <bmeurer@chromium.org>
Date: Mon Jun 01 10:58:51 2015

Revert of Re-enable on-heap typed array allocation (patchset #1 id:1 of https://codereview.chromium.org/1166433004/)

Reason for revert:
Win32 breakage

Original issue's description:
> Re-enable on-heap typed array allocation
>
> BUG=v8:3996
> R=mstarzinger@chromium.org
> LOG=y
>
> Committed: https://crrev.com/f91df1f25dec4f1982c40af6118da8b699777475
> Cr-Commit-Position: refs/heads/master@{#28722}

TBR=mstarzinger@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1158193004

Cr-Commit-Position: refs/heads/master@{#28723}

[modify] http://crrev.com/3be8651fccba6479908df22a32a2adff2c49a1f4/src/hydrogen.cc

Project Member Comment 31 by bugdroid1@chromium.org, Jun 1 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/65cd41e394366c82ee1035240d8ce3c4e5f06dd4

commit 65cd41e394366c82ee1035240d8ce3c4e5f06dd4
Author: jochen <jochen@chromium.org>
Date: Mon Jun 01 14:22:58 2015

Reland "Re-enable on-heap typed array allocation"

R=mstarzinger@chromium.org
BUG=v8:3996
LOG=y

Review URL: https://codereview.chromium.org/1144143006

Cr-Commit-Position: refs/heads/master@{#28729}

[modify] http://crrev.com/65cd41e394366c82ee1035240d8ce3c4e5f06dd4/src/bootstrapper.cc
[modify] http://crrev.com/65cd41e394366c82ee1035240d8ce3c4e5f06dd4/src/hydrogen.cc

Project Member Comment 32 by bugdroid1@chromium.org, Jun 3 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1d1df96d2349a2e2089c00bbf0190318b0a84579

commit 1d1df96d2349a2e2089c00bbf0190318b0a84579
Author: jochen <jochen@chromium.org>
Date: Wed Jun 03 07:41:28 2015

Also allocate small typed arrays on heap when initialized from an array-like

This means something like new Float32Array([23, 42]) will be allocated on heap.

BUG=v8:3996
R=bmeurer@chromium.org,mstarzinger@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/1144393003

Cr-Commit-Position: refs/heads/master@{#28780}

[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/factory.cc
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/factory.h
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/heap/heap.cc
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/heap/heap.h
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/hydrogen.cc
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/hydrogen.h
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/layout-descriptor-inl.h
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/runtime/runtime.h
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/src/typedarray.js
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/test/cctest/test-heap.cc
[modify] http://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579/test/cctest/test-typedarrays.cc

Project Member Comment 33 by bugdroid1@chromium.org, Jun 12 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/506397d0a4241c19f5fab890e49e22d1d9b28bdc

commit 506397d0a4241c19f5fab890e49e22d1d9b28bdc
Author: jochen <jochen@chromium.org>
Date: Fri Jun 12 05:35:24 2015

Keep track of array buffers in new space separately

BUG=v8:3996
R=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1133773002

Cr-Commit-Position: refs/heads/master@{#28978}

[modify] http://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc/src/api.cc
[modify] http://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc/src/heap/heap.cc
[modify] http://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc/src/heap/heap.h
[modify] http://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc/src/heap/mark-compact.cc
[modify] http://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc/src/objects.cc
[modify] http://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc/src/runtime/runtime-typedarray.cc

Project Member Comment 34 by bugdroid1@chromium.org, Jun 12 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/64ba57ce612ad698dec64135a5cf57990ffd55f6

commit 64ba57ce612ad698dec64135a5cf57990ffd55f6
Author: bmeurer <bmeurer@chromium.org>
Date: Fri Jun 12 06:29:04 2015

Revert of Keep track of array buffers in new space separately (patchset #4 id:60001 of https://codereview.chromium.org/1133773002/)

Reason for revert:
GC stress unhappy

Original issue's description:
> Keep track of array buffers in new space separately
>
> BUG=v8:3996
> R=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc
> Cr-Commit-Position: refs/heads/master@{#28978}

TBR=hpayer@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1178403003

Cr-Commit-Position: refs/heads/master@{#28979}

[modify] http://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6/src/api.cc
[modify] http://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6/src/heap/heap.cc
[modify] http://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6/src/heap/heap.h
[modify] http://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6/src/heap/mark-compact.cc
[modify] http://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6/src/objects.cc
[modify] http://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6/src/runtime/runtime-typedarray.cc

Project Member Comment 35 by bugdroid1@chromium.org, Jun 12 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/89b9a2cfb317e52186f682c91502b22932d52db3

commit 89b9a2cfb317e52186f682c91502b22932d52db3
Author: jochen <jochen@chromium.org>
Date: Fri Jun 12 09:34:38 2015

Reland "Keep track of array buffers in new space separately"

Original review https://codereview.chromium.org/1133773002/

BUG=v8:3996
TBR=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1177083003

Cr-Commit-Position: refs/heads/master@{#28987}

[modify] http://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3/src/api.cc
[modify] http://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3/src/heap/heap.cc
[modify] http://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3/src/heap/heap.h
[modify] http://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3/src/heap/mark-compact.cc
[modify] http://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3/src/objects.cc
[modify] http://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3/src/runtime/runtime-typedarray.cc

Project Member Comment 36 by bugdroid1@chromium.org, Jun 14 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a99fe1fd765d1302bec777ee36ebdb0d3216384e

commit a99fe1fd765d1302bec777ee36ebdb0d3216384e
Author: jochen <jochen@chromium.org>
Date: Sun Jun 14 18:23:17 2015

Revert of Reland "Keep track of array buffers in new space separately" (patchset #2 id:20001 of https://codereview.chromium.org/1177083003/)

Reason for revert:
Still broken

Original issue's description:
> Reland "Keep track of array buffers in new space separately"
>
> Original review https://codereview.chromium.org/1133773002/
>
> BUG=v8:3996
> TBR=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3
> Cr-Commit-Position: refs/heads/master@{#28987}

TBR=hpayer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1186613007

Cr-Commit-Position: refs/heads/master@{#29009}

[modify] http://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e/src/api.cc
[modify] http://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e/src/heap/heap.cc
[modify] http://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e/src/heap/heap.h
[modify] http://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e/src/heap/mark-compact.cc
[modify] http://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e/src/objects.cc
[modify] http://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e/src/runtime/runtime-typedarray.cc

Project Member Comment 37 by bugdroid1@chromium.org, Jun 15 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/29715d7c072f2c14968ce772b22acc9465c2decf

commit 29715d7c072f2c14968ce772b22acc9465c2decf
Author: jochen <jochen@chromium.org>
Date: Mon Jun 15 07:57:32 2015

Reland "Keep track of array buffers in new space separately"

Original review https://codereview.chromium.org/1133773002/

BUG=v8:3996
TBR=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1177293003

Cr-Commit-Position: refs/heads/master@{#29014}

[modify] http://crrev.com/29715d7c072f2c14968ce772b22acc9465c2decf/src/api.cc
[modify] http://crrev.com/29715d7c072f2c14968ce772b22acc9465c2decf/src/heap/heap.cc
[modify] http://crrev.com/29715d7c072f2c14968ce772b22acc9465c2decf/src/heap/heap.h
[modify] http://crrev.com/29715d7c072f2c14968ce772b22acc9465c2decf/src/heap/mark-compact.cc
[modify] http://crrev.com/29715d7c072f2c14968ce772b22acc9465c2decf/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/29715d7c072f2c14968ce772b22acc9465c2decf/src/objects.cc
[modify] http://crrev.com/29715d7c072f2c14968ce772b22acc9465c2decf/src/runtime/runtime-typedarray.cc

Project Member Comment 38 by bugdroid1@chromium.org, Jun 16 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb

commit 6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb
Author: jochen <jochen@chromium.org>
Date: Tue Jun 16 07:37:16 2015

Introduce a base pointer field in FixedTypedArrayBase and teach GC about it

This is the first step towards unifying external and on-heap typed arrays.

The end-state will be that this base pointer either points to the on-heap values
or to the externally allocated array buffer.

BUG=v8:3996
R=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1176263004

Cr-Commit-Position: refs/heads/master@{#29039}

[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/elements-kind.cc
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/heap/heap.cc
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/heap/mark-compact.cc
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/heap/store-buffer.cc
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/hydrogen-instructions.h
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/hydrogen.cc
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/objects-debug.cc
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/objects-inl.h
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/objects.cc
[modify] http://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb/src/objects.h

Project Member Comment 39 by bugdroid1@chromium.org, Jun 18 2015
Labels: merge-merged-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e757ff174fa88807fec7f974e77dedb7422984b7

commit e757ff174fa88807fec7f974e77dedb7422984b7
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Jun 18 09:04:37 2015

Version 4.4.63.8 (cherry-pick)

Merged 29715d7c072f2c14968ce772b22acc9465c2decf

Reland "Keep track of array buffers in new space separately"

BUG=v8:3996
LOG=N
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/1188313006.

Cr-Commit-Position: refs/branch-heads/4.4@{#12}
Cr-Branched-From: 2e4c5505e85d94b520e853dda3f0cc3f2769e5f0-refs/heads/4.4.63@{#1}
Cr-Branched-From: 0208b8e3a1d7ce393308866386ac8d94f85faa05-refs/heads/master@{#28333}

[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/include/v8-version.h
[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/src/api.cc
[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/src/heap/heap.cc
[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/src/heap/heap.h
[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/src/heap/mark-compact.cc
[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/src/heap/objects-visiting-inl.h
[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/src/objects.cc
[modify] http://crrev.com/e757ff174fa88807fec7f974e77dedb7422984b7/src/runtime/runtime-typedarray.cc

Project Member Comment 40 by bugdroid1@chromium.org, Jul 20 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4e263bc581081c1fa925554943693f3e386fc815

commit 4e263bc581081c1fa925554943693f3e386fc815
Author: jochen <jochen@chromium.org>
Date: Mon Jul 20 15:17:53 2015

Add support for adding an external and a tagged pointer

This will be used to compute the base pointer of the new unified
representation for both on-heap and external typed arrays. The idea is
that either the external or the tagged pointer is 0 (although in
practice, if the tagged pointer is non-0, the external pointer will
contain the offset from the start of the on-heap typed array to the data
in the on-heap typed array).

The HAdd is marked as depending on new-space promotion, as the tagged
pointer might move during GC, and so the result of the addition needs to
be recomputed.

BUG=v8:3996
R=jarin@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1244693002

Cr-Commit-Position: refs/heads/master@{#29760}

[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/arm/lithium-arm.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/arm64/lithium-arm64.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/hydrogen-instructions.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/hydrogen-instructions.h
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/ia32/lithium-ia32.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/mips/lithium-mips.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/mips64/lithium-mips64.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/ppc/lithium-ppc.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/x64/lithium-x64.cc
[modify] http://crrev.com/4e263bc581081c1fa925554943693f3e386fc815/src/x87/lithium-x87.cc

Project Member Comment 41 by bugdroid1@chromium.org, Jul 23 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7bedb50f7dac35e00e73fc41f62310c795a6eb24

commit 7bedb50f7dac35e00e73fc41f62310c795a6eb24
Author: jochen <jochen@chromium.org>
Date: Thu Jul 23 12:48:57 2015

Remove code for no longer present external array on any object API

BUG=v8:3996
R=jarin@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1249723005

Cr-Commit-Position: refs/heads/master@{#29808}

[modify] http://crrev.com/7bedb50f7dac35e00e73fc41f62310c795a6eb24/src/objects.cc

Project Member Comment 42 by bugdroid1@chromium.org, Jul 27 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/607ef7c6009a24ebf195b4cab7b0b436c5afd21c

commit 607ef7c6009a24ebf195b4cab7b0b436c5afd21c
Author: jochen <jochen@chromium.org>
Date: Mon Jul 27 13:19:09 2015

Remove ExternalArray, derived types, and element kinds

BUG=v8:3996
R=jarin@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/1254623002

Cr-Commit-Position: refs/heads/master@{#29872}

[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/include/v8.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/arm/lithium-arm.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/arm/lithium-arm.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/arm/lithium-codegen-arm.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/arm64/lithium-arm64.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/arm64/lithium-codegen-arm64.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/bootstrapper.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/code-stubs-hydrogen.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/code-stubs.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/compiler/access-builder.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/compiler/access-builder.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/compiler/js-typed-lowering.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/contexts.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/elements-kind.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/elements-kind.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/elements.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/factory.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/factory.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/heap-snapshot-generator.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/heap/heap.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/heap/heap.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/heap/objects-visiting.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/hydrogen-instructions.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/hydrogen-instructions.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/hydrogen-uint32-analysis.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/hydrogen.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ia32/lithium-codegen-ia32.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ia32/lithium-ia32.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ia32/lithium-ia32.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ic/handler-compiler.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ic/ic-compiler.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ic/ic.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/lookup.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/mips/lithium-codegen-mips.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/mips/lithium-mips.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/mips/lithium-mips.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/mips64/lithium-codegen-mips64.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/mips64/lithium-mips64.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/mips64/lithium-mips64.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/objects-debug.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/objects-inl.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/objects-printer.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/objects.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/objects.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ppc/lithium-codegen-ppc.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ppc/lithium-ppc.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/ppc/lithium-ppc.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/runtime/runtime-array.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/runtime/runtime-test.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/runtime/runtime.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/x64/lithium-codegen-x64.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/x64/lithium-x64.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/x64/lithium-x64.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/x87/lithium-codegen-x87.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/x87/lithium-x87.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/src/x87/lithium-x87.h
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/test/cctest/compiler/test-run-properties.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/test/cctest/test-api.cc
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/test/mjsunit/elements-kind.js
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/test/mjsunit/opt-elements-kind.js
[modify] http://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c/test/mjsunit/osr-elements-kind.js

Status: FIxed
Comment 44 by kbr@chromium.org, Jul 27 2015
Fantastic! Excellent work Jochen!

Project Member Comment 45 by bugdroid1@chromium.org, Jul 27 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/814048a04f667f4537ad80a3ae63d3699b4afdb2

commit 814048a04f667f4537ad80a3ae63d3699b4afdb2
Author: machenbach <machenbach@chromium.org>
Date: Mon Jul 27 20:32:00 2015

Revert of Remove ExternalArray, derived types, and element kinds (patchset #5 id:80001 of https://codereview.chromium.org/1254623002/)

Reason for revert:
[Sheriff] Breaks several layout tests, e.g.:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/1067

Several output lines change from PASS to FAIL. If the changes are intended, please land a needsmanualrebaseline change in blink first.

Original issue's description:
> Remove ExternalArray, derived types, and element kinds
>
> BUG=v8:3996
> R=jarin@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org
> LOG=y
>
> Committed: https://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c
> Cr-Commit-Position: refs/heads/master@{#29872}

TBR=bmeurer@chromium.org,hpayer@chromium.org,jarin@chromium.org,mvstanton@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1257223002

Cr-Commit-Position: refs/heads/master@{#29883}

[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/include/v8.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/arm/lithium-arm.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/arm/lithium-arm.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/arm/lithium-codegen-arm.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/arm64/lithium-arm64.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/arm64/lithium-codegen-arm64.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/bootstrapper.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/code-stubs-hydrogen.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/code-stubs.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/compiler/access-builder.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/compiler/access-builder.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/compiler/js-typed-lowering.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/contexts.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/elements-kind.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/elements-kind.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/elements.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/factory.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/factory.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/heap-snapshot-generator.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/heap/heap.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/heap/heap.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/heap/objects-visiting.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/hydrogen-instructions.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/hydrogen-instructions.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/hydrogen-uint32-analysis.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/hydrogen.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ia32/lithium-codegen-ia32.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ia32/lithium-ia32.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ia32/lithium-ia32.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ic/handler-compiler.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ic/ic-compiler.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ic/ic.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/lookup.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/mips/lithium-codegen-mips.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/mips/lithium-mips.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/mips/lithium-mips.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/mips64/lithium-codegen-mips64.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/mips64/lithium-mips64.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/mips64/lithium-mips64.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/objects-debug.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/objects-inl.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/objects-printer.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/objects.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/objects.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ppc/lithium-codegen-ppc.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ppc/lithium-ppc.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/ppc/lithium-ppc.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/runtime/runtime-array.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/runtime/runtime-test.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/runtime/runtime.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/x64/lithium-codegen-x64.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/x64/lithium-x64.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/x64/lithium-x64.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/x87/lithium-codegen-x87.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/x87/lithium-x87.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/src/x87/lithium-x87.h
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/test/cctest/compiler/test-run-properties.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/test/cctest/test-api.cc
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/test/mjsunit/elements-kind.js
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/test/mjsunit/opt-elements-kind.js
[modify] http://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2/test/mjsunit/osr-elements-kind.js

Project Member Comment 46 by bugdroid1@chromium.org, Jul 28 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fded08f6949ac3f673f64d3e36be5d03800660e9

commit fded08f6949ac3f673f64d3e36be5d03800660e9
Author: jochen <jochen@chromium.org>
Date: Tue Jul 28 09:29:34 2015

Reland of "Remove ExternalArray, derived types, and element kinds"

Original issue's description:
> Remove ExternalArray, derived types, and element kinds
>
> BUG=v8:3996
> R=jarin@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org
> LOG=y
>
> Committed: https://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c
> Cr-Commit-Position: refs/heads/master@{#29872}

BUG=v8:3996
R=bmeurer@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/1262583002

Cr-Commit-Position: refs/heads/master@{#29893}

[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/include/v8.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/arm/lithium-arm.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/arm/lithium-arm.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/arm/lithium-codegen-arm.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/arm64/lithium-arm64.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/arm64/lithium-codegen-arm64.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/bootstrapper.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/code-stubs-hydrogen.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/code-stubs.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/compiler/access-builder.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/compiler/access-builder.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/compiler/js-typed-lowering.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/contexts.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/elements-kind.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/elements-kind.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/elements.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/factory.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/factory.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/heap-snapshot-generator.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/heap/heap.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/heap/heap.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/heap/objects-visiting.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/hydrogen-instructions.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/hydrogen-instructions.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/hydrogen-uint32-analysis.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/hydrogen.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ia32/lithium-codegen-ia32.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ia32/lithium-ia32.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ia32/lithium-ia32.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ic/handler-compiler.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ic/ic-compiler.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ic/ic.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/lookup.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/mips/lithium-codegen-mips.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/mips/lithium-mips.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/mips/lithium-mips.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/mips64/lithium-codegen-mips64.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/mips64/lithium-mips64.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/mips64/lithium-mips64.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/objects-debug.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/objects-inl.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/objects-printer.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/objects.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/objects.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ppc/lithium-codegen-ppc.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ppc/lithium-ppc.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/ppc/lithium-ppc.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/runtime/runtime-array.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/runtime/runtime-test.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/runtime/runtime.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/x64/lithium-codegen-x64.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/x64/lithium-x64.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/x64/lithium-x64.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/x87/lithium-codegen-x87.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/x87/lithium-x87.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/src/x87/lithium-x87.h
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/test/cctest/compiler/test-run-properties.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/test/cctest/test-api.cc
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/test/mjsunit/elements-kind.js
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/test/mjsunit/opt-elements-kind.js
[modify] http://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9/test/mjsunit/osr-elements-kind.js

Labels: Priority-2
Sign in to add a comment