New issue
Advanced search Search tips
Starred by 19 users

Issue metadata

Status: Assigned
Owner:
Cc:
HW: ----
NextAction: ----
OS: All
Priority: 2
Type: Bug

Blocked on:
issue 5459
issue 3664

Blocking:
issue 2935



Sign in to add a comment
link

Issue 3665: Allocation site pretenuring degrades performance in Ember

Reported by u...@chromium.org, Oct 30 2014 Project Member

Issue description

v8:3664 tracks deoptimizations caused by weak references. With disabled weak references, allocation site pretenuring is the next common cause of deoptimization.

"Complex List" test at http://samsaffron.github.io/ember-performance/?ember=1.8.0 runs
- 185.11ms without weak references, with allocation site pretenuring (--js-flags="--noweak-embedded-objects-in-optimized-code --noweak-embedded-maps-in-optimized-code")
- 169.57ms without weak references and without allocation site pretenuring (--js-flags="--noweak-embedded-objects-in-optimized-code --noweak-embedded-maps-in-optimized-code --noallocation-site-pretenuring")
 

Comment 1 by u...@chromium.org, Oct 30 2014

Blocking: v8:2935

Comment 2 by habl...@google.com, Apr 29 2015

Status: Assigned

Comment 3 by wyc...@gmail.com, Nov 14 2015

Any progress on this?

Comment 4 by mvstan...@chromium.org, Nov 15 2015

Yes, months ago we tried disabling allocation site pretenuring, so that none of these deopts occur. The performance effect was negligible. Deopts occurred in those functions anyway, for other reasons.

Comment 5 by bmeu...@chromium.org, Oct 8 2016

Blockedon: 5459

Comment 6 by hablich@chromium.org, Mar 23 2017

Labels: Priority-2

Sign in to add a comment