New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 12 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2015
Cc:
Components:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: FeatureRequest



Sign in to add a comment

Implement `Array.prototype.includes`

Reported by dome...@domenicdenicola.com, Sep 18 2014

Issue description

Spec: https://github.com/domenic/Array.prototype.contains/
test262 tests: https://github.com/tc39/test262/pull/95

Agreed in July TC39 meeting to advance to stage 1. Is awaiting experimental implementations to advance to stage 2.

Mozilla is implementing this at https://bugzilla.mozilla.org/show_bug.cgi?id=1069063
 
Cc: dslomov@chromium.org
Labels: Type-FeatureRequest Harmony
Status: WorkingAsIntended
Latest status is that Mozilla has retracted their implementation as it breaks the web. I am closing this bug since we will not implement this proposal in its current form

Comment 2 by d@domenic.me, Nov 20 2014

Can we update this to reflect Array.prototype.includes and reopen?

Comment 3 Deleted

Ah, `includes` (with an `s`) narrowly misses conflict with Prototype.js which adds `include` but then there's https://github.com/search?utf8=%E2%9C%93&q=%22Array.prototype.includes%22&type=Code&ref=searchresults
LOL, now the GitHub search for Array#includes is polluted with @domenic's repo changes :)

Still though, excluding his repos, there's still some use on the web. Will be interesting to see if there's a conflict.

Comment 7 by math...@qiwi.be, Nov 20 2014

Status: Accepted
Summary: Implement `Array.prototype.includes` (was: Implement Array.prototype.contains)

Comment 9 by habl...@google.com, Apr 29 2015

Status: Available
Labels: Priority-Medium Area-Language
Owner: rossberg@chromium.org
Status: Assigned
This seems to be fixed, isn't it?

Comment 11 by adamk@chromium.org, Jul 17 2015

Status: Fixed
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 11 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/43655380bde57da6c566050d7f65cc8fec719963

commit 43655380bde57da6c566050d7f65cc8fec719963
Author: domenic <domenic@chromium.org>
Date: Tue Aug 11 22:00:44 2015

Stage --harmony-array-includes

BUG= v8:3575 
R=adamk@chromium.org, rossberg@chromium.org
LOG=Y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1283963002

Cr-Commit-Position: refs/heads/master@{#30121}

[modify] http://crrev.com/43655380bde57da6c566050d7f65cc8fec719963/src/flag-definitions.h

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5aeb748d374157b602e4d01dc1251cc72072cc92

commit 5aeb748d374157b602e4d01dc1251cc72072cc92
Author: domenic <domenic@chromium.org>
Date: Mon Aug 24 18:15:56 2015

Ship --harmony_array_includes

Intent to ship: https://groups.google.com/d/msg/v8-users/-a8_8cb6FRI/trjyB5bACQAJ

BUG= v8:3575 
R=adamk@chromium.org, rossberg@chromium.org
LOG=Y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1295543003

Cr-Commit-Position: refs/heads/master@{#30339}

[modify] http://crrev.com/5aeb748d374157b602e4d01dc1251cc72072cc92/src/flag-definitions.h

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f5609a6c546c22f1e0eccbd32bf6d1e0e5a7c100

commit f5609a6c546c22f1e0eccbd32bf6d1e0e5a7c100
Author: Caitlin Potter <caitp@igalia.com>
Date: Mon Feb 20 17:42:25 2017

[builtins] refactor ArrayIncludes using TF_BUILTIN

Use TF_BUILTIN() to implement ArrayIncludes(). It's easier on the eyes and
easier to read.

BUG= v8:3575 
R=cbruni@chromium.org, ishell@chromium.org

Change-Id: I9cbe395829f0fcc7d01ba28ed7b5a2007c52cae3
Reviewed-on: https://chromium-review.googlesource.com/444830
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43333}
[modify] https://crrev.com/f5609a6c546c22f1e0eccbd32bf6d1e0e5a7c100/src/builtins/builtins-array.cc
[modify] https://crrev.com/f5609a6c546c22f1e0eccbd32bf6d1e0e5a7c100/src/code-stub-assembler.cc
[modify] https://crrev.com/f5609a6c546c22f1e0eccbd32bf6d1e0e5a7c100/src/code-stub-assembler.h

Labels: Priority-2

Sign in to add a comment