New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 3516 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Nov 2014
Cc:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: Bug

Blocked on:
issue 3571

Blocking:
issue 3330



Sign in to add a comment

Add support for method shorthand

Project Member Reported by arv@chromium.org, Aug 15 2014

Issue description

ES6 adds support for method shorthand. This is available both in object literals and classes. This bug is only about object literals.

  MethodDefinition : PropertyName ( StrictFormalParameters ) { FunctionBody }
 

Comment 1 by arv@chromium.org, Aug 18 2014

Blocking: v8:3330
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e

commit 45d8e74cd6c97b96e82ea4086f205974660cd36e
Author: arv@chromium.org <arv@chromium.org>
Date: Wed Sep 10 16:39:42 2014

ES6: Add support for method shorthand in object literals

This is governed by the harmony-object-literals flag.

BUG= v8:3516 
LOG=Y
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/477263002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23846 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/arm/full-codegen-arm.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/arm/lithium-codegen-arm.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/arm64/full-codegen-arm64.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/arm64/lithium-codegen-arm64.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/ast.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/code-stubs-hydrogen.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/code-stubs.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/compiler.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/contexts.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/factory.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/factory.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/flag-definitions.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/full-codegen.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/globals.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/hydrogen-instructions.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/ia32/full-codegen-ia32.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/ia32/lithium-codegen-ia32.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/mips/full-codegen-mips.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/mips/lithium-codegen-mips.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/mips64/full-codegen-mips64.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/mips64/lithium-codegen-mips64.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/objects-inl.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/objects.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/parser.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/parser.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/preparser.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/preparser.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/runtime.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/runtime.h
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/v8natives.js
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/x64/full-codegen-x64.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/x64/lithium-codegen-x64.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/x87/full-codegen-x87.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/src/x87/lithium-codegen-x87.cc
[modify] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/test/cctest/test-parsing.cc
[add] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/test/mjsunit/harmony/object-literals-method.js
[add] https://chromium.googlesource.com/external/v8.git/+/45d8e74cd6c97b96e82ea4086f205974660cd36e/test/mjsunit/runtime-gen/functionisconcisemethod.js

Comment 3 by arv@chromium.org, Sep 16 2014

Blockedon: v8:3571

Comment 5 by arv@chromium.org, Nov 11 2014

Status: Fixed
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/47dd45c0ab585f7ea47b78f9e3a73c80e236d375

commit 47dd45c0ab585f7ea47b78f9e3a73c80e236d375
Author: arv <arv@chromium.org>
Date: Fri Jun 26 19:49:43 2015

[es6] Remove harmony-object-literal flag

And move tests to es6 directory

BUG= v8:3516 
LOG=N
R=adamk@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/1218473003

Cr-Commit-Position: refs/heads/master@{#29334}

[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/src/bootstrapper.cc
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/src/flag-definitions.h
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/src/parser.cc
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/src/preparser.h
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/cctest/compiler/test-run-jsops.cc
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/cctest/test-api.cc
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/cctest/test-parsing.cc
[rename] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/mjsunit/es6/method-name-eval-arguments.js
[rename] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/mjsunit/es6/object-literals-method.js
[rename] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/mjsunit/es6/object-literals-property-shorthand.js
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/mjsunit/harmony/computed-property-names-object-literals-methods.js
[modify] http://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375/test/mjsunit/harmony/computed-property-names-super.js
[delete] http://crrev.com/3a1ef020cf8a5da2ec759a3bc630f3150d2490e4/test/mjsunit/regress/regress-parse-object-literal.js

Labels: Priority-2

Sign in to add a comment