New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 3330 link

Starred by 75 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2016
Cc:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: FeatureRequest


Sign in to add a comment

Implement ES6 classes

Reported by dslomov@chromium.org, May 14 2014

Issue description

Implement classes syntax as defined by ECMAScript 6 spec

 
Showing comments 33 - 132 of 132 Older
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c

commit d4cbcfce6e859296c8c7bbac3954b342c173408c
Author: dslomov@chromium.org <dslomov@chromium.org>
Date: Fri Oct 17 09:16:03 2014

Implement the new semantics for 'super(...)'

Per the latest ES6 draft, super(...) translates into a call
to function's prototype.

R=arv@chromium.org, ishell@chromium.org, verwaest@chromium.org
BUG= v8:3330 
LOG=N

Review URL: https://codereview.chromium.org/661433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24683 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/arm/full-codegen-arm.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/arm64/full-codegen-arm64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/ast.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/ast.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/compiler/ast-graph-builder.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/ia32/full-codegen-ia32.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/x64/full-codegen-x64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/test/mjsunit/harmony/super.js

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c

commit d4cbcfce6e859296c8c7bbac3954b342c173408c
Author: dslomov@chromium.org <dslomov@chromium.org>
Date: Fri Oct 17 09:16:03 2014

Implement the new semantics for 'super(...)'

Per the latest ES6 draft, super(...) translates into a call
to function's prototype.

R=arv@chromium.org, ishell@chromium.org, verwaest@chromium.org
BUG= v8:3330 
LOG=N

Review URL: https://codereview.chromium.org/661433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24683 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/arm/full-codegen-arm.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/arm64/full-codegen-arm64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/ast.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/ast.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/compiler/ast-graph-builder.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/ia32/full-codegen-ia32.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/src/x64/full-codegen-x64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/d4cbcfce6e859296c8c7bbac3954b342c173408c/test/mjsunit/harmony/super.js

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/15e018db2d936fa512c46359dcd5919ccdbcf91e

commit 15e018db2d936fa512c46359dcd5919ccdbcf91e
Author: balazs.kilvady@imgtec.com <balazs.kilvady@imgtec.com>
Date: Fri Oct 17 11:30:13 2014

MIPS: Implement the new semantics for 'super(...)'.

Port r24683 (b1533f6)

Original commit message:
Per the latest ES6 draft, super(...) translates into a call
to function's prototype.

BUG= v8:3330 
LOG=N
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/661043003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24690 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/15e018db2d936fa512c46359dcd5919ccdbcf91e/src/mips/full-codegen-mips.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/15e018db2d936fa512c46359dcd5919ccdbcf91e/src/mips64/full-codegen-mips64.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Oct 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/15e018db2d936fa512c46359dcd5919ccdbcf91e

commit 15e018db2d936fa512c46359dcd5919ccdbcf91e
Author: balazs.kilvady@imgtec.com <balazs.kilvady@imgtec.com>
Date: Fri Oct 17 11:30:13 2014

MIPS: Implement the new semantics for 'super(...)'.

Port r24683 (b1533f6)

Original commit message:
Per the latest ES6 draft, super(...) translates into a call
to function's prototype.

BUG= v8:3330 
LOG=N
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/661043003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24690 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/15e018db2d936fa512c46359dcd5919ccdbcf91e/src/mips/full-codegen-mips.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/15e018db2d936fa512c46359dcd5919ccdbcf91e/src/mips64/full-codegen-mips64.cc

Blockedon: v8:3642
RIP Javascript, 10/23/2014.
@agamemnus: I believe es-discuss@mozilla.org would be better than this bug to discuss that complaint. 

Comment 46 by arv@chromium.org, Oct 28 2014

Blockedon: v8:3655
Project Member

Comment 47 by bugdroid1@chromium.org, Oct 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29

commit 499e5e961a8dd36cce9d0cd6397c378857f5ea29
Author: arv@chromium.org <arv@chromium.org>
Date: Tue Oct 28 12:43:05 2014

Classes: Add basic support for properties

This adds the properties to the prototype and the constructor.

BUG= v8:3330 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/680993003

Cr-Commit-Position: refs/branch-heads/bleeding_edge@{#24934}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/src/arm/full-codegen-arm.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/src/arm64/full-codegen-arm64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/src/ast.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/src/full-codegen.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/src/full-codegen.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/src/ia32/full-codegen-ia32.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/src/x64/full-codegen-x64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29/test/mjsunit/harmony/classes.js

Project Member

Comment 48 by bugdroid1@chromium.org, Oct 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e

commit 1881cee6911df4dc4908118da6a76d08e78f682e
Author: arv@chromium.org <arv@chromium.org>
Date: Tue Oct 28 12:43:05 2014

Classes: Add basic support for properties

This adds the properties to the prototype and the constructor.

BUG= v8:3330 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/680993003

Cr-Commit-Position: refs/heads/master@{#24934}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/src/arm/full-codegen-arm.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/src/arm64/full-codegen-arm64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/src/ast.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/src/full-codegen.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/src/full-codegen.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/src/ia32/full-codegen-ia32.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/src/x64/full-codegen-x64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e/test/mjsunit/harmony/classes.js

Project Member

Comment 49 by bugdroid1@chromium.org, Oct 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/641c7fb0a36517cc76dc18c5b73c223b3eb3e354

commit 641c7fb0a36517cc76dc18c5b73c223b3eb3e354
Author: arv@chromium.org <arv@chromium.org>
Date: Tue Oct 28 13:39:41 2014

Classes: Add test for method prototype

Methods should not have a prototype property

BUG= v8:3330 
LOG=y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/678103004

Cr-Commit-Position: refs/branch-heads/bleeding_edge@{#24939}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24939 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/641c7fb0a36517cc76dc18c5b73c223b3eb3e354/test/mjsunit/harmony/classes.js

Project Member

Comment 50 by bugdroid1@chromium.org, Oct 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5c2dffc380ca32d9e64e2884977e22fb2a207399

commit 5c2dffc380ca32d9e64e2884977e22fb2a207399
Author: arv@chromium.org <arv@chromium.org>
Date: Tue Oct 28 13:39:41 2014

Classes: Add test for method prototype

Methods should not have a prototype property

BUG= v8:3330 
LOG=y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/678103004

Cr-Commit-Position: refs/heads/master@{#24939}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24939 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/5c2dffc380ca32d9e64e2884977e22fb2a207399/test/mjsunit/harmony/classes.js

Project Member

Comment 51 by bugdroid1@chromium.org, Oct 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f890567ff6b2bff5fc9a10c8f5bd99db996603c1

commit f890567ff6b2bff5fc9a10c8f5bd99db996603c1
Author: balazs.kilvady@imgtec.com <balazs.kilvady@imgtec.com>
Date: Tue Oct 28 15:44:52 2014

MIPS: Classes: Add basic support for properties

Port r24934 (279833c)

Original commit message:
This adds the properties to the prototype and the constructor.

BUG= v8:3330 
LOG=Y
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/687633002

Cr-Commit-Position: refs/branch-heads/bleeding_edge@{#24951}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24951 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/f890567ff6b2bff5fc9a10c8f5bd99db996603c1/src/mips/full-codegen-mips.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/f890567ff6b2bff5fc9a10c8f5bd99db996603c1/src/mips64/full-codegen-mips64.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/369910849a2500ae70d59d7e772226e86164366d

commit 369910849a2500ae70d59d7e772226e86164366d
Author: balazs.kilvady@imgtec.com <balazs.kilvady@imgtec.com>
Date: Tue Oct 28 15:44:52 2014

MIPS: Classes: Add basic support for properties

Port r24934 (279833c)

Original commit message:
This adds the properties to the prototype and the constructor.

BUG= v8:3330 
LOG=Y
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/687633002

Cr-Commit-Position: refs/heads/master@{#24951}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24951 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/369910849a2500ae70d59d7e772226e86164366d/src/mips/full-codegen-mips.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/369910849a2500ae70d59d7e772226e86164366d/src/mips64/full-codegen-mips64.cc

Comment 53 by arv@chromium.org, Oct 29 2014

Blockedon: v8:3659
Project Member

Comment 54 by bugdroid1@chromium.org, Oct 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882

commit 6a625fa458c14455c2ccba320744ba3fedcc6882
Author: arv@chromium.org <arv@chromium.org>
Date: Wed Oct 29 11:45:57 2014

Classes: Add super support in methods and accessors

This is done by installing the [[HomeObject]] on the method and the
accessor functions.

BUG= v8:3330 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/683893002

Cr-Commit-Position: refs/branch-heads/bleeding_edge@{#24976}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24976 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882/src/arm/full-codegen-arm.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882/src/arm64/full-codegen-arm64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882/src/ia32/full-codegen-ia32.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882/src/runtime/runtime-classes.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882/src/runtime/runtime.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882/src/x64/full-codegen-x64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/6a625fa458c14455c2ccba320744ba3fedcc6882/test/mjsunit/harmony/classes.js

Project Member

Comment 55 by bugdroid1@chromium.org, Oct 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254

commit 5b3f9ec76d1dd5ef16177c0389fb50390c43e254
Author: arv@chromium.org <arv@chromium.org>
Date: Wed Oct 29 11:45:57 2014

Classes: Add super support in methods and accessors

This is done by installing the [[HomeObject]] on the method and the
accessor functions.

BUG= v8:3330 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/683893002

Cr-Commit-Position: refs/heads/master@{#24976}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24976 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254/src/arm/full-codegen-arm.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254/src/arm64/full-codegen-arm64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254/src/ia32/full-codegen-ia32.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254/src/runtime/runtime-classes.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254/src/runtime/runtime.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254/src/x64/full-codegen-x64.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/5b3f9ec76d1dd5ef16177c0389fb50390c43e254/test/mjsunit/harmony/classes.js

Project Member

Comment 56 by bugdroid1@chromium.org, Oct 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/84900be23c86797037e2e38073bae45af631c5cd

commit 84900be23c86797037e2e38073bae45af631c5cd
Author: balazs.kilvady@imgtec.com <balazs.kilvady@imgtec.com>
Date: Wed Oct 29 13:16:23 2014

MIPS: Classes: Add super support in methods and accessors.

Port r24976 (5cb743f)

Original commit message:
This is done by installing the [[HomeObject]] on the method and the
accessor functions.

BUG= v8:3330 
LOG=Y
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/691503002

Cr-Commit-Position: refs/branch-heads/bleeding_edge@{#24979}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24979 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/84900be23c86797037e2e38073bae45af631c5cd/src/mips/full-codegen-mips.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/84900be23c86797037e2e38073bae45af631c5cd/src/mips64/full-codegen-mips64.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Oct 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/db3eab1d268e08eba0bd63ed70fe564271bcb13d

commit db3eab1d268e08eba0bd63ed70fe564271bcb13d
Author: balazs.kilvady@imgtec.com <balazs.kilvady@imgtec.com>
Date: Wed Oct 29 13:16:23 2014

MIPS: Classes: Add super support in methods and accessors.

Port r24976 (5cb743f)

Original commit message:
This is done by installing the [[HomeObject]] on the method and the
accessor functions.

BUG= v8:3330 
LOG=Y
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/691503002

Cr-Commit-Position: refs/heads/master@{#24979}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24979 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/db3eab1d268e08eba0bd63ed70fe564271bcb13d/src/mips/full-codegen-mips.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/db3eab1d268e08eba0bd63ed70fe564271bcb13d/src/mips64/full-codegen-mips64.cc

Comment 58 by arv@chromium.org, Nov 3 2014

Blockedon: v8:3661

Comment 59 by arv@chromium.org, Nov 3 2014

Blockedon: v8:3672

Comment 60 by arv@chromium.org, Nov 3 2014

Blockedon: v8:3673

Comment 61 by arv@chromium.org, Nov 4 2014

Blockedon: v8:3674

Comment 62 by arv@chromium.org, Nov 6 2014

Owner: arv@chromium.org
Project Member

Comment 63 by bugdroid1@chromium.org, Nov 14 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5

commit f3d5b13e04c9cedd1f020ce0beec64275fcc40d5
Author: arv <arv@chromium.org>
Date: Fri Nov 14 15:05:05 2014

Classes: Implement correct name binding

Named class declarations and class expression have a const binding for
the name that is in TDZ for the extends expression.

BUG= v8:3330 
LOG=Y
R=dslomov@chromium.org, adamk

Review URL: https://codereview.chromium.org/722793005

Cr-Commit-Position: refs/heads/master@{#25360}

[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/ast-numbering.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/ast.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/full-codegen.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/full-codegen.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/parser.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/parser.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/preparser.cc
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/src/preparser.h
[modify] https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5/test/mjsunit/harmony/classes.js

Project Member

Comment 64 by bugdroid1@chromium.org, Nov 18 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d5d15253b8b010b61f78b6d77ac3357554fd7a19

commit d5d15253b8b010b61f78b6d77ac3357554fd7a19
Author: arv <arv@chromium.org>
Date: Tue Nov 18 19:00:08 2014

Classes: Expand test to cover strict runtime behavior

This tests that the extends expression is treated as strict at
runtime and not just at parse time.

BUG= v8:3330 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/729323003

Cr-Commit-Position: refs/heads/master@{#25407}

[modify] https://chromium.googlesource.com/v8/v8.git/+/d5d15253b8b010b61f78b6d77ac3357554fd7a19/test/mjsunit/harmony/classes.js

Project Member

Comment 65 by bugdroid1@chromium.org, Nov 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6

commit 65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6
Author: dslomov <dslomov@chromium.org>
Date: Fri Nov 28 04:08:48 2014

harmony-classes: Implement 'super(...)' call syntactic restriction.

R=rossberg@chromium.org,arv@chromium.org
BUG= v8:3330 
LOG=N

Review URL: https://codereview.chromium.org/766663003

Cr-Commit-Position: refs/heads/master@{#25555}

[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/BUILD.gn
[add] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/ast-this-access-visitor.cc
[add] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/ast-this-access-visitor.h
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/ast.cc
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/ast.h
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/compiler.cc
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/messages.js
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/objects-inl.h
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/objects.h
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/parser.cc
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/preparser.h
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/scopes.cc
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/src/scopes.h
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/test/cctest/test-parsing.cc
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/test/mjsunit/harmony/classes.js
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/test/mjsunit/harmony/super.js
[modify] http://crrev.com/65aa17b9c30d4400c9fa7468b594dfdc0e46a1e6/tools/gyp/v8.gyp

Blockedon: chromium:438203
Project Member

Comment 68 by bugdroid1@chromium.org, Dec 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/dba8e83b41d6cd229ac3d47484767db00c5b9791

commit dba8e83b41d6cd229ac3d47484767db00c5b9791
Author: dslomov <dslomov@chromium.org>
Date: Tue Dec 02 14:54:31 2014

Stage ES6 classes and object literal extensions.

R=arv@chromium.org,rossberg@chromium.org
BUG= v8:3330 
LOG=Y

Review URL: https://codereview.chromium.org/774653002

Cr-Commit-Position: refs/heads/master@{#25617}

[modify] http://crrev.com/dba8e83b41d6cd229ac3d47484767db00c5b9791/src/flag-definitions.h

Project Member

Comment 73 by bugdroid1@chromium.org, Dec 16 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/52e487d7a2ff4d61d7845dfd56687d9978cbeb46

commit 52e487d7a2ff4d61d7845dfd56687d9978cbeb46
Author: dslomov <dslomov@chromium.org>
Date: Tue Dec 16 15:09:46 2014

Make sure FunctionToMethod is lazily compiled.

R=arv@chromium.org
BUG= v8:3330 
LOG=N

Review URL: https://codereview.chromium.org/808723002

Cr-Commit-Position: refs/heads/master@{#25847}

[modify] http://crrev.com/52e487d7a2ff4d61d7845dfd56687d9978cbeb46/src/harmony-classes.js

Comment 75 by arv@chromium.org, Jan 16 2015

Blockedon: v8:3816
Blockedon: v8:3834
Project Member

Comment 77 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54

commit 176b68d11a2b485d9568d2e7fd03e6ed7b67dd54
Author: arv <arv@chromium.org>
Date: Wed Feb 04 17:23:07 2015

Class methods should be non enumerable

Class methods and accessors (both prototype and static) should be
non enumerable.

BUG= v8:3330 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/896643003

Cr-Commit-Position: refs/heads/master@{#26437}

[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/arm/full-codegen-arm.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/arm64/full-codegen-arm64.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/compiler/ast-graph-builder.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/ia32/full-codegen-ia32.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/mips/full-codegen-mips.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/mips64/full-codegen-mips64.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/objects-inl.h
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/objects.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/objects.h
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/runtime/runtime-classes.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/runtime/runtime-object.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/runtime/runtime.h
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/x64/full-codegen-x64.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/src/x87/full-codegen-x87.cc
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/test/mjsunit/harmony/classes.js
[modify] http://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54/test/mjsunit/harmony/computed-property-names-classes.js

Project Member

Comment 78 by bugdroid1@chromium.org, Feb 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9acfd4fe0825afb9284327327ed7edc185994e02

commit 9acfd4fe0825afb9284327327ed7edc185994e02
Author: arv <arv@chromium.org>
Date: Tue Feb 10 19:51:18 2015

super is only allowed in methods, accessors and constructor

super() is only allowed in a class constructor.
super.p is allowed in methods, accessors and constructors.

The parser now checks the FunctionState to see what kind of function
we are currently inside.

BUG= v8:3330 
LOG=N
R=dslomov@chromium.org, marja@chromium.org

Review URL: https://codereview.chromium.org/915563003

Cr-Commit-Position: refs/heads/master@{#26557}

[modify] http://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02/src/preparser.h
[modify] http://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02/test/cctest/test-parsing.cc
[modify] http://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02/test/mjsunit/harmony/classes.js
[modify] http://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02/test/mjsunit/harmony/object-literals-super.js
[modify] http://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02/test/mjsunit/harmony/super.js
[modify] http://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02/test/mjsunit/mjsunit.status

Comment 80 by arv@chromium.org, Feb 12 2015

Blockedon: v8:3888
Project Member

Comment 82 by bugdroid1@chromium.org, Feb 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d0c2c2b32c551d927c65d83d479226892291ce93

commit d0c2c2b32c551d927c65d83d479226892291ce93
Author: arv <arv@chromium.org>
Date: Fri Feb 13 22:26:17 2015

ES6 Classes: Remove tracking of super construct calls.

With the new ES6 semantics super construct calls are only valid in
a constructor in a derived class. This is something that is
statically known and we report early SyntaxError in case it occurs.
We therefore do not need to track this any more.

BUG= v8:3330 
LOG=N
R=dslomov@chromium.org, adamk

Review URL: https://codereview.chromium.org/924123002

Cr-Commit-Position: refs/heads/master@{#26644}

[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/ast.cc
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/ast.h
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/objects-inl.h
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/objects.cc
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/objects.h
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/parser.cc
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/preparser.h
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/scopes.cc
[modify] http://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93/src/scopes.h

Project Member

Comment 83 by bugdroid1@chromium.org, Feb 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0cffc08b667a067089c7eecffea3e8021ab2ff57

commit 0cffc08b667a067089c7eecffea3e8021ab2ff57
Author: arv <arv@chromium.org>
Date: Thu Feb 19 16:15:25 2015

Super store

When the property is not found on the [[HomeObject]] prototype chain
then we should do a [[DefineOwnProperty]] on the instance.

BUG= v8:3330 
LOG=N

Review URL: https://codereview.chromium.org/934463003

Cr-Commit-Position: refs/heads/master@{#26754}

[modify] http://crrev.com/0cffc08b667a067089c7eecffea3e8021ab2ff57/src/objects.cc
[modify] http://crrev.com/0cffc08b667a067089c7eecffea3e8021ab2ff57/src/objects.h
[modify] http://crrev.com/0cffc08b667a067089c7eecffea3e8021ab2ff57/src/runtime/runtime-classes.cc
[modify] http://crrev.com/0cffc08b667a067089c7eecffea3e8021ab2ff57/test/mjsunit/harmony/super.js

Comment 84 by arv@chromium.org, Apr 21 2015

Blockedon: v8:4009

Comment 85 by arv@chromium.org, Apr 27 2015

Blockedon: v8:4061
Project Member

Comment 86 by bugdroid1@chromium.org, Apr 28 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/525f7c85b9c76e1027de01fe768d910e9f091bfb

commit 525f7c85b9c76e1027de01fe768d910e9f091bfb
Author: arv <arv@chromium.org>
Date: Tue Apr 28 16:42:35 2015

Import webkit class tests

BUG= v8:3330 
LOG=N

Review URL: https://codereview.chromium.org/1109783003

Cr-Commit-Position: refs/heads/master@{#28115}

[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-constructor-return-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-constructor-return.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-call-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-call.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-declaration-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-declaration.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-default-constructor-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-default-constructor.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-expression-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-expression.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-extends-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-extends.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-name-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-name.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-prototype-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-prototype.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-scoping-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-scoping.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-semicolon-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-semicolon.js
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-super-expected.txt
[add] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/class-syntax-super.js
[modify] http://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb/test/webkit/resources/standalone-pre.js

Comment 87 by habl...@google.com, Apr 29 2015

Status: Assigned

Comment 88 by arv@chromium.org, May 14 2015

Blockedon: v8:4105
Project Member

Comment 89 by bugdroid1@chromium.org, Jun 5 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/06c706d84c04fc2e31e993518df9dcefb7543a2d

commit 06c706d84c04fc2e31e993518df9dcefb7543a2d
Author: arv <arv@chromium.org>
Date: Fri Jun 05 14:32:38 2015

[es6] Add TF support for super.property

Currently does super.prop (load) and super.method() (call). Like full
codegen it uses runtime calls to load the property value.

BUG= v8:3330 
LOG=N
R=mstarzinger@chromium.org, dslomov@chromium.org

Review URL: https://codereview.chromium.org/1149133005

Cr-Commit-Position: refs/heads/master@{#28815}

[modify] http://crrev.com/06c706d84c04fc2e31e993518df9dcefb7543a2d/src/compiler/ast-graph-builder.cc
[modify] http://crrev.com/06c706d84c04fc2e31e993518df9dcefb7543a2d/src/compiler/ast-graph-builder.h

Comment 90 by arv@chromium.org, Jun 19 2015

Blockedon: v8:4199
Project Member

Comment 91 by bugdroid1@chromium.org, Jun 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/353b40e98092fb2095c865f4415ceeeabeed81bf

commit 353b40e98092fb2095c865f4415ceeeabeed81bf
Author: arv <arv@chromium.org>
Date: Fri Jun 26 21:16:42 2015

[es6] Remove harmony-classes flag

Move class tests to es6 directory

BUG= v8:3330 
LOG=N
R=adamk

Review URL: https://codereview.chromium.org/1213813003

Cr-Commit-Position: refs/heads/master@{#29336}

[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/src/bootstrapper.cc
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/src/flag-definitions.h
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/src/parser.cc
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/src/preparser.h
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/src/scanner.cc
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/src/scanner.h
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/cctest/compiler/test-run-jsops.cc
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/cctest/test-api.cc
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/cctest/test-parsing.cc
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/js-perf-test/JSTests.json
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/message/class-constructor-accessor.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/message/class-constructor-generator.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/message/rest-param-class-setter-strict.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/message/super-constructor-extra-statement.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/message/super-constructor.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/message/super-in-function.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/block-non-strict-errors.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/class-property-name-eval-arguments.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/classes-experimental.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/classes-lazy-parsing.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/classes-maps.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/classes-subclass-arrays.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/classes.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/debug-step-into-class-extends.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/debug-step-into-constructor.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/regress/regress-3750.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/regress/regress-455141.js
[rename] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/es6/toMethod.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/array-concat.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/arrow-functions-lexical-arguments.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/class-computed-property-names-super.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/computed-property-names-classes.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/computed-property-names-super.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/object-literals-super.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/regress/regress-crbug-451770.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/rest-params.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/harmony/super.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/strong/classes.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/strong/declaration-after-use.js
[modify] http://crrev.com/353b40e98092fb2095c865f4415ceeeabeed81bf/test/mjsunit/strong/super.js

Comment 92 by arv@chromium.org, Jul 9 2015

Owner: adamk@chromium.org
Blocking: chromium:529177
Project Member

Comment 95 by bugdroid1@chromium.org, Sep 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ff2c9eace4cd987de3efcfdddc92143ede5d2c76

commit ff2c9eace4cd987de3efcfdddc92143ede5d2c76
Author: bmeurer <bmeurer@chromium.org>
Date: Fri Sep 25 04:04:28 2015

[es6] Remove left-overs from Function.prototype.toMethod.

The actual Function.prototype.toMethod was removed some time already,
but there were some stuff (esp. %ToMethod) left in the tree, including
tests for %ToMethod.  This code (and esp. the tests) cause trouble in
the process of moving bound functions away from JSFunction; so since
the code is unused anyway, we can as well remove it.

The original removal of Function.prototype.toMethod was in February
2015 in 68e489758607bb7373409b49a0a7883407a322b3.

R=jarin@chromium.org
BUG= v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1366063002

Cr-Commit-Position: refs/heads/master@{#30925}

[modify] http://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76/src/objects.cc
[modify] http://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76/src/objects.h
[modify] http://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76/src/runtime/runtime-classes.cc
[modify] http://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76/src/runtime/runtime.h
[modify] http://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76/test/cctest/test-api.cc
[delete] http://crrev.com/bd35b54d82b80a3d14c9aa38ac9c19eca5450225/test/mjsunit/es6/toMethod.js
[modify] http://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76/test/mjsunit/harmony/super.js

Comment 96 by adamk@chromium.org, Sep 29 2015

Blocking: -chromium:529177
Project Member

Comment 97 by bugdroid1@chromium.org, Oct 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f464f12a8b97fc0635651b88b0c37bcd74fd1af8

commit f464f12a8b97fc0635651b88b0c37bcd74fd1af8
Author: verwaest <verwaest@chromium.org>
Date: Thu Oct 22 14:38:34 2015

Ensure we never inline class constructors in Crankshaft, as it currently is entirely unsupported.

BUG= v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1415723005

Cr-Commit-Position: refs/heads/master@{#31480}

[modify] http://crrev.com/f464f12a8b97fc0635651b88b0c37bcd74fd1af8/src/crankshaft/hydrogen.cc
[add] http://crrev.com/f464f12a8b97fc0635651b88b0c37bcd74fd1af8/test/mjsunit/regress/regress-inline-class-constructor.js

Project Member

Comment 98 by bugdroid1@chromium.org, Oct 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/307158784e538a07afab395cb7a1fc9ce924f29d

commit 307158784e538a07afab395cb7a1fc9ce924f29d
Author: verwaest <verwaest@chromium.org>
Date: Mon Oct 26 08:29:39 2015

Eagerly mark class prototypes as prototype.

BUG= v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1419583007

Cr-Commit-Position: refs/heads/master@{#31548}

[modify] http://crrev.com/307158784e538a07afab395cb7a1fc9ce924f29d/src/runtime/runtime-classes.cc

Project Member

Comment 99 by bugdroid1@chromium.org, Oct 30 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cd5f48302a502154a0106d12e3066bd563c6340c

commit cd5f48302a502154a0106d12e3066bd563c6340c
Author: ishell <ishell@chromium.org>
Date: Fri Oct 30 10:58:04 2015

[es6] Better support for built-ins subclassing.

Create proper initial map for original constructor (new.target) instead of doing prototype transition on the base constructor's initial map. This approach fixes in-object slack tracking for subclass instances.
This CL also fixes subclassing from String.

BUG= v8:3101 ,  v8:3330 
LOG=Y

Review URL: https://codereview.chromium.org/1427483002

Cr-Commit-Position: refs/heads/master@{#31680}

[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/arm/builtins-arm.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/arm64/builtins-arm64.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/heap/heap.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/ia32/builtins-ia32.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/mips/builtins-mips.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/mips64/builtins-mips64.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/objects-inl.h
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/objects-printer.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/objects.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/objects.h
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/runtime/runtime-object.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/src/x64/builtins-x64.cc
[add] http://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c/test/mjsunit/es6/classes-subclass-builtins.js

Project Member

Comment 100 by bugdroid1@chromium.org, Oct 30 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/08ca3f240c6c279e956af8fd1b525abd4edf8ff7

commit 08ca3f240c6c279e956af8fd1b525abd4edf8ff7
Author: bmeurer <bmeurer@chromium.org>
Date: Fri Oct 30 11:36:22 2015

Revert of [es6] Better support for built-ins subclassing. (patchset #8 id:200001 of https://codereview.chromium.org/1427483002/ )

Reason for revert:
Breaks test on win32 nosnap.http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/9680

Original issue's description:
> [es6] Better support for built-ins subclassing.
>
> Create proper initial map for original constructor (new.target) instead of doing prototype transition on the base constructor's initial map. This approach fixes in-object slack tracking for subclass instances.
> This CL also fixes subclassing from String.
>
> BUG= v8:3101 ,  v8:3330 
> LOG=Y
>
> Committed: https://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c
> Cr-Commit-Position: refs/heads/master@{#31680}

TBR=verwaest@chromium.org,ulan@chromium.org,ishell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= v8:3101 ,  v8:3330 

Review URL: https://codereview.chromium.org/1416943005

Cr-Commit-Position: refs/heads/master@{#31684}

[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/arm/builtins-arm.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/arm64/builtins-arm64.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/heap/heap.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/ia32/builtins-ia32.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/mips/builtins-mips.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/mips64/builtins-mips64.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/objects-inl.h
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/objects-printer.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/objects.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/objects.h
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/runtime/runtime-object.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7/src/x64/builtins-x64.cc
[delete] http://crrev.com/6173d504ee625c19a64fc0521fa918aa4e0947a0/test/mjsunit/es6/classes-subclass-builtins.js

Project Member

Comment 101 by bugdroid1@chromium.org, Nov 2 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4490ce85205d3504dc0bf444f5e8b3deb04cbb06

commit 4490ce85205d3504dc0bf444f5e8b3deb04cbb06
Author: ishell <ishell@chromium.org>
Date: Mon Nov 02 08:25:19 2015

Reland "[es6] Better support for built-ins subclassing."

Original issue's description:
> [es6] Better support for built-ins subclassing.
>
> Create proper initial map for original constructor (new.target) instead of doing prototype
> transition on the base constructor's initial map. This approach fixes in-object slack tracking
> for subclass instances.
> This CL also fixes subclassing from String.
>
> BUG= v8:3101 ,  v8:3330 
> LOG=Y
>
> Committed: https://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c
> Cr-Commit-Position: refs/heads/master@{#31680}

It also fixes typed array map smashing done during typed array initialization.

BUG= v8:3101 ,  v8:3330 ,  v8:4419 
LOG=Y

Review URL: https://codereview.chromium.org/1413033006

Cr-Commit-Position: refs/heads/master@{#31701}

[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/arm/builtins-arm.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/arm64/builtins-arm64.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/crankshaft/hydrogen.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/heap/heap.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/ia32/builtins-ia32.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/mips/builtins-mips.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/mips64/builtins-mips64.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/objects-inl.h
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/objects-printer.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/objects.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/objects.h
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/runtime/runtime-object.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/runtime/runtime-typedarray.cc
[modify] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/src/x64/builtins-x64.cc
[add] http://crrev.com/4490ce85205d3504dc0bf444f5e8b3deb04cbb06/test/mjsunit/es6/classes-subclass-builtins.js

Project Member

Comment 102 by bugdroid1@chromium.org, Nov 2 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/62acae2436733fcfcce684bfb9280f84cb508cbd

commit 62acae2436733fcfcce684bfb9280f84cb508cbd
Author: zhengxing.li <zhengxing.li@intel.com>
Date: Mon Nov 02 09:59:47 2015

X87: Reland "[es6] Better support for built-ins subclassing."

  port 4490ce85205d3504dc0bf444f5e8b3deb04cbb06 (r31701).

  original commit message:
    Original issue's description:
    > [es6] Better support for built-ins subclassing.
    >
    > Create proper initial map for original constructor (new.target) instead of doing prototype
    > transition on the base constructor's initial map. This approach fixes in-object slack tracking
    > for subclass instances.
    > This CL also fixes subclassing from String.
    >
    > BUG= v8:3101 ,  v8:3330 
    > LOG=Y
    >
    > Committed: https://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c
    > Cr-Commit-Position: refs/heads/master@{#31680}

    It also fixes typed array map smashing done during typed array initialization.

BUG=

Review URL: https://codereview.chromium.org/1432483003

Cr-Commit-Position: refs/heads/master@{#31704}

[modify] http://crrev.com/62acae2436733fcfcce684bfb9280f84cb508cbd/src/x87/builtins-x87.cc

Project Member

Comment 103 by bugdroid1@chromium.org, Nov 2 2015

Project Member

Comment 104 by bugdroid1@chromium.org, Nov 2 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2210cc84de92a133580b4ef98965612ffe3f8588

commit 2210cc84de92a133580b4ef98965612ffe3f8588
Author: ishell <ishell@chromium.org>
Date: Mon Nov 02 11:58:55 2015

Revert of [es6] Fix Function and GeneratorFunction built-ins subclassing. (patchset #4 id:80001 of https://codereview.chromium.org/1428823002/ )

Reason for revert:
Buildbot failures

Original issue's description:
> [es6] Fix Function and GeneratorFunction built-ins subclassing.
>
> BUG= v8:3101 ,  v8:3330 
> LOG=Y
>
> Committed: https://crrev.com/99e7f872d3d0a5fb799dcbafb05537cda491314a
> Cr-Commit-Position: refs/heads/master@{#31708}

TBR=verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= v8:3101 ,  v8:3330 

Review URL: https://codereview.chromium.org/1413723008

Cr-Commit-Position: refs/heads/master@{#31709}

[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/bootstrapper.cc
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/factory.cc
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/factory.h
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/js/generator.js
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/js/v8natives.js
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/objects-printer.cc
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/runtime/runtime-function.cc
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/runtime/runtime-object.cc
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/src/runtime/runtime.h
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/test/mjsunit/es6/classes-subclass-builtins.js
[modify] http://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588/test/mjsunit/regress/regress-function-constructor-receiver.js

Project Member

Comment 105 by bugdroid1@chromium.org, Nov 2 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5a8da4945c6342603c719059e5830b0e0ae02fc1

commit 5a8da4945c6342603c719059e5830b0e0ae02fc1
Author: mbrandy <mbrandy@us.ibm.com>
Date: Mon Nov 02 19:51:48 2015

PPC: [es6] Better support for built-ins subclassing.

Port 4490ce85205d3504dc0bf444f5e8b3deb04cbb06

Original commit message:
    Create proper initial map for original constructor (new.target) instead of doing prototype
    transition on the base constructor's initial map. This approach fixes in-object slack tracking
    for subclass instances.
    This CL also fixes subclassing from String.

    It also fixes typed array map smashing done during typed array initialization.

R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG= v8:3101 ,  v8:3330 ,  v8:4419 
LOG=N

Review URL: https://codereview.chromium.org/1425353002

Cr-Commit-Position: refs/heads/master@{#31720}

[modify] http://crrev.com/5a8da4945c6342603c719059e5830b0e0ae02fc1/src/ppc/builtins-ppc.cc

Project Member

Comment 106 by bugdroid1@chromium.org, Nov 3 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/678a5583d6e15ee81546f7e4a23a21dc5cfe8012

commit 678a5583d6e15ee81546f7e4a23a21dc5cfe8012
Author: ishell <ishell@chromium.org>
Date: Tue Nov 03 12:15:48 2015

[es6] Fix RegExp built-in subclassing.

1) The Map::CopyInitialMap() did not set descriptor's array if
the source initial map had one.
2) Subclasses are temporarily disallowed to have more in-object
properties than the parent class (for GC reasons).

BUG= v8:3101 ,  v8:3330 ,  v8:4531 
LOG=N

Review URL: https://codereview.chromium.org/1431593003

Cr-Commit-Position: refs/heads/master@{#31743}

[modify] http://crrev.com/678a5583d6e15ee81546f7e4a23a21dc5cfe8012/src/objects.cc
[modify] http://crrev.com/678a5583d6e15ee81546f7e4a23a21dc5cfe8012/test/mjsunit/es6/classes-subclass-builtins.js

Project Member

Comment 107 by bugdroid1@chromium.org, Nov 3 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/babe50f083baf0cf1afa3106f616729f3ae940d7

commit babe50f083baf0cf1afa3106f616729f3ae940d7
Author: ishell <ishell@chromium.org>
Date: Tue Nov 03 16:42:21 2015

Reland "[es6] Fix Function and GeneratorFunction built-ins subclassing."

Original issue's description:
> [es6] Fix Function and GeneratorFunction built-ins subclassing.
>
> BUG= v8:3101 ,  v8:3330 
> LOG=Y
>
> Committed: https://crrev.com/99e7f872d3d0a5fb799dcbafb05537cda491314a
> Cr-Commit-Position: refs/heads/master@{#31708}

The problem was in another CL, this is a clean reland with improved tests.

BUG= v8:3101 ,  v8:3330 
LOG=Y

Review URL: https://codereview.chromium.org/1415683007

Cr-Commit-Position: refs/heads/master@{#31756}

[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/bootstrapper.cc
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/factory.cc
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/factory.h
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/js/generator.js
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/js/v8natives.js
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/objects-printer.cc
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/runtime/runtime-function.cc
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/runtime/runtime-object.cc
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/src/runtime/runtime.h
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/test/mjsunit/es6/classes-subclass-builtins.js
[modify] http://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7/test/mjsunit/regress/regress-function-constructor-receiver.js

Project Member

Comment 108 by bugdroid1@chromium.org, Nov 3 2015

Project Member

Comment 110 by bugdroid1@chromium.org, Nov 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f37269445873218d7de48fed1674e87090e87a56

commit f37269445873218d7de48fed1674e87090e87a56
Author: mbrandy <mbrandy@us.ibm.com>
Date: Tue Nov 10 19:55:37 2015

PPC: Support fast-path allocation for subclass constructors with correctly initialized initial maps.

Port b9d25d86a8d57be6184e2610c53c9b8abfd96f11

R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG= v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1434793002

Cr-Commit-Position: refs/heads/master@{#31926}

[modify] http://crrev.com/f37269445873218d7de48fed1674e87090e87a56/src/ppc/builtins-ppc.cc

Project Member

Comment 111 by bugdroid1@chromium.org, Nov 20 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ceade6cf239e0773213d53d55c36b19231c820b5

commit ceade6cf239e0773213d53d55c36b19231c820b5
Author: bmeurer <bmeurer@chromium.org>
Date: Fri Nov 20 06:21:11 2015

[runtime] Introduce a proper %NewArray runtime entry.

This adds a new %NewArray runtime entry, which constructs a new JSArray
and does the subclassing correctly (to the same degree that %NewObject
does currently), and also deals properly with the AllocationSite
feedback mechanism. This runtime entry will be used by TurboFan and is
also used as a fallback in the subclassing case in the stub currently.

BUG= v8:3101 ,  v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1456423003

Cr-Commit-Position: refs/heads/master@{#32131}

[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/arm/code-stubs-arm.cc
[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/arm64/code-stubs-arm64.cc
[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/ia32/code-stubs-ia32.cc
[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/mips/code-stubs-mips.cc
[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/mips64/code-stubs-mips64.cc
[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/runtime/runtime-array.cc
[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/runtime/runtime.h
[modify] http://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5/src/x64/code-stubs-x64.cc

Project Member

Comment 112 by bugdroid1@chromium.org, Nov 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8ced019a5936b55f9c2e647ff529a42f55c03d22

commit 8ced019a5936b55f9c2e647ff529a42f55c03d22
Author: mbrandy <mbrandy@us.ibm.com>
Date: Mon Nov 23 14:59:27 2015

PPC: [runtime] Introduce a proper %NewArray runtime entry.

Port ceade6cf239e0773213d53d55c36b19231c820b5

Original commit message:
    This adds a new %NewArray runtime entry, which constructs a new JSArray
    and does the subclassing correctly (to the same degree that %NewObject
    does currently), and also deals properly with the AllocationSite
    feedback mechanism. This runtime entry will be used by TurboFan and is
    also used as a fallback in the subclassing case in the stub currently.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG= v8:3101 ,  v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1466943002

Cr-Commit-Position: refs/heads/master@{#32180}

[modify] http://crrev.com/8ced019a5936b55f9c2e647ff529a42f55c03d22/src/ppc/code-stubs-ppc.cc

Project Member

Comment 113 by bugdroid1@chromium.org, Nov 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5a3b4366cd69da96591005d2fec6f67a877f8f34

commit 5a3b4366cd69da96591005d2fec6f67a877f8f34
Author: ishell <ishell@chromium.org>
Date: Thu Nov 26 10:27:11 2015

Add test for Promises subclassing.

BUG= v8:3101 ,  v8:3330 
LOG=N

Review URL: https://codereview.chromium.org/1473323003

Cr-Commit-Position: refs/heads/master@{#32324}

[modify] http://crrev.com/5a3b4366cd69da96591005d2fec6f67a877f8f34/test/mjsunit/es6/classes-subclass-builtins.js

Project Member

Comment 115 by bugdroid1@chromium.org, Nov 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/87f7dc61faac63fd017b84eb214bae0a34f73514

commit 87f7dc61faac63fd017b84eb214bae0a34f73514
Author: machenbach <machenbach@chromium.org>
Date: Thu Nov 26 16:20:51 2015

Revert of [Proxies] Support constructable proxy as new.target (patchset #3 id:40001 of https://codereview.chromium.org/1481613003/ )

Reason for revert:
[Sheriff] Breaks:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3977

Original issue's description:
> [Proxies] Support constructable proxy as new.target
>
> BUG= v8:1543 ,  v8:3330 ,  v8:3931 
> LOG=n
>
> Committed: https://crrev.com/88ac8aa5236195137d4a7aa18bcc5650a3bdca5a
> Cr-Commit-Position: refs/heads/master@{#32346}

TBR=ishell@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= v8:1543 ,  v8:3330 ,  v8:3931 

Review URL: https://codereview.chromium.org/1480673004

Cr-Commit-Position: refs/heads/master@{#32350}

[modify] http://crrev.com/87f7dc61faac63fd017b84eb214bae0a34f73514/src/objects.cc
[modify] http://crrev.com/87f7dc61faac63fd017b84eb214bae0a34f73514/src/objects.h
[modify] http://crrev.com/87f7dc61faac63fd017b84eb214bae0a34f73514/src/runtime/runtime-object.cc
[delete] http://crrev.com/138d9bae5d7014e0d205634a49b5eac3697744c8/test/mjsunit/es6/classes-proxy.js

Project Member

Comment 117 by bugdroid1@chromium.org, Nov 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/970a7ad7583c0270b86e602331a24e7cdfdadc8e

commit 970a7ad7583c0270b86e602331a24e7cdfdadc8e
Author: verwaest <verwaest@chromium.org>
Date: Fri Nov 27 21:44:27 2015

Fix Reflect.construct wrt proxy, generator, and non-subclass new.target

This makes sure that proxy + Function/Array works
Makes sure that new.target can be a generator
Makes sure that if new.target is not a subclass, but does not have a prototype, that we'll get that same prototype back the next time we look at new.target.prototype.

BUG= v8:1543 ,  v8:3330 ,  v8:3931 
LOG=n

Review URL: https://codereview.chromium.org/1484473002

Cr-Commit-Position: refs/heads/master@{#32382}

[modify] http://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e/src/objects.cc
[modify] http://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e/src/objects.h
[modify] http://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e/src/runtime/runtime-array.cc
[modify] http://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e/src/runtime/runtime-function.cc
[modify] http://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e/src/runtime/runtime-object.cc
[modify] http://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e/test/mjsunit/es6/classes-proxy.js
[modify] http://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e/test/mjsunit/harmony/reflect-construct.js

Project Member

Comment 118 by bugdroid1@chromium.org, Dec 1 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/48b72f3ca925e64d1aecd0fa54f9a1802e11a7f6

commit 48b72f3ca925e64d1aecd0fa54f9a1802e11a7f6
Author: mbrandy <mbrandy@us.ibm.com>
Date: Tue Dec 01 03:05:28 2015

PPC: [Proxies] Support constructable proxy as new.target (reland)

Port 7ceaf727082c5c2473afcba9c3b8bc1a7c3b498a

R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG= v8:1543 ,  v8:3330 ,  v8:3931 
LOG=n

Review URL: https://codereview.chromium.org/1480423002

Cr-Commit-Position: refs/heads/master@{#32433}

[modify] http://crrev.com/48b72f3ca925e64d1aecd0fa54f9a1802e11a7f6/src/ppc/builtins-ppc.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d

commit dddcd0ac17be9e24df15fc6ae4993f2b75bc256d
Author: ishell <ishell@chromium.org>
Date: Thu Dec 10 17:27:44 2015

Fix Function subclassing.

Function subclasses did not have function properties installed (name, prototype, etc.).
Now when an instance of a Function subclass is created it gets initial map that corresponds
to the language mode of the function body. The language mode dependent maps are cached as
special transitions on initial map of the subclass constructor.

BUG= v8:4597 ,  v8:3101 ,  v8:3330 
LOG=Y

Review URL: https://codereview.chromium.org/1510753005

Cr-Commit-Position: refs/heads/master@{#32764}

[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/src/bootstrapper.cc
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/src/heap/heap.h
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/src/objects-printer.cc
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/src/objects.cc
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/src/objects.h
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/src/runtime/runtime-function.cc
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/src/transitions-inl.h
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/test/mjsunit/es6/classes-subclass-builtins.js
[modify] http://crrev.com/dddcd0ac17be9e24df15fc6ae4993f2b75bc256d/test/mjsunit/harmony/reflect-construct.js

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/812bcd4494b5f2152274001c045968a779ea7c21

commit 812bcd4494b5f2152274001c045968a779ea7c21
Author: bmeurer <bmeurer@chromium.org>
Date: Mon Dec 14 05:55:55 2015

[fullcodegen] Add support for %_GetSuperConstructor.

Since the parser now desugars super constructor calls to simple
primitives, we can also easily optimize those in fullcodegen w/
just a few simple lines of native code per architecture.  This
code in particular should be fast, so it seems worth the code
in fullcodegen.

BUG= v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1524673002

Cr-Commit-Position: refs/heads/master@{#32823}

[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/arm/full-codegen-arm.cc
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/arm64/full-codegen-arm64.cc
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/full-codegen.h
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/ia32/full-codegen-ia32.cc
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/mips/full-codegen-mips.cc
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/mips64/full-codegen-mips64.cc
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/ppc/full-codegen-ppc.cc
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/x64/full-codegen-x64.cc
[modify] http://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21/src/full-codegen/x87/full-codegen-x87.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fe88e5479286ecba10e181bc65325355345c8c55

commit fe88e5479286ecba10e181bc65325355345c8c55
Author: bmeurer <bmeurer@chromium.org>
Date: Wed Dec 16 11:07:56 2015

[es6] Consistently use %_GetSuperConstructor to implement super calls.

Following up on https://crrev.com/1517243002, we use the
%_GetSuperConstructor consistently for all super calls now
(inlining the intrinsic code in fullcodegen).

R=mstarzinger@chromium.org
BUG= v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1529113002

Cr-Commit-Position: refs/heads/master@{#32890}

[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/compiler/ast-graph-builder.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/compiler/linkage.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/arm/full-codegen-arm.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/arm64/full-codegen-arm64.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/full-codegen.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/full-codegen.h
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/ia32/full-codegen-ia32.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/mips/full-codegen-mips.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/mips64/full-codegen-mips64.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/ppc/full-codegen-ppc.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/x64/full-codegen-x64.cc
[modify] http://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55/src/full-codegen/x87/full-codegen-x87.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9fc48575a3e3f6f646e65496119917ff56bff40e

commit 9fc48575a3e3f6f646e65496119917ff56bff40e
Author: mbrandy <mbrandy@us.ibm.com>
Date: Wed Dec 16 20:11:11 2015

PPC: Fix "[fullcodegen] Add support for %_GetSuperConstructor."

Use appropriate load instruction for 32-bit mode.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG= v8:3330 
LOG=n

Review URL: https://codereview.chromium.org/1532673002

Cr-Commit-Position: refs/heads/master@{#32917}

[modify] http://crrev.com/9fc48575a3e3f6f646e65496119917ff56bff40e/src/full-codegen/ppc/full-codegen-ppc.cc

Status: Fixed (was: Assigned)
Version 49.0.2623.75 (64-bit) (on mac)
I typed into the chrome repl console:
class Polygon {
  constructor(height, width) {
    this.height = height;
    this.width = width;
  }
}
The console repeated what I typed:
class Polygon {
  constructor(height, width) {
    this.height = height;
    this.width = width;
  }
}

I then tried to type the name of the class in the console:
Polygon

I got the following errors:
VM153:2 Uncaught ReferenceError: Polygon is not defined(…)(anonymous function) @ VM153:2InjectedScript._evaluateOn @ VM101:878InjectedScript._evaluateAndWrap @ VM101:811InjectedScript.evaluate @ VM101:667

I then tried to instantiate a Polygon in the console:

var p = new Polygon(3,1);
VM258:2 Uncaught ReferenceError: Polygon is not defined(…)

So seems that the console isn´t supporting class syntax yet. 
class bug in Chrome repl console.png
145 KB View Download
#127 -
First, it could be a Developer Tools issue. Second, please, file a new issue for every bug you find. This issue on which you comment is a general implementation, not a place for additional bugs - this system is an issue tracker, so just create a new issue for this specific bug.
I suggest that you create it on the Chromium issue tracker (assuming you have not found a similar issue already) instead. You may comment here with the filed or found issue and I will triage it.
Blockedon: -3659
Project Member

Comment 131 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0

commit 73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0
Author: verwaest <verwaest@chromium.org>
Date: Wed May 11 14:21:32 2016

Support subclassing API functions.

When instantiating a subclassed API function, the instance cache is avoided. There is currently no direct API yet to instantiate a Template while passing in a new.target. It probably makes sense to extend ObjectTemplate::NewInstance to accept a new.target, in line with Reflect.construct.

BUG= v8:3330 ,  v8:5001 

Review-Url: https://codereview.chromium.org/1972613002
Cr-Commit-Position: refs/heads/master@{#36179}

[modify] https://crrev.com/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0/src/api-natives.cc
[modify] https://crrev.com/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0/src/api-natives.h
[modify] https://crrev.com/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0/src/builtins.cc
[modify] https://crrev.com/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0/src/objects.cc
[modify] https://crrev.com/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0/test/cctest/test-api.cc

Labels: Priority-2
Showing comments 33 - 132 of 132 Older

Sign in to add a comment