New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 2783 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Jul 2013
Cc:
HW: ----
NextAction: ----
OS: ----
Priority: 2
Type: Bug



Sign in to add a comment

Implement BinaryIntegerLiteral and OctalIntegerLiteral

Project Member Reported by arv@chromium.org, Jul 15 2013

Issue description

http://people.mozilla.org/~jorendorff/es6-draft.html#sec-7.8.3

BinaryIntegerLiteral ::
  0b BinaryDigit
  0B BinaryDigit
  BinaryIntegerLiteral BinaryDigit

BinaryDigit :: one of
  0 1

OctalIntegerLiteral ::
  0o OctalDigit
  0O OctalDigit
  OctalIntegerLiteral OctalDigit
 

Comment 2 by arv@chromium.org, Jul 16 2013

Cc: -arv@chromium.org rossberg@chromium.org
Owner: arv@chromium.org
Note that the spec draft grammar is wrong:

https://bugs.ecmascript.org/show_bug.cgi?id=1583

Comment 3 by math...@qiwi.be, Jul 23 2013

I like to think my tweet had something to do with this issue getting filed :) https://twitter.com/mathias/status/354246135205998594

Re: https://codereview.chromium.org/19300002 / https://code.google.com/p/v8/source/detail?r=15772, are you sure this is implemented as per the spec? I don’t see any code or tests for octal integer literals in strict mode:

“A conforming implementation, when processing strict mode code (see 10.1.1), must not extend the syntax of NumericLiteral to include OctalIntegerLiteral as described in B.1.1.”

Comment 4 by arv@chromium.org, Jul 23 2013

Status: Fixed
mathias: That relates to the implicit octal literals, ie 0765, which is a non standard extension that the web uses. The spec needs to be updated to distinguish between the explicit OctalIntegerLiteral and the old implicit OctalIntegerLiteral in the appendix "B.1.1 Numeric Literals"

Comment 5 by math...@qiwi.be, Jul 24 2013

Thanks for the explanation, and for filing https://bugs.ecmascript.org/show_bug.cgi?id=1596 :)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7118cdb257f55f75f4f3517680a86d1cfa1eae2a

commit 7118cdb257f55f75f4f3517680a86d1cfa1eae2a
Author: arv@chromium.org <arv@chromium.org>
Date: Thu Nov 06 18:44:44 2014

Enable ES6 numeric literals by default

BUG= v8:2783 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/703943002

Cr-Commit-Position: refs/branch-heads/bleeding_edge@{#25204}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/7118cdb257f55f75f4f3517680a86d1cfa1eae2a/src/flag-definitions.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/32f3277eea54b6cf54a7eb8cdef9bd21e17a4374

commit 32f3277eea54b6cf54a7eb8cdef9bd21e17a4374
Author: arv@chromium.org <arv@chromium.org>
Date: Thu Nov 06 18:44:44 2014

Enable ES6 numeric literals by default

BUG= v8:2783 
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/703943002

Cr-Commit-Position: refs/heads/master@{#25204}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/32f3277eea54b6cf54a7eb8cdef9bd21e17a4374/src/flag-definitions.h

Labels: Priority-2

Sign in to add a comment