New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: WorkingAsIntended
Owner:
Closed: Dec 2015
HW: ----
NextAction: ----
OS: ----
Priority: 3
Type: FeatureRequest



Sign in to add a comment

Shared d8 is missing readline support

Reported by floppyma...@gmail.com, Oct 19 2011

Issue description

The sections of d8.cc implementing readline support are disabled by a preprocessor macro (#ifndef V8_SHARED). The build system also excludes d8-shared.cc when building the shared_library component.

I don't see why the V8 linkage should have any effect on the line editor.
 
That should read: The build system also excludes d8-readline.cc when building the shared_library component.
Labels: Type-FeatureRequest Priority-Low
Owner: yangguo@chromium.org
Status: Accepted
This is a known issue and intended to be this way at the time of the last major rework of D8. The problem is that the glue code for readline support touches some code in the v8::internal namespace that is not exported in the shared library build. Some refactoring would solve the problem, but currently does not have a high priority. Any helping and contributing hand would be welcome, however :)
I can recommend rlwrap.
https://codereview.chromium.org/11776017/ is a partial fix for this.

Comment 5 by habl...@google.com, Apr 29 2015

Status: Assigned
Status: WorkingAsIntended
We ripped out readline five months ago: https://codereview.chromium.org/1250223002

Labels: Priority-3

Sign in to add a comment