New issue
Advanced search Search tips
Starred by 5 users
Status: New
Owner:
Cc:
Area: Bitmap, GPU
Priority: Icebox
Type: Defect



Sign in to add a comment
Masks and SkBitmapProcShader don't play nice
Project Member Reported by senorblanco@chromium.org, Apr 10 2012 Back to list
What steps will reproduce the problem?

1.  Apply the attached patch.
2.  Run SampleApp --slide GM:shadows

Both rows use an SkBlurDrawLooper on an 8-bit bitmap.

The top row uses SkCanvas::drawBitmap(), and looks correct.  The bottom row uses an SkBitmapProcShader and SkCanvas::drawRect(), and looks incorrect (shadow is applied only on edge of bitmap).

Note:  use a Release build; this example also triggers an assert in Debug builds, possibly due to an error in A8 blitting:

../src/core/SkBitmapProcState_sample.h:74: failed assertion "s.fAlphaScale == 256"
 
bitmap-shader-shadow-bug1.patch
2.7 KB View Download
shadows_8888.png
7.8 KB View Download
Project Member Comment 1 by reed@google.com, Apr 10 2012
assert fixed in rev. 3646
Project Member Comment 2 by hcm@google.com, Aug 28 2014
Labels: Area-Bitmap
Project Member Comment 3 by caryclark@google.com, Sep 4 2015
Checked in CL that adds this to GM. The correct result in the raster case fails on the gpu.
Project Member Comment 4 by bugdroid1@chromium.org, Sep 4 2015
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/500ab7562c3b50ec4408c1ebd3618c4cde4b6cb8

commit 500ab7562c3b50ec4408c1ebd3618c4cde4b6cb8
Author: caryclark <caryclark@google.com>
Date: Fri Sep 04 12:20:32 2015

change for issue 562

Add a current version of the patch described in issue 562.

Of interest: the reference row, which is described in the
bug as looking correct draws differently with Ganesh.

TBR=senorblanco
BUG=skia:562

Review URL: https://codereview.chromium.org/1324023006

[modify] http://crrev.com/500ab7562c3b50ec4408c1ebd3618c4cde4b6cb8/gm/shadows.cpp

Project Member Comment 5 by bugdroid1@chromium.org, Sep 4 2015
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/c8b350df079ebca5bd4a5340494680f66947a673

commit c8b350df079ebca5bd4a5340494680f66947a673
Author: caryclark <caryclark@google.com>
Date: Fri Sep 04 13:19:48 2015

update gm test size to include new elements

TBR=
BUG=skia:562

Review URL: https://codereview.chromium.org/1305983006

[modify] http://crrev.com/c8b350df079ebca5bd4a5340494680f66947a673/gm/shadows.cpp

Project Member Comment 6 by hcm@google.com, Nov 23 2015
Labels: Hotlist-Fixit
Project Member Comment 7 by caryclark@google.com, Jan 5 2016
Owner: bsalo...@google.com
gm:shadows demonstrates this bug. Someone on the GPU team should own it or close it.
Project Member Comment 8 by hcm@google.com, May 15
Iceboxing this aging bug- bring back into active priority if it will be worked on.
Project Member Comment 9 by hcm@google.com, May 15
Labels: -Priority-Medium Priority-Icebox
Project Member Comment 10 by hcm@google.com, May 15
Labels: Area-GPU
Sign in to add a comment