New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: Started
Owner:
Cc:
Area: ImageFilter
Priority: Medium
Type: Feature

Blocking:
issue 4473
issue chromium:446935



Sign in to add a comment

Pixel-moving image filters (e.g., blur) do not support skew or rotation correctly

Project Member Reported by pdr@chromium.org, Jan 7 2015 Back to list

Issue description

The SVG filter code in Blink uses ctm() to remove skew and rotation before applying deferred svg filters, then re-applies the skew and rotation using an image filter. We need to move this logic into Skia as the true CTM is not known in Blink.

(This bug corresponds to  crbug.com/446935 )
 
Project Member

Comment 1 by chrishtr@chromium.org, Jan 7 2015

Blocking: chromium:446935
Project Member

Comment 2 by hcm@google.com, Jan 7 2015

Cc: reed@google.com bsalo...@google.com senorblanco@chromium.org
Labels: -Type-Defect Type-Feature Area-ImageFilter
Add interested parties, but need to discuss who can own this one...
Project Member

Comment 3 by hcm@google.com, Jan 12 2015

Cc: -senorblanco@chromium.org robertph...@google.com hcm@google.com
Owner: senorblanco@chromium.org
Stephen, Can you take this one? Mike is going to work the other filter/quality/smarts requirements for slimming, but this seems to belong in your code.
Project Member

Comment 4 by senorblanco@chromium.org, Mar 16 2015

Here's a WIP patch which fixes this issue: https://codereview.chromium.org/986623003/
Project Member

Comment 5 by senorblanco@chromium.org, Mar 16 2015

Status: Started
Project Member

Comment 6 by chrishtr@chromium.org, Apr 4 2015

Labels: Hotlist-Slimming-Paint
Project Member

Comment 7 by chrishtr@chromium.org, Apr 4 2015

Blocking: chromium:382491
Project Member

Comment 8 by chrishtr@chromium.org, Apr 21 2015

Hi, any progress on this one?
Project Member

Comment 9 by senorblanco@chromium.org, Apr 22 2015

Mike: ping?
Project Member

Comment 10 by reed@google.com, Apr 22 2015

Will get back to a working-patch next week, traveling this week.
Project Member

Comment 11 by chrishtr@chromium.org, Apr 27 2015

Blocking: -chromium:382491
Project Member

Comment 12 by senorblanco@chromium.org, Apr 28 2015

Owner: reed@google.com
Project Member

Comment 14 by bugdroid1@chromium.org, May 14 2015

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/86a17e7716c8db858e219a46b9db3817bb770bee

commit 86a17e7716c8db858e219a46b9db3817bb770bee
Author: reed <reed@google.com>
Date: Thu May 14 12:25:22 2015 -0700

Revert of Implement support for non-scale/translate CTM in image filters. (patchset #4 id:60001 of https://codereview.chromium.org/1140943004/)

Reason for revert:
matriximagefilter needs to antialias its draw, so we get smooth diagonals...

Original issue's description:
> Implement support for non-scale/translate CTM in image filters.
>
> Clone with tweaks of https://codereview.chromium.org/986623003/
>
> pre-cl to guard chrome here: https://codereview.chromium.org/1133403003/
>
> BUG=skia:3288
>
> Committed: https://skia.googlesource.com/skia/+/35786b176c159d2e7a816e9da9b051ef3129d5cb

TBR=robertphillips@google.com,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3288

Review URL: https://codereview.chromium.org/1139173002

[modify] http://crrev.com/86a17e7716c8db858e219a46b9db3817bb770bee/include/core/SkCanvas.h
[modify] http://crrev.com/86a17e7716c8db858e219a46b9db3817bb770bee/src/core/SkCanvas.cpp

Project Member

Comment 16 by senorblanco@chromium.org, Oct 29 2015

 Issue 4523  has been merged into this issue.
Project Member

Comment 17 by senorblanco@chromium.org, Oct 29 2015

Summary: Pixel-moving image filters (e.g., blur) do not support skew or rotation correctly (was: Implement skew and rotation support for deferred svg filters)

Sign in to add a comment