Project: skia Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 2860 Test-Android-Nexus10-MaliT604-Arm7-Release generates erroneous GMs
Starred by 3 users Project Member Reported by caryclark@google.com, Aug 21 2014 Back to list
Status: Accepted
Owner:
Cc:
Area: GPU
Priority: Medium
Type: Defect



Sign in to add a comment
These became visible when the Nexus 10 was updated from Jellybean to KitKat.

It's likely that older GMs were also bad; the errors were undetected.

These tests may indicate low floating point precision in the GPU driver.

bezier_cubic_effects (note garbage top row sixth column)

big_blurs (top row should not be all black; many entries have wrong radius)

(and others)
 
bezier_cubic_effects.png
47.2 KB View Download
bigblurs.png
12.7 KB View Download
Project Member Comment 1 by bugdroid1@chromium.org, Aug 21 2014
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/5d74806b478a884bd763aee7e3e33cff1c506e50

commit 5d74806b478a884bd763aee7e3e33cff1c506e50
Author: caryclark <caryclark@google.com>
Date: Thu Aug 21 07:43:43 2014 -0700

update gm expectations for Nexus 10

the Android version was updated, introducing a new GPU driver

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/496733002


Project Member Comment 2 by bugdroid1@chromium.org, Aug 21 2014
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/78fc1dbed0216f3c85445b100331645a187c424f

commit 78fc1dbed0216f3c85445b100331645a187c424f
Author: caryclark <caryclark@google.com>
Date: Thu Aug 21 12:37:55 2014 -0700

update expectations for Nexus 10 Debug

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/492303003


Project Member Comment 3 by bsalo...@google.com, Aug 28 2014
Labels: Area-GPU
Owner: egdaniel@google.com
Assigning to Greg. I think we need to use highp vars in the Bezier effects when running on ES.
Project Member Comment 5 by bugdroid1@chromium.org, Aug 29 2014
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f

commit 9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f
Author: egdaniel <egdaniel@google.com>
Date: Fri Aug 29 11:12:30 2014 -0700

Fix to use high precision on cubics not conics.
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2860

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/521623003

[modify] https://skia.googlesource.com/skia.git/+/9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f/src/gpu/effects/GrBezierEffect.cpp

Project Member Comment 6 by egdaniel@google.com, Sep 2 2014
Changes have removed much of the major numerical issues to the n10 cubics. Still some smaller numerical issues involving curves not extending fully to end points.
n10_cubics.png
89.2 KB View Download
The bigblurs GM is still broken in the tiles_rt-gpu config.
bigblurs-N10.png
12.5 KB View Download
Project Member Comment 10 by bugdroid1@chromium.org, Oct 19 2015
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/a8e5fbdf30fb1a09c781c4aab91ec70839590626

commit a8e5fbdf30fb1a09c781c4aab91ec70839590626
Author: ethannicholas <ethannicholas@google.com>
Date: Mon Oct 19 15:38:16 2015

Fix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.

BUG=skia:2860

Review URL: https://codereview.chromium.org/1395693011

[modify] http://crrev.com/a8e5fbdf30fb1a09c781c4aab91ec70839590626/src/effects/SkBlurMaskFilter.cpp

Project Member Comment 11 by ethannicholas@google.com, Oct 19 2015
Fixed on the Nexus 10, still bad on Nexus 7. I'll take a look.
Sign in to add a comment