New issue
Advanced search Search tips

Issue 2664 link

Starred by 8 users

Issue metadata

Status: New
Owner:
Cc:
Area: Font
NextAction: ----
Priority: Medium
Type: Idea


Sign in to add a comment

Move text-related SkPaint properties into SkFont

Project Member Reported by jbroman@chromium.org, Jun 10 2014

Issue description

There doesn't seem to be a bug for SkFont yet, so I'm filing one. I don't think I can assign it to reed@, but he seems to be the one leading this. Feel free to reassign, rename, etc. as appropriate.

See also:
https://codereview.chromium.org/185293018
https://codereview.chromium.org/245953003
 
Project Member

Comment 1 by jbroman@chromium.org, Jun 10 2014

Blocking: chromium:383122
Project Member

Comment 2 by scro...@google.com, Jun 11 2014

Cc: bungeman@google.com scro...@google.com
Owner: reed@google.com
Project Member

Comment 3 by hcm@google.com, Aug 26 2014

Labels: Area-Font
Project Member

Comment 4 by tfarina@chromium.org, Nov 11 2014

Jeremy, is this about the isLinearText, setLinearText, isSubpixelText, setSubpixelText, etc?
Project Member

Comment 5 by jbroman@chromium.org, Nov 11 2014

reed@ would be the better person to ask, but my understanding is "yes". Mike's been working on this since before I filed this bug; I only wanted a way to track it.

The comment in SkFont.h seems to be the best description:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/include/core/SkFont.h
Project Member

Comment 6 by hcm@google.com, Dec 7 2015

Labels: Hotlist-Fixit
Project Member

Comment 7 by reed@google.com, Oct 18

Cc: herb@google.com djsollen@google.com hcm@google.com
Now only textblobs are the "native" way to draw text (other variants quickly devolve into blobs (or private glyphruns). Let's try making the big move:

1. add public SkFont (or some object)
2. allow those to be used instead of paints in textblobbuilder
3. add explicit SkFont parameter to drawText, drawPostText
4. at this point, we can remove the fontish fields from SkPaint

For android, we'll need to tweak the JNI code to track both a paint and font object for the legacy api

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fe4fc148546b656a5fa139e565f3b92deff0c764

commit fe4fc148546b656a5fa139e565f3b92deff0c764
Author: Mike Reed <reed@google.com>
Date: Mon Oct 22 18:48:19 2018

Change SkFont to match needs of textblob

Tentative roadmap:
- land this
- extend TextBlobBuilder to take SkFont for its runs (eventually removing paint option)
- change SkTextBlob to store SkFont instead of SkRunFont (not critical, but makes sense)

After the above, (or during) also work towards:
- removing callers of SkPaint set... (textsize, textscalex, typeface, etc.)
- eventually physically remove those setters/getters/fields
- rev as desired the SkFont API to clean up flags, hinting, etc.

Bug: skia:2664
Change-Id: I0e323c58aef055e26d697911b078797453cb3626
Reviewed-on: https://skia-review.googlesource.com/c/163783
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/fe4fc148546b656a5fa139e565f3b92deff0c764/tests/FontObjTest.cpp
[modify] https://crrev.com/fe4fc148546b656a5fa139e565f3b92deff0c764/src/core/SkFont.cpp
[modify] https://crrev.com/fe4fc148546b656a5fa139e565f3b92deff0c764/tests/FontMgrTest.cpp
[modify] https://crrev.com/fe4fc148546b656a5fa139e565f3b92deff0c764/include/core/SkFont.h

Project Member

Comment 9 by reed@google.com, Oct 24

Blockedon: 8493
Project Member

Comment 10 by reed@google.com, Oct 24

Blockedon: 8494
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/472639d9f12f7e4034f7aedeb22f44405d0d5d23

commit 472639d9f12f7e4034f7aedeb22f44405d0d5d23
Author: Mike Reed <reed@google.com>
Date: Wed Oct 24 15:01:46 2018

add alignment and lcd to SkFont (for now)

... both of these should be removed eventually. See related bugs to 2664

Bug: skia:2664
Change-Id: I49cd78380d84e5383a2a2742fa4dda98cf3d0194
Reviewed-on: https://skia-review.googlesource.com/c/164689
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>

[modify] https://crrev.com/472639d9f12f7e4034f7aedeb22f44405d0d5d23/src/core/SkFont.cpp
[modify] https://crrev.com/472639d9f12f7e4034f7aedeb22f44405d0d5d23/include/core/SkFont.h

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/c157c0a5a65597dab81a8970623ceeb0734b25e1

commit c157c0a5a65597dab81a8970623ceeb0734b25e1
Author: Mike Reed <reed@google.com>
Date: Wed Oct 24 18:14:56 2018

more setters for SkFont

Bug: skia:2664
Change-Id: Id5a09f8fd6bba99f77b508aed58147b34c02dbb2
Reviewed-on: https://skia-review.googlesource.com/c/164694
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/c157c0a5a65597dab81a8970623ceeb0734b25e1/src/core/SkFont.cpp
[modify] https://crrev.com/c157c0a5a65597dab81a8970623ceeb0734b25e1/include/core/SkFont.h

Project Member

Comment 13 by reed@google.com, Oct 27

Blockedon: 8504
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca

commit 14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca
Author: Cary Clark <caryclark@skia.org>
Date: Tue Oct 30 01:01:05 2018

update docs for new/changed textblob apis

Docs-Preview: https://skia.org/?cl=165944
Bug: skia:2664
Change-Id: Ifcd112cae535501d709bc124848e2425d2ec6e5c
Reviewed-on: https://skia-review.googlesource.com/c/165944
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>

[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkImage_Reference.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkImageInfo_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkTextBlob_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkTextBlobBuilder_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkPath_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkRegion_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/catalog.htm
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkRRect_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkCanvas_Reference.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/include/core/SkTextBlob.h
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkPaint_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkPaint_Reference.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkImageInfo_Reference.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/undocumented.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkCanvas_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/SkImage_Reference.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/undocumented.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/docs/illustrations.bmh
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkRRect_Reference.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkPath_Reference.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkTextBlob_Reference.md
[modify] https://crrev.com/14768f64fba34ab6b7bc0ed853c9cfdb1ab965ca/site/user/api/SkTextBlobBuilder_Reference.md

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6

commit 3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6
Author: Mike Reed <reed@google.com>
Date: Tue Oct 30 17:26:47 2018

hide the SkPaint::Align enum entirely

Bug: skia:2664
Change-Id: I080b015dbcb3a3cd73bb6847f3243a996d5f7b7d
Reviewed-on: https://skia-review.googlesource.com/c/166282
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>

[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/include/core/SkPaint.h
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/src/utils/SkTextUtils.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleXfermodesBlur.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleTiling.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/shadermaskfilter.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleArc.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleQuadStroker.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SamplePolyToPoly.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/src/core/SkPaint.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/imagefiltersbase.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/aaxfermodes.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/xfermodes2.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/androidblendmodes.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/src/core/SkTextBlobPriv.h
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/modules/skottie/src/SkottieValue.h
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/modules/skottie/src/SkottieValue.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/surface.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/dropshadowimagefilter.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/text_scale_skew.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleAAGeometry.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/imagefilterscropped.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/tools/viewer/SlideDir.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/coloremoji_blendmodes.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/tilemodes.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/include/utils/SkTextUtils.h
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/tilemodes_scaled.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/modules/sksg/src/SkSGText.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleFilter2.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/src/core/SkTextBlob.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/xfermodes.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/poly2poly.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/src/core/SkDrawProcs.h
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/modules/sksg/include/SkSGText.h
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/gm/windowrectangles.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleXfer.cpp
[modify] https://crrev.com/3a42ec0ee7937d88bb087b98c1b536fb7cbd77c6/samplecode/SampleAtlas.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d90028160469664fccdec91f15b64202b91a2600

commit d90028160469664fccdec91f15b64202b91a2600
Author: Mike Reed <reed@google.com>
Date: Mon Nov 05 14:37:04 2018

start to use SkFont api (paint's equivalents are deprecated)

TBR=cjgrant

Bug: skia:2664
Change-Id: Ie2b941409bcd84d61c3bdad22d57f45c7089af70
Reviewed-on: https://chromium-review.googlesource.com/c/1306513
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605322}
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/chrome/browser/vr/font_fallback.cc
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/third_party/blink/public/platform/web_font_render_style.h
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/third_party/blink/renderer/platform/fonts/font_platform_data.cc
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/third_party/blink/renderer/platform/fonts/font_platform_data.h
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/third_party/blink/renderer/platform/fonts/shaping/shape_result_bloberizer.cc
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/third_party/blink/renderer/platform/fonts/web_font_render_style.cc
[modify] https://crrev.com/d90028160469664fccdec91f15b64202b91a2600/third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/cb42b9106937dd284dcb836f3eca78bc6a62988d

commit cb42b9106937dd284dcb836f3eca78bc6a62988d
Author: Mike Reed <reed@google.com>
Date: Mon Nov 05 14:47:59 2018

add SkFontPriv.h

Bug: skia:2664
Change-Id: I1751aee25c64880e528432441be7fa6129fc1e0f
Reviewed-on: https://skia-review.googlesource.com/c/168260
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[add] https://crrev.com/cb42b9106937dd284dcb836f3eca78bc6a62988d/src/core/SkFontPriv.h

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/04346d538f96df46a0018ef69848924808e9d4f5

commit 04346d538f96df46a0018ef69848924808e9d4f5
Author: Mike Reed <reed@google.com>
Date: Mon Nov 05 18:16:32 2018

use SkFontHinting from SkFontTypes.h

Bug: skia:2664
Change-Id: Id10cd5efe79681411ce556874fd89ca7624909f7
Reviewed-on: https://skia-review.googlesource.com/c/168267
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/src/core/SkScalerContext.h
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/include/core/SkFontTypes.h
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/tools/fonts/SkRandomScalerContext.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/tools/fonts/SkTestSVGTypeface.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/src/core/SkScalerContext.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/tools/fonts/SkTestTypeface.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/src/ports/SkTypeface_win_dw.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/src/ports/SkFontHost_mac.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/src/ports/SkFontHost_FreeType.cpp
[modify] https://crrev.com/04346d538f96df46a0018ef69848924808e9d4f5/include/core/SkFont.h

Project Member

Comment 21 by scro...@google.com, Nov 5

Cc: -scro...@google.com
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/cb6f53efbc52f28cd243adf7acb8d5644a0bf068

commit cb6f53efbc52f28cd243adf7acb8d5644a0bf068
Author: Mike Reed <reed@google.com>
Date: Tue Nov 06 18:16:48 2018

split out fontmetrics into its own struct

Future CLs will migrate all callers to use SkFontMetrics,
so we can remove the SkPaint typedef.

Next migrate the world to use SkFont::getMetrics() instead

Bug: skia:2664
Change-Id: I2aa45cd88762c3d3589c12f5074974af7fb85410
Reviewed-on: https://skia-review.googlesource.com/c/168641
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/cb6f53efbc52f28cd243adf7acb8d5644a0bf068/include/core/SkPaint.h
[modify] https://crrev.com/cb6f53efbc52f28cd243adf7acb8d5644a0bf068/src/core/SkGlyphCache.cpp
[modify] https://crrev.com/cb6f53efbc52f28cd243adf7acb8d5644a0bf068/src/core/SkGlyphCache.h
[add] https://crrev.com/cb6f53efbc52f28cd243adf7acb8d5644a0bf068/include/core/SkFontMetrics.h
[modify] https://crrev.com/cb6f53efbc52f28cd243adf7acb8d5644a0bf068/gm/fontmgr.cpp
[modify] https://crrev.com/cb6f53efbc52f28cd243adf7acb8d5644a0bf068/src/core/SkPaint_text.cpp

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fbebecee0eb99338e1b08422842aba6ab724e243

commit fbebecee0eb99338e1b08422842aba6ab724e243
Author: Mike Reed <reed@google.com>
Date: Wed Nov 07 21:42:28 2018

hide nested hinting enum

Bug: skia:2664
Bug: skia:8527
Change-Id: I8f4b832d5524fb792bcc608d6bd515229881b048
Reviewed-on: https://skia-review.googlesource.com/c/168270
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>

[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/samplecode/SampleFilterFuzz.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/include/core/SkPaint.h
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/gpu/text/GrTextContext.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/gm/fontscaler.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tests/PDFTaggedTest.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tools/debugger/SkDrawCommand.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/include/core/SkFont.h
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/core/SkPaint.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tests/FontObjTest.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tests/PaintTest.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/core/SkTextBlobPriv.h
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/core/SkPaint_text.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tools/viewer/Viewer.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/core/SkFont.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/utils/SkLua.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/core/SkTextBlob.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tests/GlyphRunTest.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/gm/typeface.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/core/SkPaintDefaults.h
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/src/pdf/SkPDFFont.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tests/FontHostTest.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/modules/sksg/include/SkSGText.h
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/fuzz/FuzzDrawFunctions.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/modules/skottie/src/SkottieAdapter.cpp
[modify] https://crrev.com/fbebecee0eb99338e1b08422842aba6ab724e243/tests/TextBlobTest.cpp

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c

commit 6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c
Author: Mike Reed <reed@google.com>
Date: Wed Nov 07 22:06:01 2018

Revert "hide nested hinting enum"

This reverts commit fbebecee0eb99338e1b08422842aba6ab724e243.

Reason for revert: need staging guard for flutter

Original change's description:
> hide nested hinting enum
> 
> Bug: skia:2664
> Bug: skia:8527
> Change-Id: I8f4b832d5524fb792bcc608d6bd515229881b048
> Reviewed-on: https://skia-review.googlesource.com/c/168270
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: I19496daa059932574f36ac47061068a81d5524c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:2664, skia:8527
Reviewed-on: https://skia-review.googlesource.com/c/169344
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/samplecode/SampleFilterFuzz.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/include/core/SkPaint.h
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/gpu/text/GrTextContext.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/gm/fontscaler.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tests/PDFTaggedTest.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tools/debugger/SkDrawCommand.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/include/core/SkFont.h
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/core/SkPaint.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tests/FontObjTest.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tests/PaintTest.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/core/SkTextBlobPriv.h
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/core/SkPaint_text.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tools/viewer/Viewer.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/core/SkFont.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/utils/SkLua.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/core/SkTextBlob.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tests/GlyphRunTest.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/gm/typeface.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/core/SkPaintDefaults.h
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/src/pdf/SkPDFFont.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tests/FontHostTest.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/modules/sksg/include/SkSGText.h
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/fuzz/FuzzDrawFunctions.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/modules/skottie/src/SkottieAdapter.cpp
[modify] https://crrev.com/6bd19df9fa9d26d9de4de646b2cdf82ff5dca67c/tests/TextBlobTest.cpp

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf

commit 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf
Author: Mike Reed <reed@google.com>
Date: Fri Nov 09 14:32:02 2018

use SkFontHinting

Bug: skia:2664
Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
Reviewed-on: https://chromium-review.googlesource.com/c/1318416
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606832}
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/cc/paint/paint_flags.cc
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/cc/paint/paint_flags.h
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/chrome/renderer/pepper/pepper_flash_renderer_host.cc
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/content/renderer/render_view_fuchsia.cc
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/content/renderer/render_view_linux.cc
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/skia/config/SkUserConfig.h
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/third_party/blink/public/platform/web_font_render_style.h
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/third_party/blink/renderer/platform/fonts/font_metrics.cc
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/third_party/blink/renderer/platform/fonts/web_font_render_style.cc
[modify] https://crrev.com/9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf/third_party/blink/renderer/platform/graphics/logging_canvas.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed

commit dca2e91afaa6ccd9c31454019dd5074c99ecc5ed
Author: Mike Reed <reed@google.com>
Date: Sat Nov 10 13:28:04 2018

add fontmetrics to SkFont

Bug: skia:2664
Change-Id: I49030b6010e08814ec50c75dd26b44a5265d74bd
Reviewed-on: https://skia-review.googlesource.com/c/167461
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/include/core/SkPaint.h
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/src/core/SkFont.cpp
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/src/core/SkScalerContext.h
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/src/core/SkDraw_text.cpp
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/src/core/SkFontPriv.h
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/src/core/SkScalerContext.cpp
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/src/core/SkDraw.h
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/include/core/SkTypeface.h
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/tests/FontObjTest.cpp
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/src/core/SkStrikeCache.h
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/include/core/SkFontMetrics.h
[modify] https://crrev.com/dca2e91afaa6ccd9c31454019dd5074c99ecc5ed/include/core/SkFont.h

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 11

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/445148df00c63fe138f3b145d3340a3f8d8e20e7

commit 445148df00c63fe138f3b145d3340a3f8d8e20e7
Author: Mike Reed <reed@google.com>
Date: Sun Nov 11 22:34:17 2018

route getFontMetrics to SkFont

Bug: skia:2664
Change-Id: I6ce7ff1a99101c7b4c8902a7d80e4a6338c9ed97
Reviewed-on: https://skia-review.googlesource.com/c/170278
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>

[modify] https://crrev.com/445148df00c63fe138f3b145d3340a3f8d8e20e7/tests/FontObjTest.cpp
[modify] https://crrev.com/445148df00c63fe138f3b145d3340a3f8d8e20e7/src/core/SkPaint_text.cpp

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/0243949545eb0a69ceb3df743786e6c458ea7250

commit 0243949545eb0a69ceb3df743786e6c458ea7250
Author: Mike Reed <reed@google.com>
Date: Mon Nov 12 12:04:01 2018

Revert "route getFontMetrics to SkFont"

This reverts commit 445148df00c63fe138f3b145d3340a3f8d8e20e7.

Reason for revert: win layout failure

browser/ui/views/layout_provider_unittest.cc

Original change's description:
> route getFontMetrics to SkFont
> 
> Bug: skia:2664
> Change-Id: I6ce7ff1a99101c7b4c8902a7d80e4a6338c9ed97
> Reviewed-on: https://skia-review.googlesource.com/c/170278
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I7c22d18f7e6755dca059a68007c22cd1667162dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:2664
Reviewed-on: https://skia-review.googlesource.com/c/170343
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/0243949545eb0a69ceb3df743786e6c458ea7250/tests/FontObjTest.cpp
[modify] https://crrev.com/0243949545eb0a69ceb3df743786e6c458ea7250/src/core/SkPaint_text.cpp

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/5f50f5776d2d7b5b1c41c9ae5ef930d8a762ca5a

commit 5f50f5776d2d7b5b1c41c9ae5ef930d8a762ca5a
Author: Mike Reed <reed@google.com>
Date: Mon Nov 12 19:30:16 2018

New plan -- aa and lcd DO belong on SkFont

edging settings are needed for metrics calls, as well as drawing, hence
we really have to include them in almost every SkFont call/usage, so I
guess we can just accept them as real.

This seems to imply that we have to document what happens in drawTextBlob,
since it has a bunch of SkFonts (runs) AND a paint. This is the situation
today of course, and I had hoped to simplify it, but I think I've failed.

Proposal dox for drawTextBlob.

drawTextBlob respects the paint when drawing the blog, but it IGNORES the
paint's antialias (and lcdrender) flags, as these are already specified in
the blob's runs.

Bug: skia:2664, skia:8494
Change-Id: I8f69186c9c337d98d058919f53b7901ff830a16e
Reviewed-on: https://skia-review.googlesource.com/c/170352
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/5f50f5776d2d7b5b1c41c9ae5ef930d8a762ca5a/src/core/SkFont.cpp
[modify] https://crrev.com/5f50f5776d2d7b5b1c41c9ae5ef930d8a762ca5a/gm/textblobshader.cpp
[modify] https://crrev.com/5f50f5776d2d7b5b1c41c9ae5ef930d8a762ca5a/gm/textblob.cpp
[modify] https://crrev.com/5f50f5776d2d7b5b1c41c9ae5ef930d8a762ca5a/tests/FontMgrTest.cpp
[modify] https://crrev.com/5f50f5776d2d7b5b1c41c9ae5ef930d8a762ca5a/include/core/SkFont.h

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f537020f6ce5cc4f9aa14737e288885d63b053c7

commit f537020f6ce5cc4f9aa14737e288885d63b053c7
Author: Mike Reed <reed@google.com>
Date: Sun Nov 18 03:49:11 2018

Use SkFont instead of SkPaint for SkiaTextMetrics

Bug: skia:2664
Change-Id: I301b41217f901fe69d57dab9e69f7c468c34c0c9
Reviewed-on: https://chromium-review.googlesource.com/c/1338260
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609132}
[modify] https://crrev.com/f537020f6ce5cc4f9aa14737e288885d63b053c7/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.cc
[modify] https://crrev.com/f537020f6ce5cc4f9aa14737e288885d63b053c7/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.h

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c101dcd616e4e692a33db6fadfd0adcd8f717edc

commit c101dcd616e4e692a33db6fadfd0adcd8f717edc
Author: Mike Reed <reed@google.com>
Date: Mon Nov 19 15:39:41 2018

simple_font_data and harfbuzz_font to use SkFont instead of SkPaint

Change-Id: I0243c3853632ec44a2e1e4ec4220ce4425e05e64
Bug: skia:2664
Reviewed-on: https://chromium-review.googlesource.com/c/1341217
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609307}
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/font_metrics.cc
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/font_metrics.h
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/opentype/open_type_vertical_data.cc
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/opentype/open_type_vertical_data.h
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_font_cache.h
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/simple_font_data.cc
[modify] https://crrev.com/c101dcd616e4e692a33db6fadfd0adcd8f717edc/third_party/blink/renderer/platform/fonts/simple_font_data.h

Project Member

Comment 35 by reed@google.com, Nov 19

Blockedon: 8559
Project Member

Comment 37 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a590ea02ba46748374b78d78bdd0b6cfb3c9cd

commit 21a590ea02ba46748374b78d78bdd0b6cfb3c9cd
Author: Mike Reed <reed@google.com>
Date: Wed Nov 21 18:46:02 2018

export SkFont from PaintFlags

Bug: skia:2664
Change-Id: Icf69c8361ae1ff939d95ba3ac74d080ea9027525
Reviewed-on: https://chromium-review.googlesource.com/c/1343658
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610110}
[modify] https://crrev.com/21a590ea02ba46748374b78d78bdd0b6cfb3c9cd/cc/paint/paint_flags.cc
[modify] https://crrev.com/21a590ea02ba46748374b78d78bdd0b6cfb3c9cd/cc/paint/paint_flags.h
[modify] https://crrev.com/21a590ea02ba46748374b78d78bdd0b6cfb3c9cd/ui/gfx/harfbuzz_font_skia.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fef5eab4d21574b8ef8febfd4fa63fe311dfea1

commit 4fef5eab4d21574b8ef8febfd4fa63fe311dfea1
Author: Florin Malita <fmalita@chromium.org>
Date: Thu Nov 22 15:57:05 2018

Stop using deprecated/SkPaint-based SkTextBlobBuilder APIs

Convert the only client relying on the old API to the SkFont version.

TBR=

Bug: skia:2664
Change-Id: Ic4420a9e5d43dfc0edf6e4c23229be94e48c3e13
Reviewed-on: https://chromium-review.googlesource.com/c/1347309
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#610429}
[modify] https://crrev.com/4fef5eab4d21574b8ef8febfd4fa63fe311dfea1/ui/gfx/render_text.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ebb54aeb8f7594ff0d469109a7568fb343530a3

commit 4ebb54aeb8f7594ff0d469109a7568fb343530a3
Author: Mike Reed <reed@google.com>
Date: Thu Nov 29 12:00:17 2018

pass SkFont, not SkPaint, to SkTextBlobBuilder

TBR=vmpstr

Bug: skia:2664
Change-Id: Ie4d397f2cc3f997abed9c4614a96333f5956c805
Reviewed-on: https://chromium-review.googlesource.com/c/1351819
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612155}
[modify] https://crrev.com/4ebb54aeb8f7594ff0d469109a7568fb343530a3/cc/paint/paint_cache_unittest.cc
[modify] https://crrev.com/4ebb54aeb8f7594ff0d469109a7568fb343530a3/cc/paint/paint_op_perftest.cc
[modify] https://crrev.com/4ebb54aeb8f7594ff0d469109a7568fb343530a3/skia/config/SkUserConfig.h

Project Member

Comment 43 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb490207de5a1e95f84da23c255274d36c010ac

commit 1eb490207de5a1e95f84da23c255274d36c010ac
Author: Mike Reed <reed@google.com>
Date: Mon Dec 03 16:04:10 2018

add flag to switch to SkTextEncoding

Bug: skia:2664
Change-Id: I3a565b6dd47e9e09deaadb7e0962d95420fe8935
Reviewed-on: https://chromium-review.googlesource.com/c/1358692
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613103}
[modify] https://crrev.com/1eb490207de5a1e95f84da23c255274d36c010ac/skia/config/SkUserConfig.h

Project Member

Comment 44 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/48b958b7094d4a156c9bb8822a816b91f53de628

commit 48b958b7094d4a156c9bb8822a816b91f53de628
Author: Mike Reed <reed@google.com>
Date: Mon Dec 03 18:39:19 2018

change Run to store bool_aa instead of flags_only_aa

Bug: skia:2664
Change-Id: Idf89a511ba1427bf7a1000ba400aeafa215a7258
Reviewed-on: https://skia-review.googlesource.com/c/173993
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/48b958b7094d4a156c9bb8822a816b91f53de628/src/gpu/text/GrTextBlob.h
[modify] https://crrev.com/48b958b7094d4a156c9bb8822a816b91f53de628/src/gpu/text/GrTextBlob.cpp
[modify] https://crrev.com/48b958b7094d4a156c9bb8822a816b91f53de628/src/core/SkGlyphRunPainter.cpp

Project Member

Comment 46 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15ec682801537617ba819e09336399a51e45bf82

commit 15ec682801537617ba819e09336399a51e45bf82
Author: Mike Reed <reed@google.com>
Date: Thu Dec 06 13:09:16 2018

use SkFont for measure and break text

TBR=

Bug: skia:2664
Change-Id: Idf2e2d1c4eefd295d4262a0b49542c83119f639f
Reviewed-on: https://chromium-review.googlesource.com/c/1363212
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614328}
[modify] https://crrev.com/15ec682801537617ba819e09336399a51e45bf82/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/15ec682801537617ba819e09336399a51e45bf82/media/blink/webmediaplayer_cast_android.cc

Sign in to add a comment