Project: skia Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 260 PDF backend does not have an interface to specify rotation.
Starred by 6 users Project Member Reported by vandebo@chromium.org, May 14 2011 Back to list
Status: Accepted
Owner:
Cc:
Area: PDF
Priority: Icebox
Type: Feature



Sign in to add a comment
There's a flag to indicate that a page should be displayed with rotation, SkPDFDevice should expose an API to set this flag.
 
Comment 1 by epoger@google.com, May 17 2011
Owner: vandebo@chromium.org
Project Member Comment 2 by edisonn@google.com, Oct 24 2013
Labels: Area-PDF
Project Member Comment 3 by caryclark@google.com, Sep 2 2015
Owner: halcanary@google.com
Moving all PDF issues assigned to vandebo to halcanary
Project Member Comment 4 by halcanary@google.com, Sep 2 2015
Labels: -Priority-Medium Priority-Low
This is feasible, but we'd have to change the SkDocument interface.
Project Member Comment 5 by halcanary@google.com, Sep 3 2015
Labels: -PDF
Project Member Comment 6 by hcm@google.com, Nov 22 2016
Labels: -Priority-Low -Type-Defect Priority-Icebox Type-Feature
Aged bug cleanup- seems like this has to go in the icebox, please update status if it is going to be actively worked.
Project Member Comment 7 by halcanary@google.com, Jun 7
Summary: PDF backend does not have an interface to specify rotation. (was: [PDF] The PDF backend does not have an interface to specify rotation.)
Project Member Comment 8 by halcanary@google.com, Jul 20 (3 days ago)
Cc: reed@google.com
How does this interface look?

class SkDocument {
    //....
    enum class Rotation {
        kPortrait = 0;
        kLandscape = 1;
        kInvertedPortrait = 2;
        kInvertedLandscape = 3;
    };
    SkCanvas* beginPage(SkScalar w, SkScalar h, Rotation r);
    SkCanvas* beginPage(SkScalar w, SkScalar h, SkRect* trim);
    //....
    SkCanvas* onBeginPage(SkScalar w, SkScalar h, Rotation r);
};
Project Member Comment 9 by reed@google.com, Jul 20 (3 days ago)
who needs this? How is this sort of thing handled today (outside of skia)?
Sign in to add a comment