New issue
Advanced search Search tips
Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Area: PDF
Priority: Low
Type: Feature

Blocking:
issue chromium:497732



Sign in to add a comment

SkPDF backend does not support SkColorFilter.

Project Member Reported by vandebo@chromium.org, May 13 2011 Back to list

Issue description

The PDF backend does not support SkColorFilter.  As is, the color filter interface seems to require a raster implementation.
 

Comment 1 by epoger@google.com, May 17 2011

Owner: vandebo@chromium.org
Project Member

Comment 2 by edisonn@google.com, Oct 24 2013

Labels: Area-PDF
Project Member

Comment 3 by fmalita@chromium.org, Jun 30 2015

Blocking: chromium:497732
Project Member

Comment 4 by caryclark@google.com, Sep 2 2015

Owner: halcanary@google.com
Moving all PDF issues assigned to vandebo to halcanary
Project Member

Comment 5 by halcanary@google.com, Sep 3 2015

Project Member

Comment 6 by halcanary@google.com, Apr 19 2016

Cc: halcanary@google.com
 Issue 4378  has been merged into this issue.
Project Member

Comment 7 by halcanary@google.com, Apr 19 2016

Blocking: -chromium:497732 chromium:497732
Cc: -halcanary@google.com
Summary: SkPDF backend does not support SkColorFilter. (was: [PDF] The PDF backend does not support SkColorFilter.)
https://fiddle.skia.org/c/b330e48b2497ff27260c79927504559d

    #include "gm.h"
    #include "SkColorMatrixFilter.h"
    DEF_SIMPLE_GM(colorfilter, canvas, 32, 32) {
        SkColorMatrix cm;
        cm.setSaturation(0.0f);
        SkPaint p;
        p.setColorFilter(
                SkColorFilter::MakeMatrixFilterRowMajor255(cm.fMat));
        p.setColor(SK_ColorRED);
        canvas->drawPaint(p);
    }


Project Member

Comment 8 by hcm@google.com, Nov 22 2016

Labels: Type-Feature
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/d12a67626da4f5919b48c513fee80974f603473e

commit d12a67626da4f5919b48c513fee80974f603473e
Author: Hal Canary <halcanary@google.com>
Date: Mon Jun 05 19:22:46 2017

SkPDF: Draw paths with mask filters; color filter.

Also:
  - drawPaint, drawPath w/ perspective shaders
  - text with mask filters, stroking, path effect.
  - SkPDFUtils::GetShaderLocalMatrix

BUG= skia:237 
BUG= skia:238 
BUG=skia:5607
Change-Id: Iffeaf2d7abbde13fd2577ce9feaa178657f48364
Reviewed-on: https://skia-review.googlesource.com/18200
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFDevice.h
[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFUtils.h
[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFShader.cpp

Project Member

Comment 10 by halcanary@google.com, Jun 7 2017

Status: Fixed
I believe this to be fixed.  Please re-open if I missed something.

Sign in to add a comment