New issue
Advanced search Search tips
Starred by 11 users
Status: Fixed
Owner:
Closed: Jun 20
Area: PDF
Priority: Low
Type: Feature


Sign in to add a comment
Skia's PDF backend does not support SkMaskFilter.
Project Member Reported by vandebo@chromium.org, May 13 2011 Back to list
The PDF backend doesn't support SkMaskFilter.  It seems difficult to implement this concept in a vector/PDF way - the result of a mask filter may be larger than the object it is applied to, and seems to require a raster representation of the objects.
 
Comment 1 by epoger@google.com, May 17 2011
Owner: vandebo@chromium.org
Project Member Comment 2 by edisonn@google.com, Mar 22 2013
Status: Started
I think we need to do this in order to support CSS3 shadow -  http://code.google.com/p/chromium/issues/detail?id=132239

I am working on it
Project Member Comment 3 by edisonn@google.com, Mar 22 2013
Cc: vandebo@chromium.org
Owner: edisonn@google.com
Project Member Comment 4 by edisonn@google.com, Oct 24 2013
Labels: Area-PDF
Project Member Comment 5 by hcm@google.com, Jan 8 2014
Owner: bungeman@google.com
Assigning to Ben since Edison is gone.
Project Member Comment 6 by hcm@google.com, Mar 19 2014
Labels: -Type-Defect -Priority-Medium Type-Idea Priority-Low
Project Member Comment 7 by hcm@google.com, Dec 7 2015
Labels: Hotlist-Fixit
Project Member Comment 8 by halcanary@google.com, Dec 10 2015
Labels: -PDF
Project Member Comment 9 by hcm@google.com, Dec 15 2015
Owner: ----
Project Member Comment 10 by caryclark@google.com, Jan 5 2016
Cc: -vandebo@chromium.org
Owner: hcm@google.com
Project Member Comment 11 by caryclark@google.com, Jan 5 2016
Owner: halcanary@google.com
Blocking: chromium:354073
Blocking: chromium:127651
Project Member Comment 14 by hcm@google.com, Nov 22 2016
Labels: Type-Feature
Is there any update on this one? Seems like all the PDF printing issues related to shadows are coming back to this issue. Would be awesome to see this finally fixed.
Yes I agree, looks like the PDF printing issues related to shadows are coming back to this issue. It would be amazing to get this fixed. Any status update?
Project Member Comment 17 by bugdroid1@chromium.org, Jun 5
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/d12a67626da4f5919b48c513fee80974f603473e

commit d12a67626da4f5919b48c513fee80974f603473e
Author: Hal Canary <halcanary@google.com>
Date: Mon Jun 05 19:22:46 2017

SkPDF: Draw paths with mask filters; color filter.

Also:
  - drawPaint, drawPath w/ perspective shaders
  - text with mask filters, stroking, path effect.
  - SkPDFUtils::GetShaderLocalMatrix

BUG= skia:237 
BUG= skia:238 
BUG=skia:5607
Change-Id: Iffeaf2d7abbde13fd2577ce9feaa178657f48364
Reviewed-on: https://skia-review.googlesource.com/18200
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFDevice.h
[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFUtils.h
[modify] https://crrev.com/d12a67626da4f5919b48c513fee80974f603473e/src/pdf/SkPDFShader.cpp

Project Member Comment 18 by halcanary@google.com, Jun 7
Current status: fixed for paths and text.   Non-Alpha Images on the way.
Project Member Comment 19 by halcanary@google.com, Jun 7
Summary: Skia's PDF backend does not support SkMaskFilter. (was: [PDF] The PDF backend does not support SkMaskFilter.)
Project Member Comment 20 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fa2a26a026fb69659eef3857be58d4d5b0c75e29

commit fa2a26a026fb69659eef3857be58d4d5b0c75e29
Author: Hal Canary <halcanary@google.com>
Date: Wed Jun 07 19:30:05 2017

SkPDF: Do draw{Image,Bitmap}Rect with maskfilter.

https://fiddle.skia.org/c/@skbug_237_drawImageRect

BUG= skia:237 
Change-Id: I4d6d683fcbfd6dc86a27998e3d03534458952db0
Reviewed-on: https://skia-review.googlesource.com/19023
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

[modify] https://crrev.com/fa2a26a026fb69659eef3857be58d4d5b0c75e29/src/pdf/SkPDFCanvas.cpp

Project Member Comment 21 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/9982c4eb76af58e18df2cd3dd81913439f1b6157

commit 9982c4eb76af58e18df2cd3dd81913439f1b6157
Author: Hal Canary <halcanary@google.com>
Date: Wed Jun 07 20:08:46 2017

GM for drawImage w/ maskFilter

BUG= skia:237 
Change-Id: I8b06fa5b0e05af28e010ccbd2772c64e3eaefdde
Reviewed-on: https://skia-review.googlesource.com/19026
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

[modify] https://crrev.com/9982c4eb76af58e18df2cd3dd81913439f1b6157/gm/blurs.cpp

Project Member Comment 22 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/db6365a9e267192c02d2745a654b07888f76b32e

commit db6365a9e267192c02d2745a654b07888f76b32e
Author: Hal Canary <halcanary@google.com>
Date: Wed Jun 07 20:21:16 2017

SkPDF: Do draw{Image,Bitmap} with maskfilter.

https://fiddle.skia.org/c/@skbug_237_drawImage_with_blur
BUG= skia:237 
Change-Id: I50f65d428f254e3965a448a110edd39c0f7a937f
Reviewed-on: https://skia-review.googlesource.com/19027
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

[modify] https://crrev.com/db6365a9e267192c02d2745a654b07888f76b32e/src/pdf/SkPDFCanvas.cpp
[modify] https://crrev.com/db6365a9e267192c02d2745a654b07888f76b32e/src/pdf/SkPDFCanvas.h

Project Member Comment 23 by halcanary@google.com, Jun 20
Status: Fixed
Marking as fixed.

The one exception is drawImage with an alpha image.
Sign in to add a comment