Project: skia Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 2269 Document and test ImageFilter factories
Starred by 6 users Project Member Reported by reed@google.com, Mar 7 2014 Back to list
Status: Accepted
Owner:
Cc:
Area: ImageFilter
Priority: Low
Type: Defect



Sign in to add a comment
Now that we use factories to create imagefilter subclasses (which is good), we should take advantage of this.

1. check the inputs for sanity, and return NULL if they don't make sense
2. document and write tests to exercise #1
3. look for more aggressive special-cases, and return different subclasses based on the input params as we see the opportunity (e.g. gradientshader factory does this).
 
Project Member Comment 1 by hcm@google.com, Oct 14 2014
Labels: Area-ImageFilter
Project Member Comment 2 by hcm@google.com, Dec 7 2015
Labels: Hotlist-Fixit
Project Member Comment 3 by senorblanco@chromium.org, Jan 28 2016
Labels: -Priority-Medium Priority-Low
Sign in to add a comment