New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 2269 link

Starred by 7 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Area: ImageFilter
NextAction: ----
Priority: Low
Type: Defect



Sign in to add a comment

Document and test ImageFilter factories

Project Member Reported by reed@google.com, Mar 7 2014

Issue description

Now that we use factories to create imagefilter subclasses (which is good), we should take advantage of this.

1. check the inputs for sanity, and return NULL if they don't make sense
2. document and write tests to exercise #1
3. look for more aggressive special-cases, and return different subclasses based on the input params as we see the opportunity (e.g. gradientshader factory does this).
 
Project Member

Comment 1 by hcm@google.com, Oct 14 2014

Labels: Area-ImageFilter
Project Member

Comment 2 by hcm@google.com, Dec 7 2015

Labels: Hotlist-Fixit
Project Member

Comment 3 by senorblanco@chromium.org, Jan 28 2016

Labels: -Priority-Medium Priority-Low
Project Member

Comment 4 by senorblanco@chromium.org, Apr 6 2018

Status: WontFix (was: Accepted)
The ImageFilterFuzzer work took care of #1 and #2. If there's work remaining for #3, feel free to reopen.

Sign in to add a comment