New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 1892 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Area: Infrastructure
NextAction: ----
Priority: Medium
Type: Defect



Sign in to add a comment

assertion failures in SampleApp when scaled

Reported by epoger@google.com, Dec 11 2013

Issue description

Reported via email by reed:

Try this experiment:

1. sync to latest skia
2. launch SampleApp
3. hit UP-ARROW once to introduce a slight scale in the canvas
4. hit 'a' to start animating through the slides

I am seeing multiple asserts when I run in this mode. I think this is very scary, since running with some amount of scaling is the common behavior on Android and other non-default-DPI devices (i.e. pixel).

We need to fix these!

I will work to rev gm/dm to explicitly exercise this, but as I already think we will hit asserts, we may need to fix the current problems before we can enable this on the bots...

 
Project Member

Comment 1 by hcm@google.com, Oct 13 2014

Labels: Area-Infrastructure
Project Member

Comment 2 by scro...@google.com, Jan 29 2015

Owner: senorblanco@chromium.org
I just ran through a bunch of them, and it crashed here:

../../src/effects/SkMagnifierImageFilter.cpp:295: failed assertion "fSrcRect.width() < src.width()"

This may be related to  issue 781 .

If we skip the ImageFilterFuzzView, there may be more; not sure yet.

Project Member

Comment 3 by senorblanco@chromium.org, Jan 29 2015

Cc: zork@chromium.org
Project Member

Comment 4 by scro...@google.com, Jan 29 2015

Cc: skiabot@google.com
When I disabled that test, I saw no other asserts. Once we fix this, we can add a bot to regularly test.
Project Member

Comment 5 by senorblanco@chromium.org, May 11 2018

Status: WontFix (was: New)
SampleApp is long gone, and I don't see this assertion in Viewer (the assert was removed a while back). I do see other asserts when I run in "s" mode with --match ImageFilterFuzzer (to repeatedly redraw the fuzzer), but let's open new bugs for those.

Sign in to add a comment