New issue
Advanced search Search tips

Issue 1627 link

Starred by 8 users

Issue metadata

Status: New
Owner:
Cc:
Area: ImageFilter
NextAction: ----
Priority: Medium
Type: Defect



Sign in to add a comment

DrawFilter should be able to set ImageFilter on the paint

Reported by dnuser...@apportable.com, Sep 12 2013

Issue description

Right now it doesnot work.

 
drawfilterimagefilter.diff
955 bytes View Download
Project Member

Comment 1 by scro...@google.com, Sep 12 2013

Cc: scro...@google.com
Owner: reed@google.com
Project Member

Comment 2 by hcm@google.com, Aug 27 2014

Labels: Area-ImageFilter
Project Member

Comment 3 by reed@google.com, Jan 29 2015

Don't understand the title of this issue. What is the bug/request?
Project Member

Comment 4 by scro...@google.com, Jan 29 2015

As stated in the code review, drawfilter can modify many settings on the paint, but apparently not the image filter.

If you think the current behavior is correct, feel free to mark as wontfix
Project Member

Comment 5 by reed@google.com, Jan 29 2015

How about this: SkCanvas needs to respect the "filtered" paint, including any changes to imagefilters. Today when we inspect the paint, we look to see if it has an imagefilter *before* we call the filter, thus ignoring it if the filter were to add one.

Seems valid, tho perhaps low-priority.
I think I'd be even happier if we could eliminate DrawFilters all together ... :)
Project Member

Comment 6 by scro...@google.com, Jan 29 2015

Cc: djsollen@google.com
Derek, do you think we can deprecate DrawFilter? I know Android currently supports it.
Project Member

Comment 7 by djsollen@google.com, Jan 29 2015

It is exposed in the SDK and with a quick search it is used by both the Launcher and Settings in the OS and undoubtedly by other 3rd party apps.  However, ImageFilters are not exposed through the Android SDK so this bug itself does not directly impact Android though its removal would.

Sign in to add a comment