New issue
Advanced search Search tips
Starred by 4 users
Status: Accepted
Owner:
Cc:
Area: ----
Priority: Low
Type: Defect



Sign in to add a comment
GiantDashBench is consuming > 35MB of data
Project Member Reported by djsollen@google.com, Jul 17 2013 Back to list
What steps will reproduce the problem?
1. run bench --match giantdash -- repeat 10 --config gpu

the massif tool of Valgrind shows that 30MB is being used by the ChunkAllocator and SkPath is holding 5MB of data. Do we really need that much?

This profile was taken on a Nexus 7 and closely mirrors what I see on linux as well.
 
dash_bench_memory.png
445 KB View Download
massif_bench_2.out
59.4 KB View Download
Project Member Comment 1 by djsollen@google.com, Jul 17 2013
Cc: bsalo...@google.com
Project Member Comment 2 by bsalo...@google.com, Jul 17 2013
There are some smaller things to optimize here but the big culprit is buildPoly(). I wonder if the way the Gr code calls SkDraw precludes some clipping that a raster device would benefit from?
Project Member Comment 3 by djsollen@google.com, Jul 18 2013
Blocking: skia:1422
Project Member Comment 4 by djsollen@google.com, Jul 18 2013
A temporary fix to unblock the build bots for Android is in with https://codereview.chromium.org/19672007/

When this bugs is resolved we should roll back this temp CL.
Project Member Comment 5 by hcm@google.com, Dec 7 2015
Labels: Hotlist-Fixit
Project Member Comment 6 by caryclark@google.com, Feb 26 2016
Owner: djsollen@google.com
Status: Unconfirmed
Nanobench doesn't appear to be consuming > 35 MB anymore. I know the underlying problem is still there (e.g. dashes get fully instantiated in source space before clipping) but maybe things have gotten better? Still a problem?
Project Member Comment 7 by djsollen@google.com, Mar 17 2016
Labels: -Priority-Medium Priority-Low
Status: Accepted
When I get some time I'll removed the #ifndef SK_BUILD_FOR_ANDROID from the bench and try to see if we still crash the android test devices.
Project Member Comment 8 by scro...@google.com, Sep 11
Blocking: -1422
Labels: TestDisabled
Sign in to add a comment