Project: skia Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 1254 Can we reduce the complexity of our SkAdvancedTypefaceMetrics API?
Starred by 8 users Project Member Reported by reed@google.com, Apr 18 2013 Back to list
Status: Accepted
Owner:
Last visit 18 days ago
Cc:
Area: Font
Priority: Medium
Type: Idea



Sign in to add a comment
Can the use cases for SkAdvancedTypefaceMetrics be itemized into a set of smaller-looking APIs? This request is part of us reformulating the SkFontHost and SkFontMgr APIs.
 
Project Member Comment 1 by reed@google.com, Apr 18 2013
Cc: bungeman@google.com edisonn@google.com vandebo@chromium.org
Owner: ----
Project Member Comment 2 by vandebo@chromium.org, Apr 18 2013
A historic note: When the API was added some where still skeptical of PDF, so everything that PDF needs to know about fonts is packaged up into the one API.  It seems perfectly reasonable to pull it apart into multiple requests; adding info to some existing APIs and creating some new ones.

A quick look through the current API...
- font name, type, max glyph id, total bbox, em size (there are multiple consumers em size) -- these can all be bundled together as a general info about a font, or pulled apart into separate calls.
- style info (flags, italic angle, ascent, descent, stemv, cap height)
- get advances (horizontal or vertical)
- guess unicode table
- get glyph names (type 1 only)

multimaster bit isn't really used.

Happy to talk more on this if useful.
Project Member Comment 3 by reed@google.com, Apr 18 2013
Certainly one way to break things up is if the requested info is per-glyph or font-wide.

Project Member Comment 4 by hcm@google.com, Sep 15 2014
Labels: -Type-Defect Type-Idea Area-Font
Project Member Comment 5 by caryclark@google.com, Sep 2 2015
Owner: halcanary@google.com
Assigning to current PDF owner.
Project Member Comment 6 by halcanary@google.com, Oct 22 2015
Labels: -Priority-Medium Priority-Icebox
Project Member Comment 7 by reed@chromium.org, Oct 22 2015
Cc: -edisonn@google.com -vandebo@chromium.org
Labels: -Priority-Icebox Priority-Medium
why ice-box? I find that interface gigantic and hard-to-understand. Since its private (afaik), lets make it a priority to fix/reduce it.
Project Member Comment 8 by halcanary@google.com, Oct 22 2015
Cc: -bungeman@google.com halcanary@google.com
Owner: bungeman@google.com
If this should happen, I'm not the person to do it.  I think bungeman@ should own this.  He can provide any internal API on SkTypeface, as long as everything SkPDFFont needs is provided somehow.
Sign in to add a comment