New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Last visit > 30 days ago
Closed: Sep 2017

Sign in to add a comment

Issue 1294: Broadcom: Denial of service and OOB read in TCP KeepAlive Offloading

Reported by, Jun 14 2017

Issue description

Broadcom produces Wi-Fi HardMAC SoCs which are used to handle the PHY and MAC layer processing. These chips are present in both mobile devices and Wi-Fi routers, and are capable of handling many Wi-Fi related events without delegating to the host OS.

In order to reduce overhead on the host, some Broadcom Wi-Fi chips support TCP ACK Offloading. When this feature is enabled, the firmware keeps a list of active TCP connections, including the 4-tuple, the SEQ/ACK numbers, etc.

Before performing the offloading operation, incoming TCP packets are verified to ensure they are valid. During this verification process, the incoming packets' checksums are calculated. For IPv4 packets, the IPv4 header checksum and TCP/IPv4 checksum are calculated and compared to the checksums in the incoming packet. 

On the BCM4355C0 SoC with firmware version, the offloading verification is performed in RAM function 0x1800C8. Here is a snippet of the approximate high-level logic for this function:

int function_1800C8(void* ctx, void* packet) {

    char* packet_data = *((char**)(packet + 8));
    unsigned short packet_length = *((unsigned short*)(packet + 12));
    char* packet_end = packet_data + packet_length;

    //Getting the ethertype. If there's a SNAP header, get the ethertype from SNAP.

    //Is this IPv4?
    if (ethertype == 0x800) {

        unsigned ip_header_length = (ip_header[0] & 0xF) * 4; //IHL * 4
        char* tcp_header = ip_header + ip_header_length;

        if (tcp_header > packet_end)
            return 0;

        //Make sure this is TCP
        if (ip_header[9] != 6) //IPv4->Protocol == TCP
            return 0;
        //Making sure the IP total length is valid
        unsigned short ip_total_length = (ip_header[2] << 8) | ip_header[3];
        unsigned tcp_length = ip_total_length - ip_header_length;
        if (tcp_header + tcp_length > packet_end)
            return 0;
        //Verify IPv4 checksum
        unsigned short ipv4_checksum = *((unsigned short*)(ip_header+10));
        if (ipv4_checksum != do_ipv4_checksum(ip_header, ip_header_length))
            return 0;

        //Verify TCP/IPv4 checksum
        unsigned short tcp_checksum = *((unsigned short*)(tcp_header+16));
        if (tcp_checksum != do_tcp_ipv4_checksum(ip_header, tcp_header, tcp_length))
            return 0;

unsigned short do_ipv4_checksum(char* ip, unsigned len) {
    return internal_calculate_ipv4_checksum(..., ip + 12, len - 12);

unsigned short do_tcp_ipv4_checksum(char* ip, char* tcp, unsigned len) {
    return internal_calculate_tcp_ipv4_checksum(..., ip + 18, len - 18);

As can be seen above, there are a few missing length verifications in the snippet above:

  1. The IHL field in the IPv4 header is not verified against in minimal allowed value (5). This means an attacker can provide an intentionally small value, such as zero. Doing so will cause the following accesses to be performed OOB (such as checking the IP header's protocol field, calculating the IPv4 checksum, etc).

  2. The IP total length field is also not verified. An attacker can choose the total length field such that ip_total_length == ip_header_length. By doing so, tcp_length will contain the value zero. However, as the unsigned value (tcp_length - 12) is used as the length field in the internal TCP/IPv4 checksum calculation, this will cause the internal checksum calculation loop (RAM function 0x16DBF6) to receive a very large length field - causing an data abort due to an illegal access which will therefore crash the firmware.

The bug can be addressed by validating that the IHL is not smaller than the minimal allowed value (5), and by ensuring that the IP total length field is large enough to contain the IPv4 and TCP headers.

This bug is subject to a 90 day disclosure deadline. After 90 days elapse
or a patch has been made broadly available, the bug report will become
visible to the public.

Comment 1 by, Jun 23 2017

Summary: Broadcom: Denial of service and OOB read in TCP KeepAlive Offloading (was: Broadcom: Denial of service and OOB read in TCP ACK Offloading)

Comment 2 by, Aug 29 2017

Labels: CVE-2017-7066 Deadline-Grace

Comment 3 by, Sep 27 2017

Labels: -Restrict-View-Commit
Status: Fixed (was: New)

Sign in to add a comment