New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 4
Cc:
Components:

Blocking:
issue chromium:874689



Sign in to add a comment
link

Issue 4406: Remove "--if-needed" arg to update.py in nacl's DEPS file

Reported by thakis@chromium.org, Aug 15

Issue description

What steps will reproduce the problem?
1. Look at https://cs.chromium.org/chromium/src/native_client/DEPS?type=cs&q=%5C--if-needed&sq=package:chromium&g=0&l=159

What is the expected output? What do you see instead?

Expected: Action is just `    'action': ['python', 'src/tools/clang/scripts/update.py'],` without any flags (cf https://cs.chromium.org/chromium/src/DEPS?q=src/deps&sq=package:chromium&dr&l=1727)

Actual: No-op --if-needed flag is passed.

This blocks us from removing the flag from update.py.
 

Comment 1 by thakis@chromium.org, Aug 15

Blocking: chromium:874689

Comment 3 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/1ea07c56ac9b57c30eb784ab2af582af0cdd4b08

commit 1ea07c56ac9b57c30eb784ab2af582af0cdd4b08
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jan 04 18:37:30 2019

Stop passing no-op --if-needed to clang update script.

Bug:  nativeclient:4406 
Change-Id: I03517f106b2a79e986d321405a9e49649d3c6805
Reviewed-on: https://chromium-review.googlesource.com/c/1394436
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>

[modify] https://crrev.com/1ea07c56ac9b57c30eb784ab2af582af0cdd4b08/DEPS

Comment 4 by thakis@chromium.org, Jan 4

Fixed

Comment 5 by mseaborn@chromium.org, Jan 4

Project Member
Status: Fixed (was: New)

Sign in to add a comment