New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:

Blocked on:
issue 4392
issue chromium:701142
issue chromium:701564
issue 4394

Blocking:
issue chromium:699210



Sign in to add a comment
link

Issue 4391: pnacl-clang driver should support --build-id flag with argument

Reported by dschuff@chromium.org, Mar 8 2017 Project Member

Issue description

pnacl-clang has support for GNU-style build IDs (when producing native output) using the --build-id flag. But GNU and LLVM tools also accept an argument such as --build-id=sha1 for the type of ID. The PNaCl driver should accept and pass that through to the underlying tools.
 

Comment 1 by dschuff@chromium.org, Mar 8 2017

Project Member
Cc: thakis@chromium.org

Comment 2 by dschuff@chromium.org, Mar 8 2017

Project Member
Blocking: chromium:699210

Comment 3 by bugdroid1@chromium.org, Mar 9 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/42ae93a39e49116f69e1a5b2056c55564a6309f0

commit 42ae93a39e49116f69e1a5b2056c55564a6309f0
Author: Derek Schuff <dschuff@chromium.org>
Date: Thu Mar 09 00:55:08 2017

PNaCl Driver: Accept argument to --build-id flag

Currently we accept --build-id but not e.g. --build-id=sha1, which is
supported by other tools. Make pnacl-ld and nativeld accept this variant
and pass through to the underlying tools.

BUG= nativeclient:4391 

Change-Id: I4ef61d44c530c2482d04ad8b69795355d77c0d50
Reviewed-on: https://chromium-review.googlesource.com/451721
Reviewed-by: Jim Stichnoth <stichnot@chromium.org>

[modify] https://crrev.com/42ae93a39e49116f69e1a5b2056c55564a6309f0/pnacl/driver/nativeld.py
[modify] https://crrev.com/42ae93a39e49116f69e1a5b2056c55564a6309f0/pnacl/driver/pnacl-ld.py
[modify] https://crrev.com/42ae93a39e49116f69e1a5b2056c55564a6309f0/pnacl/driver/pnacl-translate.py
[modify] https://crrev.com/42ae93a39e49116f69e1a5b2056c55564a6309f0/tests/toolchain/nacl.scons
[modify] https://crrev.com/42ae93a39e49116f69e1a5b2056c55564a6309f0/toolchain_build/toolchain_build_pnacl.py

Comment 4 by dschuff@chromium.org, Mar 9 2017

Project Member
Blockedon: 4392

Comment 5 by bugdroid1@chromium.org, Mar 9 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/62bfd122aee87d4eb4a7876950e18c793c626cd0

commit 62bfd122aee87d4eb4a7876950e18c793c626cd0
Author: Derek Schuff <dschuff@chromium.org>
Date: Thu Mar 09 17:13:27 2017

Add test file missing from last commit

rev 42ae93 had a test but I forgot to 'git add' the expectation file.

BUG= 4391 
TBR=bradnelson@chromium.org

Change-Id: I6401c4f9b11ae206457a5b57ebc3431fde20a626
Reviewed-on: https://chromium-review.googlesource.com/452657
Reviewed-by: Derek Schuff <dschuff@chromium.org>

[add] https://crrev.com/62bfd122aee87d4eb4a7876950e18c793c626cd0/tests/toolchain/build_id_check_text

Comment 6 by bugdroid1@chromium.org, Mar 13 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/93a51ecd3c7873554c9f384167142e2c45edfefb

commit 93a51ecd3c7873554c9f384167142e2c45edfefb
Author: Derek Schuff <dschuff@chromium.org>
Date: Mon Mar 13 22:15:33 2017

Update revision for PNaCl

Update 5dfe030a71ca66e72c5719ef5034c2ed24706c43 -> 62bfd122aee87d4eb4a7876950e18c793c626cd0

Pull the following PNaCl changes into NaCl:
  70540f6: (petar.jovanovic@rt-rk.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
    | 63a5544: (petar.jovanovic@rt-rk.com) Cherry-pick r247546: [mips] Save a copy of MipsABIInfo ...
  42ae93a: (dschuff@chromium.org) PNaCl Driver: Accept argument to --build-id flag

BUG=  nativeclient:4391 
BUG= none
R= dschuff@chromium.org, petar.jovanovic@rt-rk.com
TEST=git cl try
(Please LGTM this change and tick the "commit" box)

Change-Id: I8ee3ff64678ea0b2f16a4a2199fc706e692de482
Reviewed-on: https://chromium-review.googlesource.com/453878
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

[modify] https://crrev.com/93a51ecd3c7873554c9f384167142e2c45edfefb/toolchain_revisions/pnacl_newlib.json
[modify] https://crrev.com/93a51ecd3c7873554c9f384167142e2c45edfefb/toolchain_revisions/pnacl_newlib_raw.json
[modify] https://crrev.com/93a51ecd3c7873554c9f384167142e2c45edfefb/toolchain_revisions/pnacl_translator.json

Comment 7 by bugdroid1@chromium.org, Mar 13 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d70c836af11f5d8b317be8339062de2caa4d049

commit 0d70c836af11f5d8b317be8339062de2caa4d049
Author: nacl-deps-roller <nacl-deps-roller@chromium.org>
Date: Mon Mar 13 23:37:52 2017

Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/62bfd122aee8..93a51ecd3c78

$ git log 62bfd122a..93a51ecd3 --date=short --no-merges --format='%ad %ae %s'
2017-03-13 dschuff Update revision for PNaCl

Created with:
  roll-dep src/native_client

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org
BUG= nativeclient:4391 

Review-Url: https://codereview.chromium.org/2753433002
Cr-Commit-Position: refs/heads/master@{#456545}

[modify] https://crrev.com/0d70c836af11f5d8b317be8339062de2caa4d049/DEPS

Comment 8 by bugdroid1@chromium.org, Mar 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ed93b49b9ccedc56cf2211d4e3f1c2e331e2403

commit 1ed93b49b9ccedc56cf2211d4e3f1c2e331e2403
Author: dschuff <dschuff@chromium.org>
Date: Tue Mar 14 00:07:33 2017

Revert of Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit) (patchset #1 id:1 of https://codereview.chromium.org/2753433002/ )

Reason for revert:
Caused chrome build failure:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/79660

Original issue's description:
> Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit)
>
> https://chromium.googlesource.com/native_client/src/native_client.git/+log/62bfd122aee8..93a51ecd3c78
>
> $ git log 62bfd122a..93a51ecd3 --date=short --no-merges --format='%ad %ae %s'
> 2017-03-13 dschuff Update revision for PNaCl
>
> Created with:
>   roll-dep src/native_client
>
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
> TBR=mseaborn@chromium.org
> BUG= nativeclient:4391 
>
> Review-Url: https://codereview.chromium.org/2753433002
> Cr-Commit-Position: refs/heads/master@{#456545}
> Committed: https://chromium.googlesource.com/chromium/src/+/0d70c836af11f5d8b317be8339062de2caa4d049

TBR=mseaborn@chromium.org,nacl-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= nativeclient:4391 

Review-Url: https://codereview.chromium.org/2746333003
Cr-Commit-Position: refs/heads/master@{#456556}

[modify] https://crrev.com/1ed93b49b9ccedc56cf2211d4e3f1c2e331e2403/DEPS

Comment 9 by dschuff@chromium.org, Mar 14 2017

Project Member
Blockedon: chromium:701142

Comment 10 by bugdroid1@chromium.org, Mar 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d5134eee2e410876b63c1020fd289a6f6461de

commit 27d5134eee2e410876b63c1020fd289a6f6461de
Author: nacl-deps-roller <nacl-deps-roller@chromium.org>
Date: Tue Mar 14 21:00:51 2017

Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/62bfd122aee8..93a51ecd3c78

$ git log 62bfd122a..93a51ecd3 --date=short --no-merges --format='%ad %ae %s'
2017-03-13 dschuff Update revision for PNaCl

Created with:
  roll-dep src/native_client

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=dschuff@chromium.org
BUG= nativeclient:4391 

Review-Url: https://codereview.chromium.org/2749113002
Cr-Commit-Position: refs/heads/master@{#456825}

[modify] https://crrev.com/27d5134eee2e410876b63c1020fd289a6f6461de/DEPS

Comment 11 by dschuff@chromium.org, Mar 14 2017

Project Member
Blockedon: chromium:701564

Comment 12 by bugdroid1@chromium.org, Mar 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ef03257c0d7fa9f863cfe2c883d11ceb6be7269

commit 5ef03257c0d7fa9f863cfe2c883d11ceb6be7269
Author: dschuff <dschuff@chromium.org>
Date: Tue Mar 14 23:12:17 2017

Revert of Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit) (patchset #1 id:1 of https://codereview.chromium.org/2749113002/ )

Reason for revert:
CrOS Chrome buildbot is still running Precise: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30779

Original issue's description:
> Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit)
>
> https://chromium.googlesource.com/native_client/src/native_client.git/+log/62bfd122aee8..93a51ecd3c78
>
> $ git log 62bfd122a..93a51ecd3 --date=short --no-merges --format='%ad %ae %s'
> 2017-03-13 dschuff Update revision for PNaCl
>
> Created with:
>   roll-dep src/native_client
>
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
> TBR=dschuff@chromium.org
> BUG= nativeclient:4391 
>
> Review-Url: https://codereview.chromium.org/2749113002
> Cr-Commit-Position: refs/heads/master@{#456825}
> Committed: https://chromium.googlesource.com/chromium/src/+/27d5134eee2e410876b63c1020fd289a6f6461de

TBR=nacl-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= nativeclient:4391 

Review-Url: https://codereview.chromium.org/2745053007
Cr-Commit-Position: refs/heads/master@{#456881}

[modify] https://crrev.com/5ef03257c0d7fa9f863cfe2c883d11ceb6be7269/DEPS

Comment 13 by bugdroid1@chromium.org, Mar 15 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d999e64f8979a9513f19da5cd7adbe32c7be1d4

commit 8d999e64f8979a9513f19da5cd7adbe32c7be1d4
Author: nacl-deps-roller <nacl-deps-roller@chromium.org>
Date: Wed Mar 15 19:17:19 2017

Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/62bfd122aee8..93a51ecd3c78

$ git log 62bfd122a..93a51ecd3 --date=short --no-merges --format='%ad %ae %s'
2017-03-13 dschuff Update revision for PNaCl

Created with:
  roll-dep src/native_client

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=dschuff@chromium.org
BUG= nativeclient:4391 

Review-Url: https://codereview.chromium.org/2752823002
Cr-Commit-Position: refs/heads/master@{#457161}

[modify] https://crrev.com/8d999e64f8979a9513f19da5cd7adbe32c7be1d4/DEPS

Comment 14 by dschuff@chromium.org, Mar 15 2017

Project Member
OK, looks like the roll is actually going to stick this time.
Going to leave this bug open because of https://chromium-review.googlesource.com/c/451721/#message-a1194aa1b11aae4b160ab07d8a4c9ea8e7977c55 (i may need to fix the test). But Should be fine to unblock the other bugs.

Comment 15 by dschuff@chromium.org, Mar 15 2017

Project Member
Status: Fixed (was: Started)

Comment 16 by bugdroid1@chromium.org, Mar 16 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f87ee6a011706478ca3baa6f36743c1b25fca79b

commit f87ee6a011706478ca3baa6f36743c1b25fca79b
Author: dschuff <dschuff@chromium.org>
Date: Thu Mar 16 22:57:10 2017

Revert of Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit) (patchset #1 id:1 of https://codereview.chromium.org/2752823002/ )

Reason for revert:
Still more Precise bots on chromeos waterfall

Original issue's description:
> Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit)
>
> https://chromium.googlesource.com/native_client/src/native_client.git/+log/62bfd122aee8..93a51ecd3c78
>
> $ git log 62bfd122a..93a51ecd3 --date=short --no-merges --format='%ad %ae %s'
> 2017-03-13 dschuff Update revision for PNaCl
>
> Created with:
>   roll-dep src/native_client
>
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
> TBR=dschuff@chromium.org
> BUG= nativeclient:4391 
>
> Review-Url: https://codereview.chromium.org/2752823002
> Cr-Commit-Position: refs/heads/master@{#457161}
> Committed: https://chromium.googlesource.com/chromium/src/+/8d999e64f8979a9513f19da5cd7adbe32c7be1d4

TBR=nacl-deps-roller@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= nativeclient:4391 

Review-Url: https://codereview.chromium.org/2754173002
Cr-Commit-Position: refs/heads/master@{#457593}

[modify] https://crrev.com/f87ee6a011706478ca3baa6f36743c1b25fca79b/DEPS

Comment 17 by thakis@chromium.org, Mar 23 2017

The roll got reverted -- what's blocking its relanding?

Comment 18 by dschuff@chromium.org, Mar 23 2017

Project Member
Discovered more bots not upgraded to Trusty: https://bugs.chromium.org/p/chromium/issues/detail?id=689832

Comment 19 by thakis@chromium.org, Mar 23 2017

Blockedon: chromium:689832

Comment 20 by thakis@chromium.org, Mar 23 2017

Thanks, added that as blocker. Can you reopen this for now? Also,  bug chromium:699210  suggests that even after we have a sticking roll, more work might be needed. Did you have a chance to look at that?

Comment 21 by dschuff@chromium.org, Mar 23 2017

Project Member
Status: Started (was: Fixed)
reopened until the roll sticks.

Comment 22 by dschuff@chromium.org, Mar 23 2017

Project Member
Blockedon: -chromium:689832 4394

Comment 23 by bugdroid1@chromium.org, Mar 30 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/efa3f5d8ef135ed2463a75ac4630d1c448021400

commit efa3f5d8ef135ed2463a75ac4630d1c448021400
Author: Derek Schuff <dschuff@chromium.org>
Date: Thu Mar 30 18:37:48 2017

Make pnacl-ld ignore --build-id flags

Previously native/translation-related linker flags were rejected by
pnacl-ld to help users understand that they were meaningless for
pexes. However it's easier to have the flags be uniform across
architectures, and for the case of --build-id specifically, translated
nexes have build IDs anyway. So make pnacl-ld igore this flag instead of
rejecting it.

R=stichnot@chromium.org
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391

Change-Id: I145158615443cec3c6bd4d225c82d170115a11ee
Reviewed-on: https://chromium-review.googlesource.com/462065
Reviewed-by: Jim Stichnoth <stichnot@chromium.org>

[modify] https://crrev.com/efa3f5d8ef135ed2463a75ac4630d1c448021400/pnacl/driver/pnacl-ld.py
[modify] https://crrev.com/efa3f5d8ef135ed2463a75ac4630d1c448021400/tests/toolchain/nacl.scons
[modify] https://crrev.com/efa3f5d8ef135ed2463a75ac4630d1c448021400/toolchain_build/toolchain_build_pnacl.py

Comment 25 by dschuff@chromium.org, Mar 31 2017

Project Member
Status: Fixed (was: Started)
OK, patch landed and rolled to accept the extended form of --build-id where applicable, and ignore it otherwise. Should actually be fixed now.

Sign in to add a comment