New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 2731 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:



Sign in to add a comment

Gyp vs scons builds do not have matching use of -DUNICODE on windows

Project Member Reported by bradnelson@google.com, Apr 16 2012

Issue description

Gyp vs scons builds do have matching use of -DUNICODE on windows

On windows the UNICODE define selects between the byte and word sized (CreateProcessA vs CreateProcessW) versions of several win32 calls (all the path related ones), when you use a neutral call (CreateProcess). It appears that the scons build (which I'm sure used to pass -DUNICODE), no longer does, which does not match the gyp build.
We sure make the two match, and figure out why the flag got dropped in the scons build.

 
Project Member

Comment 1 by bradnelson@google.com, Apr 16 2012

Summary: Gyp vs scons builds do not have matching use of -DUNICODE on windows
Project Member

Comment 2 by bradnelson@google.com, Apr 18 2012

Owner: bradnelson@google.com
Project Member

Comment 3 by dschuff@chromium.org, Feb 5 2013

bulk edit cc:dschuff@google.com->dschuff@chromium.org
Project Member

Comment 4 by sbc@chromium.org, Mar 12 2014

I just got bitten by this.  I made a fix in this CL to cope with the fact that UNICODE is defined for some object files and not for others :(

https://codereview.chromium.org/195393003/
Project Member

Comment 5 by sbc@chromium.org, Mar 12 2014

-DUNICODE is added to 'env' in src/shared/platform/build.scons but for some reason this doesn't effect all sources (specifically it doesn't seem to effect the source under service_runtime).  Somebody who knows scons better would do well to investigate or we could get bitten by this again.

Project Member

Comment 6 by sehr@google.com, Jun 20 2014

Labels: -Mstone-21 Mstone-X

Sign in to add a comment