New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 74 users

Issue metadata

Status: Accepted
Owner:
Cc:
EstDays: 8

Blocking:
issue chromium:677523
issue 2937


Participants' hotlists:
roadmap-2017

Show other hotlists

Other hotlists containing this issue:
Hotlist-1
Hotlist-1
Hotlist-1
Hotlist-1


Sign in to add a comment
link

Issue 94: Implement linked-accounts

Reported by jrobb...@google.com, Apr 23 2015 Project Member

Issue description

Chrome users need to be able to deal with both their @chromium and @google accounts often.

GAE supports multi-login by having the user choose at the beginning of the interaction with the service.  But then, there is no way to switch to another account later.

I have a design doc for one way to approach this
https://docs.google.com/document/d/15N5w-maA2ki4vao3AzyCZtHDTWd9TQGP9GLsJmFOqnE/edit
I think that it is similar to the way that gerrit does it.
 

Comment 1 by jrobb...@google.com, Sep 16 2015

Load balancing.

Comment 2 by jpar...@google.com, Sep 18 2015

Labels: -Milestone-Launch Milestone-FastFollow

Comment 3 by jrobb...@google.com, Oct 20 2015

Owner: rmis...@chromium.org

Comment 4 by jrobbins@chromium.org, Feb 15 2016

Project Member
Labels: Milestone-Goodies

Comment 5 by rmis...@google.com, Feb 25 2016

Owner: ----

Comment 6 by jrobbins@chromium.org, Mar 9 2016

Project Member
Cc: jrobbins@chromium.org
 Issue 1092  has been merged into this issue.

Comment 7 by jrobbins@chromium.org, Mar 10 2016

Project Member
 Issue 1092  has been merged into this issue.

Comment 8 by jrobbins@chromium.org, Mar 24 2016

Project Member
 Issue 1173  has been merged into this issue.

Comment 9 Deleted

Comment 10 Deleted

Comment 11 Deleted

Comment 12 Deleted

Comment 13 Deleted

Comment 14 by jrobbins@chromium.org, Sep 27 2016

Project Member
Blockedon: 172

Comment 15 by jrobbins@chromium.org, Sep 27 2016

Project Member
Blocking: 172

Comment 16 by jrobbins@chromium.org, Sep 27 2016

Project Member
Blockedon: -172

Comment 17 by jrobbins@chromium.org, Nov 30 2016

Project Member
Blocking: 1971

Comment 18 by jrobbins@chromium.org, Dec 18 2016

Project Member
Blocking: -1971

Comment 19 by lafo...@chromium.org, Dec 29 2016

Project Member
Blocking: chromium:677523

Comment 20 by jrobbins@chromium.org, Aug 8 2017

Project Member
Blocking: 2937

Comment 21 by jrobbins@chromium.org, Feb 14 2018

Project Member
Labels: -Milestone-Goodies Queue-Goodies

Comment 22 by jrobbins@chromium.org, Feb 15 2018

Project Member
Labels: Milestone-2018Q1

Comment 23 by jrobbins@chromium.org, Apr 11 2018

Project Member
Labels: Milestone-2018Q2

Comment 24 by jrobbins@chromium.org, May 9 2018

Project Member
Cc: jparent@chromium.org
 Issue 3810  has been merged into this issue.

Comment 25 Deleted

Comment 26 by jrobbins@chromium.org, Jul 16 2018

Project Member
Labels: -Milestone-2018Q2 Milestone-2018Q3

Comment 27 by jrobbins@chromium.org, Jul 16 2018

Project Member
Revised goals of this feature:
+ Allow users to safely link accounts by proving that they control both accounts.  We may also impose limits, e.g., usernames @chromium.org and @google.com must match for self-serve linking.
+ Display account linkage on user profile page.  Maybe only visible to that user and site admins for privacy, or maybe to people with some domain.
+ No "sudo" functionality or homegrown "Switch user" menu item.
+ When the main account gets an email notification, linked accounts would not get the the same notification.
+ When bot a linked account and main account would be offered in autocomplete, only the main account is actually offered.
+ When the user visits using a linked account, the user sees a dialog advising them to switch to the main account.  If they decline, the dialog does not appear for 24 hours or some other selected value.
+ Change the "me" keyword, e.g., [owner:me] to include a user's main and linked accounts.

Comment 28 by jrobbins@chromium.org, Aug 28

Project Member
Also, when the user links their account, have a checkbox that is already checked to indicate that all issues owned by the secondary account should be reassigned to the primary account.

Comment 29 by carlosk@chromium.org, Sep 25

Just wanted to mention this would be really great because:
- I wouldn't have to worry anymore about what is the little text/icon in the top right corner is saying before I do anything to any issue.
- It would stop the duplicated notification emails I receive because I "reported this issue" with one account and am "CCed in this issue" with another.

Comment 30 by jrobbins@chromium.org, Sep 26

Project Member
Blocking: -172

Comment 31 by bugdroid1@chromium.org, Nov 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5fbd0855a4d145b2d6560fb8fdb0828f204a0772

commit 5fbd0855a4d145b2d6560fb8fdb0828f204a0772
Author: Jason Robbins <jrobbins@chromium.org>
Date: Mon Nov 05 21:14:51 2018

[Monorail] Warn users who sign in to a linked account.

In this CL:
+ Redo the LinkedAccounts table to use user IDs.
+ Delete dead code that had previously been used for trooper lookup.
+ Load parent and child account references.
+ Display warning to users who are signed in to a child account.

R=jeffcarp@chromium.org

Bug: monorail:94
Change-Id: I82d562a17df8cdf63e482ad793919ec3f1d8a091
Reviewed-on: https://chromium-review.googlesource.com/c/1316416
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18789}
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/schema/project.sql
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/framework/servlet.py
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/services/user_svc.py
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/schema/alter-table-log.txt
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/framework/test/servlet_test.py
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/services/test/user_svc_test.py
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/proto/user_pb2.py
[modify] https://crrev.com/5fbd0855a4d145b2d6560fb8fdb0828f204a0772/appengine/monorail/templates/features/cues.ezt

Comment 32 by bugdroid1@chromium.org, Nov 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/03f892a479785707aa1f62213c3bf6270570d020

commit 03f892a479785707aa1f62213c3bf6270570d020
Author: Jason Robbins <jrobbins@chromium.org>
Date: Wed Nov 07 17:49:39 2018

Swap code-of-conduct and linked account warnings.

The code-of-conduct help cue is not large, so some users might not have
ever clicked the "X" to dismiss it.  For child linked accounts, I want
the linked account warning to show up.  I don't think it is worth
adding logic to make them both show up because people who get the
linked account warning will likely switch to the parent account before
posting anything.

R=jeffcarp@chromium.org

Bug: monorail:94
Change-Id: I98ead8f29e26027e3d7c18b5e1774917ebf17440
Reviewed-on: https://chromium-review.googlesource.com/c/1321929
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18836}
[modify] https://crrev.com/03f892a479785707aa1f62213c3bf6270570d020/appengine/monorail/templates/features/cues.ezt

Comment 33 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/caa0f036bae8d24752a4bf394b4a0af156a41d48

commit caa0f036bae8d24752a4bf394b4a0af156a41d48
Author: Jason Robbins <jrobbins@chromium.org>
Date: Fri Nov 09 21:38:22 2018

[Monorail] When linked accounts would both be notified, only send one.

If a regular issue change would have notified both jrobbins@chromium.org
and jrobbins@google.com, this method merges those into one notification
for just the parent linked account.

Bulk edit notification merging will come in a separate CL.

R=jeffcarp@chromium.org

Bug: monorail:94
Change-Id: Ifc7e4bb918f3f7a3a21911ca354fdd09029fb6a7
Reviewed-on: https://chromium-review.googlesource.com/c/1325410
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18903}
[modify] https://crrev.com/caa0f036bae8d24752a4bf394b4a0af156a41d48/appengine/monorail/features/test/notify_helpers_test.py
[modify] https://crrev.com/caa0f036bae8d24752a4bf394b4a0af156a41d48/appengine/monorail/features/notify_helpers.py
[modify] https://crrev.com/caa0f036bae8d24752a4bf394b4a0af156a41d48/appengine/monorail/features/notify.py
[modify] https://crrev.com/caa0f036bae8d24752a4bf394b4a0af156a41d48/appengine/monorail/features/notify_reasons.py

Comment 34 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f6d50605fb3573f0606bad633b54fea75276c579

commit f6d50605fb3573f0606bad633b54fea75276c579
Author: Jason Robbins <jrobbins@chromium.org>
Date: Mon Nov 12 23:46:22 2018

[Monorail] Fix mail to linked accounts when one addr is an alias.

Normally an addr_perm contains a User object, but there is also a
"also notify" case where some email address can be sent a notification
without there being any User object.  E.g., notifying a given email
address for all issue changes in a project or an also notify filter rule.

R=jojwang@chromium.org

Bug: monorail:94
Change-Id: I5db52d213df528a71cc0a21793305f604a654689
Reviewed-on: https://chromium-review.googlesource.com/c/1332330
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18934}
[modify] https://crrev.com/f6d50605fb3573f0606bad633b54fea75276c579/appengine/monorail/features/notify_helpers.py
[modify] https://crrev.com/f6d50605fb3573f0606bad633b54fea75276c579/appengine/monorail/features/test/notify_helpers_test.py

Comment 35 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e75fec960d2c6c5f2ad29132f2de46a31376a77b

commit e75fec960d2c6c5f2ad29132f2de46a31376a77b
Author: Jason Robbins <jrobbins@chromium.org>
Date: Tue Nov 13 18:14:57 2018

[Monorail] Make keyword "me" handle linked accounts.

Queries for terms like [owner:me], [cc:me], and [is:starred] are
translated into lower-level query terms that specify the user ID of
the user involved: Usually that is the signed in user, but it can also
be the viewed_user when viewing another user's dashboard (a feature that
is still on on hiatus).  With this change, the single user ID is replaced
with a list of IDs of all the accounts linked to the specified account.
E.g., searching for [owner:me] as jrobbins@chromium.org would show
issues owned by either jrobbins@chormium.org or jrobbins@google.com.

R=jeffcarp@chromium.org

Bug: monorail:94
Change-Id: I314fc87b3a2d84aaad9f150a18bbcd8a66080fb9
Reviewed-on: https://chromium-review.googlesource.com/c/1332797
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18963}
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/backendsearch.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/framework/monorailrequest.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/api/issues_servicer.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/test/searchpipeline_test.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/features/filterrules_helpers.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/tracker/test/issuelist_test.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/frontendsearchpipeline.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/backendsearchpipeline.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/test/backendsearchpipeline_test.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/test/backendsearch_test.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/searchpipeline.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/services/issue_svc.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/tracker/issuebulkedit.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/features/notify_reasons.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/businesslogic/work_env.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/features/test/filterrules_helpers_test.py
[modify] https://crrev.com/e75fec960d2c6c5f2ad29132f2de46a31376a77b/appengine/monorail/search/test/frontendsearchpipeline_test.py

Comment 36 by jrobbins@chromium.org, Nov 13

Project Member
Summary: Implement linked-accounts to make it easy for everyone to refer to the desired account when a user has multiple accounts (was: Implement linked-accounts: a type of multi-login)

Comment 37 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fd7a5e0a1217c3dd525a85ec5e2317e2387c48b9

commit fd7a5e0a1217c3dd525a85ec5e2317e2387c48b9
Author: Jason Robbins <jrobbins@chromium.org>
Date: Tue Nov 13 21:57:45 2018

[Monorail] Linked accounts only offer parent in autocomplete.

Whenever we would offer both a parent and child account as separate
options for an autocomplete menu, instead just offer the parent.

R=jeffcarp@chromium.org

Bug: monorail:94
Change-Id: I2ec1cfb3a20f6ee04621e3ffc17694179ed5fb85
Reviewed-on: https://chromium-review.googlesource.com/c/1334038
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18972}
[modify] https://crrev.com/fd7a5e0a1217c3dd525a85ec5e2317e2387c48b9/appengine/monorail/tracker/tracker_helpers.py
[modify] https://crrev.com/fd7a5e0a1217c3dd525a85ec5e2317e2387c48b9/appengine/monorail/tracker/test/tracker_helpers_test.py

Comment 38 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8c1d9d7402b05d236a751232e0b8940210b9fe80

commit 8c1d9d7402b05d236a751232e0b8940210b9fe80
Author: Jason Robbins <jrobbins@chromium.org>
Date: Thu Nov 15 20:27:44 2018

[Monorail] Fix me keyword handling for endpoints API.

R=jojwang@chromium.org

Bug: monorail:94
Change-Id: I3bf7500f65f9707c8047ebfda2062af07c6cd6a2
Reviewed-on: https://chromium-review.googlesource.com/c/1337533
Auto-Submit: Jason Robbins <jrobbins@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19022}
[modify] https://crrev.com/8c1d9d7402b05d236a751232e0b8940210b9fe80/appengine/monorail/services/api_svc_v1.py

Comment 39 by jrobbins@chromium.org, Nov 27

Project Member
Owner: jrobbins@chromium.org
Summary: Implement linked-accounts (was: Implement linked-accounts to make it easy for everyone to refer to the desired account when a user has multiple accounts)
It sounds like I will need to implement merging of permissions for linked accounts.  The scenario that requires it is most clearly demonstrated for FLT approvers: they might normally participate using their @chromium.org account, but they get permission to approve an issue via a @google.com user group that only allows @google.com accounts as members.  It's should not be too difficult to implement, but doing so increases the risk if there is any way for an attacker to get their account linked to one that has more permissions.

Comment 40 Deleted

Comment 42 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/30882e65512725f5efc3011a2383bb5bd16afc14

commit 30882e65512725f5efc3011a2383bb5bd16afc14
Author: Jason Robbins <jrobbins@chromium.org>
Date: Thu Dec 06 01:13:14 2018

[Monorail] Service and work_env code for linked account invites.

R=ehmaldonado@chromium.org

Bug: monorail:94
Change-Id: I5b525d925668a762e00236841219309e41657bdd
Reviewed-on: https://chromium-review.googlesource.com/c/1361664
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19383}
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/schema/project.sql
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/services/user_svc.py
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/schema/alter-table-log.txt
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/settings.py
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/testing/fake.py
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/services/test/user_svc_test.py
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/businesslogic/test/work_env_test.py
[modify] https://crrev.com/30882e65512725f5efc3011a2383bb5bd16afc14/appengine/monorail/businesslogic/work_env.py

Comment 43 by ajp@google.com, Dec 18

Cc: ajp@chromium.org

Comment 45 Deleted

Comment 46 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4741e0296b6196db1117ee548a3baa9349b9c36c

commit 4741e0296b6196db1117ee548a3baa9349b9c36c
Author: Jason Robbins <jrobbins@chromium.org>
Date: Wed Jan 09 18:39:30 2019

[Monorail] Simple invites UI for linked accounts.

The user:
+ Starts in a child account on their profile page.
+ Invites their matching, unlinked, other account to be parent.
+ Switches to the parent account.
+ Accepts the invite (on that account's profile page).

Bug: monorail:94
Change-Id: I66a37a4de80f6bf0ed4ef0a5d239540f36b9bcb9
Reviewed-on: https://chromium-review.googlesource.com/c/1383335
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19865}
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/go/src/infra/monorailv2/api/api_proto/pb.discovery.go
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/api/users_servicer.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/templates/sitewide/user-profile-page.ezt
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/api/api_proto/users_pb2.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/services/user_svc.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/api/test/users_servicer_test.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/go/src/infra/monorailv2/api/api_proto/users.pb.go
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/sitewide/userprofile.py
[add] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/static/js/sitewide/linked-accounts.js
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/businesslogic/work_env.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/testing/fake.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/businesslogic/test/work_env_test.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/api/api_proto/users.proto
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/api/api_proto/users_prpc_pb2.py
[modify] https://crrev.com/4741e0296b6196db1117ee548a3baa9349b9c36c/appengine/monorail/services/test/user_svc_test.py

Comment 47 by bugdroid, Feb 16 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dc50d1b2b5e247ee5de5839b396d70f661cde8fe

commit dc50d1b2b5e247ee5de5839b396d70f661cde8fe
Author: Jason Robbins <jrobbins@chromium.org>
Date: Sat Feb 16 20:33:23 2019

[Monorail] Implement ability to unlink linked accounts.

This adds "Unlink" buttons to the user profile page when a user
can unlink their account.

In this CL:
+ Service-layer method UnlinkAccounts().
+ Business logic method UnlinkAccounts().
+ Users pRPC API method UnlinkAccounts().
+ JS and HTML to call that pRPC API.

Bug: monorail:94
Change-Id: If2e3d5cad25c0a028c4028c92c43253118f34a53
Reviewed-on: https://chromium-review.googlesource.com/c/1471432
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20738}
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/go/src/infra/monorailv2/api/api_proto/pb.discovery.go
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/api/users_servicer.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/templates/sitewide/user-profile-page.ezt
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/api/api_proto/users_pb2.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/services/user_svc.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/api/test/users_servicer_test.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/go/src/infra/monorailv2/api/api_proto/users.pb.go
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/sitewide/userprofile.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/static/css/ph_core.css
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/static/js/sitewide/linked-accounts.js
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/businesslogic/work_env.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/testing/fake.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/businesslogic/test/work_env_test.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/api/api_proto/users.proto
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/api/api_proto/users_prpc_pb2.py
[modify] https://crrev.com/dc50d1b2b5e247ee5de5839b396d70f661cde8fe/appengine/monorail/services/test/user_svc_test.py

Sign in to add a comment