New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 25
EstDays: ----



Sign in to add a comment
link

Issue 4775: FLT dialog box for editing M-Target values changes size on-click

Reported by jojwang@google.com, Jan 10 Project Member

Issue description

What steps will reproduce the problem?
(1)Try to edit a phase's field value.
(2)the dialog box starts out with the comment section expanded (https://screenshot.googleplex.com/FAdmOZ6SVxJ)
(3)click on the M-Target input box
(4)the comment section loses focus and becomes smaller, causing the cursor to end up on the 'Discard changes' button.

What is the expected output?
Inputs should not change size

What do you see instead?
The change in size has lead to users accidentally clicking the 'Discard changes' box when they do not mean to

Please provide any additional information.
 

Comment 1 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/08de76759dab69c79694a0c5e2e3cdef1e923cae

commit 08de76759dab69c79694a0c5e2e3cdef1e923cae
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Jan 11 19:03:15 2019

Monorail: Get rid of textarea size changing.

Bug:  monorail:4775 
Change-Id: I7a957210da3b667afcddb08b2e52fea9001962a4
Reviewed-on: https://chromium-review.googlesource.com/c/1405622
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19935}
[modify] https://crrev.com/08de76759dab69c79694a0c5e2e3cdef1e923cae/appengine/monorail/elements/flt/mr-comments/mr-comments.html
[modify] https://crrev.com/08de76759dab69c79694a0c5e2e3cdef1e923cae/appengine/monorail/elements/flt/mr-edit-metadata/mr-edit-metadata.html

Comment 2 by zhangtiff@chromium.org, Jan 11

Project Member
Status: FixPending (was: New)

Comment 3 by zhangtiff@chromium.org, Jan 25

Project Member
Status: Fixed (was: FixPending)

Sign in to add a comment