New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: New
Owner:
EstDays: ----
TestType: ----


Participants' hotlists:
fltFollowup


Sign in to add a comment
link

Issue 4771: Approval Approvers should be visible in list view

Reported by jojwang@google.com, Jan 9 Project Member

Issue description

What do you want?
The list view of issues should have an option of showing an Approval's Approvers for each value

Why do you want it?
We are telling users to use Approvers to delegate and assign reviews, and move them away from using TE-, UX- labels.
TE- and UX- are visible in list views. 
W/out list views showing approvers, this would be a regression compared to the old system/tools.
 

Comment 2 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ed3a0d148c332e144b34f401cc596a4fd2e30cb4

commit ed3a0d148c332e144b34f401cc596a4fd2e30cb4
Author: Joanna Wang <jojwang@chromium.org>
Date: Fri Jan 11 18:55:33 2019

[Monorail] Make field names ending in '-approver' invalid.

staging: https://19949-2007d59-tainted-jojwang-block-suffix-dot-monorail-staging.appspot.com/p/chromium/fields/create

Bug: monorail:4771
Change-Id: I33ffab44a6fef73ada2b0dafd73c3e7747d6bc45
Reviewed-on: https://chromium-review.googlesource.com/c/1404717
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19934}
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/tracker/fieldcreate.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/tracker/tracker_constants.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/framework/table_view_helpers.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/api/test/projects_servicer_test.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/framework/framework_constants.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/framework/sorting.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/tracker/test/fieldcreate_test.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/businesslogic/test/work_env_test.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/businesslogic/work_env.py
[modify] https://crrev.com/ed3a0d148c332e144b34f401cc596a4fd2e30cb4/appengine/monorail/templates/tracker/field-create-page.ezt

Sign in to add a comment