New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:



Sign in to add a comment
link

Issue 826: ios_deployment_target defaults to 11.0 and doesn't support 32bit

Reported by oprypin@chromium.org, Nov 1 Project Member

Issue description

With Chromium DEPS roll I see that 32-bit iOS builds are no longer supported because the new default is ios_deployment_target="11.0".

So there are some options for libyuv:
1) Override to 10.0
2) Drop 32-bit iOS support

For now I'm assuming that (1) is preferred, but either one works.

Meanwhile, WebRTC sets this to 9.0:
https://cs.chromium.org/search/?q=ios_deployment_target+f:webrtc
 

Comment 1 by bugdroid1@chromium.org, Nov 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/libyuv/libyuv.git/+/1440d8ac1a3e2ce81312452486737e632b32fe6b

commit 1440d8ac1a3e2ce81312452486737e632b32fe6b
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Nov 01 10:07:43 2018

Pin ios_deployment_target = "10.0" to unblock DEPS roll

Bug:  libyuv:826 
Change-Id: Ib47fa183615deaf870af9a9740ad9e8454f19941
Reviewed-on: https://chromium-review.googlesource.com/c/1312693
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/1440d8ac1a3e2ce81312452486737e632b32fe6b/.gn

Comment 2 by fbarchard@google.com, Nov 2

Project Member
I'm in favor of dropping iOS 32 bit support.

But whatever webrtc does, is generally the answer.

Comment 3 by fbarchard@google.com, Jan 3

Project Member
Status: Fixed (was: Accepted)

Sign in to add a comment