New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 8
Cc:



Sign in to add a comment
link

Issue 819: clang-tidy parameter mismatch

Reported by fbarchard@chromium.org, Oct 8 Project Member

Issue description

clang-tidy failures on 2 functions
function 'libyuv::J420ToRGB565' has a definition with different parameter names
function 'libyuv::H420ToRGB565' has a definition with different parameter names
 

Comment 1 by fbarchard@chromium.org, Oct 8

Project Member
Cc: chz@google.com

Comment 2 by bugdroid1@chromium.org, Oct 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/libyuv/libyuv.git/+/594d59d0431b9d41da95a13d4346c07c89100303

commit 594d59d0431b9d41da95a13d4346c07c89100303
Author: Frank Barchard <fbarchard@chromium.org>
Date: Mon Oct 08 17:38:18 2018

clang tidy mismatch in J420ToRGB565

Fix parameter names to match definition and other functions
that use dst_rgb565 for the parameter.

BUG= libyuv:819 , b:109762970
TESTED=locally built to ensure tests still pass.

Change-Id: I2ac20a999e60cda559a150932f0fc4075224b8a5
Reviewed-on: https://chromium-review.googlesource.com/c/1267795
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>

[modify] https://crrev.com/594d59d0431b9d41da95a13d4346c07c89100303/include/libyuv/convert_from.h

Comment 3 by fbarchard@chromium.org, Oct 8

Project Member
Status: Fixed (was: Accepted)

Comment 4 by fbarchard@chromium.org, Oct 8

Project Member
This is how to manually run tidy

tidyyuv:
~/bin/tidycc source/*.cc 
~/bin/tidycc util/*.cc 
~/bin/tidycc unit_test/*.cc 

tidycc:
warnings=-*,mpi-*,objc-*,llvm-*,llvm-*,-hicpp-deprecated-headers,-hicpp-use-auto,bugprone-*,cert-*,google-*,-google-readability-casting,cppcoreguidelines-*,-cppcoreguidelines-pro-type-member-init,fuchsia-*,-fuchsia-multiple-inheritance,-android-cloexec-*,misc-*,-misc-unused-parameters,-misc-macro-parentheses,readability-*,-readability-non-const-parameter,-readability-implicit-bool-conversion,-readability-named-parameter

~/bin/clang-tidy -fix-errors -format-style=file -checks=$warnings $* -- -Iinclude -DHAVE_JPEG=1 -D__mips_msa             
~/bin/clang-tidy -fix-errors -format-style=file -checks=$warnings $* -- -Iinclude -DHAVE_JPEG=1 -D_MSC_VER=1600 -D_M_IX86
~/bin/clang-tidy -fix-errors -format-style=file -checks=$warnings $* -- -Iinclude -DHAVE_JPEG=1 -D_MSC_VER=1600 -D_M_X64 
~/bin/clang-tidy -fix-errors -format-style=file -checks=$warnings $* -- -Iinclude -DHAVE_JPEG=1 -D__i386__               
~/bin/clang-tidy -fix-errors -format-style=file -checks=$warnings $* -- -Iinclude -DHAVE_JPEG=1 -D__x86_64__             
~/bin/clang-tidy -fix-errors -format-style=file -checks=$warnings $* -- -Iinclude -DHAVE_JPEG=1 -D__ARM_NEON__ -D__arm__ 
~/bin/clang-tidy -fix-errors -format-style=file -checks=$warnings $* -- -Iinclude -DHAVE_JPEG=1 -D__aarch64__

Sign in to add a comment