New issue
Advanced search Search tips

Issue 9787 link

Starred by 2 users

Issue metadata

Status: Submitted
Owner: ----
Closed: Oct 2
Cc:
Components:



Sign in to add a comment

Getting "Server error" when sending comments to WIP changes

Project Member Reported by rmis...@google.com, Oct 1

Issue description


For this change: : https://skia-review.googlesource.com/c/skia/+/158223/

When I (and mtklein@) tried to click on "Start Review" both with and without comments we get a popup that says:

"""
An error occurred
Server error:

DISMISS
"""

I attached a screenshot of the popup.

 
error.png
5.6 KB View Download
Cc: mtkl...@google.com
Summary: Getting "Server error" when sending comments to WIP changes (was: Cannot "Start Review" for a change)
It might be a bug for all WIP changes.

I could also reproduce the error here: https://skia-review.googlesource.com/c/buildbot/+/157921
Project Member

Comment 2 by kaspern@google.com, Oct 1

Could you post the log of the error from the console?
HTTP 304 GET 101ms /changes/*~*/detail?O=516714
gr-app.js:1226 POST https://skia-review.googlesource.com/changes/buildbot~157921/revisions/1/review 400
_fetchWithXsrfToken @ gr-app.js:1226
fetch @ gr-app.js:1225
_fetch @ gr-app.js:1241
_send @ gr-app.js:1305
(anonymous) @ gr-app.js:1296
Promise.then (async)
saveChangeReview @ gr-app.js:1296
_saveReview @ gr-app.js:2582
send @ gr-app.js:2571
_submit @ gr-app.js:2582
_sendTapHandler @ gr-app.js:2581
handler @ gr-app.js:615
fire @ gr-app.js:645
fire @ gr-app.js:630
forward @ gr-app.js:639
click @ gr-app.js:638
handleNative @ gr-app.js:625
gr-app.js:1241 HTTP 400 POST 109ms /changes/buildbot~157921/revisions/1/review

Project Member

Comment 4 by logan@google.com, Oct 1

Can you reproduce this with the dev console open and find the 400 response in the network tab? The response body will likely give the reason reported by the server.

Project Member

Comment 5 by kaspern@google.com, Oct 1

Hm. I'm unable to repro this on my WIP changes.

Could you file this issue against the backend team on Buganizer? They'd be able to track down what's going on with a server trace, but I don't think that discussion can take place here.
Project Member

Comment 6 by logan@google.com, Oct 1

Most likely you'll see "only change owner can specify work_in_progress or ready".

Maybe the bug here is that the UI shouldn't be offering you that option if you're not the change owner.
Note: it has to be a WIP changes not owned by you.
Also you should be able to reproduce on https://skia-review.googlesource.com/c/buildbot/+/157921

Response body:
)]}'
{
  "labels": {
    "Code-Review": 0,
    "Commit-Queue": 0
  },
  "reviewers": {},
  "error": "only change owner can specify work_in_progress or ready"
}

> Maybe the bug here is that the UI shouldn't be offering you that option if you're not the change owner.

Yes or a much better error message.


Were we always unable to send comments in WIP mode?

Mike, have you run into that before?
Project Member

Comment 9 by logan@google.com, Oct 1

Cc: david.os...@gmail.com
Components: -PolyGerrit Backend
Owner: ekempin@google.com
My understanding is a little out of date. In theory the availability of this action in the UI is now governed by the server:

https://gerrit-review.googlesource.com/c/gerrit/+/194272

The server-side change was made here:

https://gerrit-review.googlesource.com/c/gerrit/+/168552

But that change forgot about PostReview.java, which implements the batch operation that allows the UI to start review, modify reviewers, vote, etc., all in one API call.

So technically this is a backend bug.
Project Member

Comment 10 by kaspern@google.com, Oct 1

Ah, yes. In the meantime, you can publish comments on changes that are in WIP status and not owned by you via the "save" button in the reply dialog on the bottom LHS.
Project Member

Comment 11 by ekempin@google.com, Oct 2

Status: ChangeUnderReview (was: New)
Fix in review: https://gerrit-review.googlesource.com/c/gerrit/+/198117
Project Member

Comment 12 by ekempin@google.com, Oct 2

Owner: ----
Status: Submitted (was: ChangeUnderReview)

Sign in to add a comment