New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 9707 link

Starred by 3 users

Issue metadata

Status: Released
Owner:
Last visit 21 days ago
Closed: Sep 25
Cc:
Components:
ReleasedIn: 543.0



Sign in to add a comment

"Assigned to you' section on dashboard

Project Member Reported by arnabb@google.com, Sep 11

Issue description

I think it will be good top add a 'Assigned to you' section on the Gerrit dashboard that will show all the changes that have been assigned to the user. Currently the indication for a change that has been assigned to a user are that the change text is bold and the assignee column. The issue with the former is that it is not very apparent that the bolding stands for assigned changes and for a lot of changes, the user can completely miss their name in the assigned column 
 
Project Member

Comment 1 by gertvdijk@gmail.com, Sep 11

Labels: Hotlist-Dashboard
I'd like to point out that assigned-to-you changes are highlighted with a light-yellow background as well. For me, they stand out just enough already.

Also, I believe that we have quite some number of sections already on the default dashboard. I doubt that adding yet another section will improve its functionality so much more. (And what to do with the other sections; exclude those listed in the assigned section or show them again, both may be confusing.)

Consider creating a custom dashboard [1] that includes a section with query 'assignee:self'.

Anyway, this was mostly just my _personal opinion_. :-)

[1]: https://gerrit-documentation.storage.googleapis.com/Documentation/2.15.3/user-dashboards.html
Project Member

Comment 2 by logan@google.com, Sep 13

Labels: UX-Incoming
Project Member

Comment 3 by logan@google.com, Sep 13

Labels: -UX-Incoming UX-Acked Triaged-Yes Priority-3
Project Member

Comment 4 by arnabb@google.com, Sep 14

I agree that the yellow highlight does somehow put more prominence on these changes, but it still doesn't make it evident that the yellow highlight has been caused by the fact that the change has been assigned to you. The 'Assigned to me' dashboard section will definitely help with that. 

I also agree that we have quite a few sections already but I think assigned yo you is an important section since it impacts the order in which the user may want to go through the changes. We do need to address the problem of too many sections on the dashboard, but thats a separate issue and we need to look at it a bit more holistically. The other thing is that we can perhaps choose to show the Assigned to you only if there are changes that have been infact assigned to you instead of cluttering the UI with empty sections.
There is another good point you being up about the redundant changes that may appear in incoming, outgoing etc. if we add the section. I will love to know more from you about what confusion you think it may cause so we are able to solve that problem through UX design.

A custom dashboard is an interesting idea but not all users are very organized to think about creating a custom dashboard or they may not have even discovered that feature in Gerrit yet as it's buried under settings. What if we tackle it another way, I wonder if we could actually ask the user when a change is assigned to them that "Looks like you have been assigned a new change that you have to act upon, do you want to create add a new section on your dashboard for assigned changes?". This way user still have the control over viewing this section on their dashboard. What do you think?

I met with the Gerrit engg team yesterday and we figured that we could perhaps implement this and see what the community thinks. If they don't like it, we can always roll it back. 

Will love to hear back from you.

Project Member

Comment 5 by david.os...@gmail.com, Sep 14

> A custom dashboard is an interesting idea but not all users are very organized to think about creating a custom dashboard or they may not have even discovered that feature in Gerrit yet as it's buried under settings.

Custom Dashboard is very powerfull and popular feature for big gerrit installations, like OpenStack and Wikimedia. OpenStack Project even maintains gerrit-dash-creator project where you can easily generate a custom dashboard. Here is their documentation: [2] with all currently available dashboards. Here is one example from horizon project: [3]. You can click view dashboard to activate it (but you probably have o be logged it to see something useful).

Also Wikimedia has documentation on custom dashboards: [4].

[1] https://github.com/openstack/gerrit-dash-creator
[2] https://gerrit-dash-creator.readthedocs.io/en/latest/dashboards/index.html
[3] https://gerrit-dash-creator.readthedocs.io/en/latest/dashboards/dashboard_horizon.html
[4] https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Gerrit_project_dashboard 
Project Member

Comment 6 by gertvdijk@gmail.com, Sep 14

> I wonder if we could actually ask the user when a change is assigned to them that
> "Looks like you have been assigned a new change that you have to act upon, do you
> want to create add a new section on your dashboard for assigned changes?". This 
> way user still have the control over viewing this section on their dashboard. 
> What do you think?

That personally feels like over-engineering the UX, but maybe that's just me. We don't have anything similar like that in Gerrit; all is designed without bugging the user with questions - unlike GitHub/BitBucket etc. where users get full guidance over everything.

> The other thing is that we can perhaps choose to show the Assigned to you only if
> there are changes that have been infact assigned to you instead of cluttering the 
> UI with empty sections.

That sounds very good to me. We already do that with "Has unpublished drafts" if I'm correct. :-)

Also, +1 on #5, I agree with David Ostrovsky.

Either way, I don't have a strong opinion about it, though. Good to go if you want to implement this.
Project Member

Comment 7 by logan@google.com, Sep 14

Labels: -Priority-3 Priority-2
Owner: logan@google.com
Project Member

Comment 8 by logan@google.com, Sep 17

Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/196211
Project Member

Comment 9 by logan@google.com, Sep 25

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 10 by logan@google.com, Sep 25

ReleasedIn: 543.0
Status: Released (was: Submitted)
Labels: FixedIn-2.16

Sign in to add a comment