New issue
Advanced search Search tips

Issue 9689 link

Starred by 1 user

Issue metadata

Status: Released
Owner:
Closed: Sep 10
Cc:
Components:



Sign in to add a comment

Create Reference permission on refs/* or refs/heads/* (without refs/tags/*) makes Tags creation form visible

Project Member Reported by marco.mm...@gmail.com, Sep 6

Issue description

*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.14

What steps will reproduce the problem?
1. Add a Create Reference permission to refs/* for an allowed group.
2. Add a Create Reference permission to refs/heads/* for another group.
3. Become a user that is a member of either group.
4. Select the Tags view from that project.

What is the expected output?
No actual Tags creation form but only the fields to search for some.

What do you see instead?
One can fill up the Tags creation form,
despite no Create Reference permission solely granted to refs/tags/*
-which is usually required as per documentation.

Please provide any additional information below.
=>
Documentation states that the Create Reference permission is required to create lightweight (non-annotated) tags, which are similar to regular references indeed.

And the Tags creation form embeds both lightweight and annotated tag creation -together.
This means that by current design, the Create Reference permission is required -beside Create Annotated Tag- for a user to successfully use the optional Annotation (annotated tag) field. Otherwise none of the Tags creation form fields show; only the filter ones do.

Command line usage, on the other hand, does not require Create Reference to push new annotated tags. Create Annotated Tag is solely relied upon in this case, which makes sense. That is, beside potentially required side permissions as per documentation. Create Reference is still the permission to grant for pushing lightweight (non-annotated) tags.
 
Project Member

Comment 1 by marco.mm...@gmail.com, Sep 6

Owner: marco.mm...@gmail.com
Status: Started (was: New)
Project Member

Comment 2 by marco.mm...@gmail.com, Sep 6

Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/gerrit/+/195250

Labels: FixedIn-2.14.13
Status: Submitted (was: ChangeUnderReview)
Labels: FixedIn-2.15.4
Status: Released (was: Submitted)

Sign in to add a comment