New issue
Advanced search Search tips

Issue 9667 link

Starred by 4 users

Issue metadata

Status: Released
Owner: ----
Closed: Sep 21
Cc:
Components:



Sign in to add a comment

Warning message for git Lfs from Javamelody

Reported by asept...@gmail.com, Sep 3

Issue description

*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.14

What steps will reproduce the problem?
1. The message appears at gerrit log file in what might be a background process.

What is the expected output?
No message at gerrit log

What do you see instead?
The following message for all lfs object in the repository.
2018-08-29 14:10:14,645|WARN |HTTP-219|HttpChannel    | https://host/gerrit/plugins/lfs/content/default/e8a930982c698162c53acd3333bc2f0cc[sha1]
java.lang.IllegalStateException: getOutputStream() has already been called for this response
        at net.bull.javamelody.internal.web.FilterServletResponseWrapper.getWriter(FilterServletResponseWrapper.java:125)
        at net.bull.javamelody.internal.web.CounterServletResponseWrapper.getWriter(CounterServletResponseWrapper.java:30)
        at javax.servlet.ServletResponseWrapper.getWriter(ServletResponseWrapper.java:109)
        at org.eclipse.jgit.lfs.server.fs.FileLfsServlet.sendError(FileLfsServlet.java:181)
        at org.eclipse.jgit.lfs.server.fs.ObjectDownloadListener.onError(ObjectDownloadListener.java:146)
        at org.eclipse.jetty.server.HttpOutput.run(HttpOutput.java:977)
        at org.eclipse.jetty.server.handler.ContextHandler.handle(ContextHandler.java:1286)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:434)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
        at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
        at org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
        at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
        at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
        at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
        at java.base/java.lang.Thread.run(Unknown Source)


What is the output of the JS console log (if applicable)?


Please provide any additional information below.
This issue is related to Lfs plugin and Javamelody.
 
Components: plugins>lfs plugins>javamelody
What steps will reproduce the problem?
The warning message seems to be triggered when user is performing git clone.
Project Member

Comment 3 by david.os...@gmail.com, Sep 17

 Issue 9721  has been merged into this issue.
Project Member

Comment 4 by david.os...@gmail.com, Sep 17

This is a bug in JGit's lfs.server library and was fixed here: [1],[2].

* [1] https://git.eclipse.org/r/#/c/129501
* [2] https://git.eclipse.org/r/#/c/129502
Status: ChangeUnderReview (was: New)
The JGit fixes are included in 4.7.4.201809180905-r.  Core gerrit is upgraded to this version in [1] and I will upload a change for the LFS plugin later.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/196413
Status: Submitted (was: ChangeUnderReview)
Labels: FixedIn-2.14.13
Status: Released (was: Submitted)
Labels: FixedIn-2.15.4

Sign in to add a comment