New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Released
Owner:
Closed: Sep 28
Cc:
Components:



Sign in to add a comment
link

Issue 9586: PolyGerrit does not take you to latest patch set after submit with "Rebase Always" or "Cherry Pick" strategies

Reported by gertvdijk@gmail.com, Aug 15 Project Member

Issue description

Affected Versions: 2.15.x + current master

What steps will reproduce the problem?
1. Set a project's submit type (strategy) to "Rebase Always" or "Cherry Pick"
2. Upload a new change.
3. Submit the change in PolyGerrit.


What is the expected output?

After the submit dialog is closed and the submit has performed, to land on the change screen latest (newly created by Gerrit) patch set.

(GWT does this correctly.)


What do you see instead?

Landing on the change screen of patch set version before-submit, showing a yellow warning that you're not on the latest patch set.


Please provide any additional information below.

This is submit type/strategy specific, because it causes Gerrit to create a new patch set on submits (it's a feature: these commits are rebased and get additional trailers in the commit message).

Not landing on the submitted version of the change after submit is confusing for users. I had several cases of users copying the SHA1 commit hash of the before-submit patch set and trying to make that into a revision for build systems like Bazel/Cargo - then failing because you can't reach this commit from a branch - and if this was possible you would get the non-rebased commit unintentionally.
 

Comment 1 by gertvdijk@gmail.com, Aug 15

Project Member
Summary: PolyGerrit does not take you to latest patch set after submit with "Rebase Always" or "Cherry Pick" strategies (was: Go to latest patch set after submit in PolyGerrit with "Rebase Always" or "Cherry Pick" strategies)

Comment 2 by gertvdijk@gmail.com, Aug 15

Project Member
Description: Show this description

Comment 3 by wyatta@google.com, Aug 16

Project Member
Labels: Hotlist-ReplyDialog Triaged-Yes

Comment 4 by logan@google.com, Sep 27

Project Member
Labels: -Priority-3 Priority-2 Blocking-2.16
Owner: kaspern@google.com

Comment 5 by kaspern@google.com, Sep 27

Project Member
Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/197535

Comment 6 by gertvdijk@gmail.com, Sep 28

Project Member
Thanks for fixing this!

I saw this cherry-picks cleanly to stable-2.15 as well, tested it, and it worked in a test locally:

https://gerrit-review.googlesource.com/c/gerrit/+/197690

Comment 7 by gertvdijk@gmail.com, Sep 28

Project Member
Labels: FixedIn-2.15.4
Status: Submitted (was: ChangeUnderReview)

Comment 8 by david.pu...@gmail.com, Oct 1

Status: Released (was: Submitted)

Comment 9 by luca.mil...@gmail.com, Nov 20

Project Member
Labels: FixedIn-2.16

Sign in to add a comment