New issue
Advanced search Search tips

Issue 9483 link

Starred by 3 users

Issue metadata

Status: Released
Owner: ----
Closed: Jul 31
Cc:
Components:
ReleasedIn: 531.0



Sign in to add a comment

CrossOrigin issues in Poly Gerrit version 2.14.4

Reported by cedar.bl...@gmail.com, Jul 25

Issue description

Affected Version: 2.14.4

What steps will reproduce the problem?

So I am using the polygerrit version 2.14.4 and it seems that the below two links on the home page don't have cross-origin set to anonymous:

<link rel="preload" href="/fonts/SourceCodePro-Regular.woff2", as="font" type="font/woff2" crossorigin>
<link rel="preload" href="/fonts/SourceCodePro-Regular.woff" as="font" type="font/woff" crossorigin>

The third one, however, is fine: 
<link rel="preload" href="/elements/gr-app.js" as="script" crossorigin="anonymous">

Is this intentional and is there a way to fix it? 


What is the expected output?
<link rel="preload" href="/fonts/SourceCodePro-Regular.woff2", as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/fonts/SourceCodePro-Regular.woff" as="font" type="font/woff" crossorigin="anonymous">

What do you see instead?
<link rel="preload" href="/fonts/SourceCodePro-Regular.woff2", as="font" type="font/woff2" crossorigin>
<link rel="preload" href="/fonts/SourceCodePro-Regular.woff" as="font" type="font/woff" crossorigin>

What is the output of the JS console log (if applicable)?


Please provide any additional information below.
Ref: https://groups.google.com/forum/#!topic/repo-discuss/OR07NEaqHBk
 
Project Member

Comment 2 by gertvdijk@gmail.com, Jul 25

The linked change adds this for stable-2.15. I'm a bit reluctant to perform changes to 2.14.x PolyGerrit:

* It will create a conflict when merging to stable-2.15 because the fonts have changed.
* PolyGerrit in 2.14.x is not very useful feature-wise and regarded as a preview, as far as I know.
* Given the two aforementioned points, plus the lack of 'urgency' of the issue here, I don't think it's worth having this on 2.14 - it can be easily performed, though, if really required on 2.14.x.
Status: ChangeUnderReview (was: New)
Can this be part of Gerrit 2.15.4? Personally, I don't need this fix in 2.14 and I am not sure who will, but it would definitely help if this fix makes it in the next release of Gerrit. 
Project Member

Comment 5 by wyatta@google.com, Jul 31

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 6 by gertvdijk@gmail.com, Jul 31

The change is submitted on the stable-2.15 branch (thanks for reviewing Wyatt), so that means it should be included in the next point release. :-)
Project Member

Comment 7 by wyatta@google.com, Aug 9

ReleasedIn: 531.0
Project Member

Comment 8 by wyatta@google.com, Aug 13

Status: Released (was: Submitted)
Labels: FixedIn-2.15.4

Sign in to add a comment