New issue
Advanced search Search tips

Issue 9482 link

Starred by 4 users

Issue metadata

Status: Released
Owner:
Closed: Jul 30
Components:



Sign in to add a comment

Staleness checker looping forever

Project Member Reported by luca.mil...@gmail.com, Jul 25

Issue description

*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.14.x and over

What steps will reproduce the problem?
1. Create a repository with a '+' in its name
2. Create a new change on the repository

What is the expected output?
Change gets created and reindexed.

What do you see instead?
Change gets created but the staleness checker loops forever filling up the error_log with:
org.eclipse.jgit.errors.RepositoryNotFoundException: repository not found: Invalid name: ****

Please provide any additional information below.
The staleness checker gets the repository name from the Index rather than ReviewDb. Then deducts the repo name from the change data but without doing a proper URLDecoding of the project name.

As a result, any attempt to check if it is stale or not ends up with infinite attempts in rapid sequence, because of the '%' still present in the repository name.
 
Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/190230
Labels: FixedIn-2.14.11
Status: Submitted (was: ChangeUnderReview)
Status: Released (was: Submitted)
Labels: FixedIn-2.15.4

Sign in to add a comment