New issue
Advanced search Search tips

Issue 9419 link

Starred by 3 users

Issue metadata

Status: Released
Owner: ----
Closed: Oct 10
Components:



Sign in to add a comment

Cannot remove reviewers from an abandoned change

Project Member Reported by jrn@google.com, Jul 11

Issue description

Affected Version: 2.15.2-4520-g9511ea103c

What steps will reproduce the problem?
1. Add yourself as a reviewer on a change.
2. Someone else abandons the change.
3. Try to remove yourself as a reviewer.

What is the expected output?
There's an "x" allowing me to remove myself as a reviewer.

What do you see instead?
There's no "x".
 
Project Member

Comment 1 by wyatta@google.com, Jul 11

Status: AwaitingInformation (was: New)
Do you have an example of such a change? I can see an x next to my name on abandoned changes.
If this is on gerrit-review it may be a permission issue related to the fact that Wyatt is a maintainer, but Jonathan is not.
Project Member

Comment 3 by jrn@google.com, Oct 9

 Issue 9830  has been merged into this issue.
Project Member

Comment 4 by jrn@google.com, Oct 9

Status: New (was: AwaitingInformation)
Does the reproduction recipe fail?

In any case, I do have some internal examples (so I can experiment, or if you're at Google I can show them to you).
On the change where you see this, are you actually a reviewer or CC?  I've just tested both of those and it behaves differently.

On [1] where I am a reviewer, I see the [x] to remove myself.  However, on [2] where I am CC, I do not see it.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/57855
[2] https://gerrit-review.googlesource.com/c/plugins/find-owners/+/148592
Project Member

Comment 6 by jrn@google.com, Oct 9

> On the change where you see this, are you actually a reviewer or CC?

I'm a reviewer. It might have to do with my having voted on the change.
Project Member

Comment 7 by jrn@google.com, Oct 9

The /changes/detail response contains

  "removable_reviewers": [],
Project Member

Comment 8 by jrn@google.com, Oct 9

Components: -PolyGerrit Backend
Labels: Hotlist-Reviewers
Project Member

Comment 9 by jrn@google.com, Oct 9

  private static boolean canRemoveReviewerWithoutPermissionCheck(
      PermissionBackend permissionBackend,
      Change change,
      CurrentUser currentUser,
      Account.Id reviewer,
      int value)
      throws PermissionBackendException {
    if (!change.getStatus().isOpen()) {
      return false;
    }

I think that should say 'if (change.getStatus() == MERGED)' instead.
Project Member

Comment 10 by jrn@google.com, Oct 9

Alternatively, if I could remove myself as a reviewer without removing my vote, then it should be able to allow this even for merged changes. That would be nice since otherwise if there is a long and uninteresting comment thread on the change, there is no straightforward way to stop getting notifications from it.
> remove myself as a reviewer without removing my vote

I don't think it's possible to do that.  If you remove yourself as a reviewer, then your vote is also removed.

The opposite is possible though: remove your vote without removing yourself as reviewer.
Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/199216
Labels: FixedIn-2.16
Status: Submitted (was: ChangeUnderReview)
Labels: -FixedIn-2.16 FixedIn-2.15.6
Status: Released (was: Submitted)

Sign in to add a comment