New issue
Advanced search Search tips

Issue 9410 link

Starred by 16 users

Issue metadata

Status: Released
Owner: ----
Closed: Jan 8
Cc:
Components:



Sign in to add a comment

/c/12345 link triggers an infinite redirect loop on Old UI

Reported by bertrand...@gmail.com, Jul 10

Issue description

Affected Version:

What steps will reproduce the problem?
1. Use latest gerrit from master with both GWT and PolyGerrit enabled
2. Switch to Old UI (GWT)
3. Try to access <server>/c/1234 or <server>/c/<project>/+/1234

What is the expected output?
Gerrit to redirect to <server>/#/c/1234/ and eventually <server>/#/c/<project>/+/1234/

What do you see instead?
> This page isn’t working
> <server> redirected you too many times.
> Try clearing your cookies.
> ERR_TOO_MANY_REDIRECTS

Please provide any additional information below.

With PolyGerrit it works fine.
We are in the process of migrating to the new UI but some people are still attached to the old one and links are not working.

I put an ugly workaround in nginx:
  location ~ ^/c/[0-9]*/?$ {
    rewrite ^/(.*)    https://$server_name/#/$1;
  }

  GWT case:
  /c/1234 -> /#/c/1234 -> /#/c/<project>/+/1234

  PolyGerrit case:
  /c/1234 -> /#/c/1234 -> /c/<project>/+/1234

  Problem is that this workaround does not handle the /c/<project>/+/1234 use case. Link is valid with PolyGerrit and crashes with GWT.
 
Project Member

Comment 1 by kaspern@google.com, Jul 10

Components: -PolyGerrit GWT
Project Member

Comment 2 by gertvdijk@gmail.com, Jul 25

Confirming this behavior seen on latest master/2.15.3-4470-g5f0da628f3 as well.

It doesn't help that email notifications sent use the old URL scheme still (just the number, not the project included). See Issue 7077.
Project Member

Comment 3 by gertvdijk@gmail.com, Jul 26

Labels: Triaged-Yes
Status: Accepted (was: New)
Project Member

Comment 4 by logan@google.com, Oct 30

Labels: Priority-4 Hotlist-GWT
Any progress with this? Still unresolved on latest 2.16.
Project Member

Comment 6 by gertvdijk@gmail.com, Nov 7

This *could* be a related fix:
https://gerrit-review.googlesource.com/c/gerrit/+/200910

(Was submitted on master, if fix for this issue, we can consider a cherry-pick on stable-2.16, I guess.)
Doesn't help. The links in emails have the project part. Example: https://review.server/c/Project/+/21706

This fix does the opposite redirection.
Project Member

Comment 9 by jrn@google.com, Dec 12

 Issue 10146  has been merged into this issue.
Labels: FixedIn-2.16.3
Status: Submitted (was: Accepted)
Project Member

Comment 11 by thomasmu...@yahoo.com, Jan 10

Cc: luca.mil...@gmail.com david.os...@gmail.com
 Issue 10195  has been merged into this issue.
Status: Released (was: Submitted)

Sign in to add a comment