New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Released
Owner:
Last visit > 30 days ago
Closed: Jul 2018
Cc:
Components:



Sign in to add a comment
link

Issue 9147: Elasticsearch query with intopic predicate did not include results with keyword as a substring

Reported by bassem.r...@gmail.com, Jun 4 2018 Project Member

Issue description

****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version:
2.14.8

What steps will reproduce the problem?
1. Ensure there are changes with "https://gerrit.<domain>" and "git_gerrit_training" in the topic
2. Set index to elasticsearch.
3. Run query with intopic:gerrit


What is the expected output?
- For lucene index, the query results include changes with "https://gerrit.<domain>" and "git_gerrit_training" in the topic.

What do you see instead?
- With ES index, the query results do not include these changes.

Please provide any additional information below.
 

Comment 1 by bassem.r...@gmail.com, Jun 4 2018

Project Member
Components: Elasticsearch

Comment 2 by david.pu...@gmail.com, Jun 10 2018

Status: AwaitingInformation (was: New)
I was unable to reproduce the expected behaviour for Lucene with a test. It doesn't return the results for "topic:gerrit", but does for "intopic:gerrit".

Comment 3 by marco.mm...@gmail.com, Jun 11 2018

Project Member
@Bassem, did you originally mean 'intopic', or 'topic' straight?

Doc says the former matches substrings, whereas the latter matches the whole string. So, is this issue about not finding matches with ES upon using 'intopic', or rather 'topic' as currently described above? -The former would make sense.

Comment 4 Deleted

Comment 5 by bassem.r...@gmail.com, Jun 11 2018

Project Member
I revised my notes, Yes the issue is reproducible with "intopic" predicate. Sorry for confusion

Comment 6 by bassem.r...@gmail.com, Jun 11 2018

Project Member
Description: Show this description

Comment 7 by david.pu...@gmail.com, Jun 11 2018

Summary: Elasticsearch query with intopic predicate did not include results with keyword as a substring (was: Elasticsearch query with topic predicate did not include results with keyword as a substring)

Comment 8 by david.pu...@gmail.com, Jun 12 2018

Cc: david.pu...@gmail.com

Comment 9 by david.pu...@gmail.com, Jun 12 2018

Status: Accepted (was: AwaitingInformation)
I was able to reproduce the issue after adjusting the test.

Comment 10 by david.pu...@gmail.com, Jun 12 2018

WIP change adds the test to reproduce the issue:

https://gerrit-review.googlesource.com/c/gerrit/+/183990

I haven't looked into how to fix it.

Comment 11 by marco.mm...@gmail.com, Jun 19 2018

Project Member
Owner: borui....@gmail.com
Status: Started (was: Accepted)
Likely related to  issue 9146 , as mentioned in the latter as well -towards this very one.

Comment 12 by borui....@gmail.com, Jul 11 2018

Project Member
The corresponding change to fix this issue is under review:

https://gerrit-review.googlesource.com/c/gerrit/+/188570

Comment 13 by marco.mm...@gmail.com, Jul 11 2018

Project Member
Status: ChangeUnderReview (was: Started)

Comment 14 by david.pu...@gmail.com, Jul 12 2018

Labels: FixedIn-2.14.10
Status: Submitted (was: ChangeUnderReview)

Comment 15 by david.pu...@gmail.com, Jul 12 2018

Status: Released (was: Submitted)

Sign in to add a comment