New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Released
Owner: ----
Closed: May 2018
Cc:
Components:
ReleasedIn: 500.0



Sign in to add a comment
link

Issue 8940: Change edit doesn't load in 2.15.1, the UI reports an error when opening it

Reported by pe...@olssononline.se, May 7 2018

Issue description

Affected Version: 2.15.1

What steps will reproduce the problem?
1. Create a new commit, upload with "git push origin HEAD:refs/drafts/master"
2. Amend the commit, upload it again with the same command, the server responds back with "[EDIT] [PRIVATE]" flags active
3. Open the change in PolyGerrit

What is the expected output?
It should open as any other change

What do you see instead?
An error showing: "Server error: Not found: edit"
The diff is not visible, and it's not possible to delete the change.
When switching to the old UI, it seems to work as expected.


Please provide any additional information below.
 

Comment 1 by david.pu...@gmail.com, May 8 2018

Cc: david.os...@gmail.com

Comment 2 by david.os...@gmail.com, May 8 2018

Project Member
Status: AwaitingInformation (was: New)
I cannot reproduce this.

I created private edit with both UI and by pushing twice to res/drafts/master,
and I was able to open the change in the PolyGerrit it it works as expected.

Can you try to set up a new test site from master/2.15.1 and try to reproduce
your steps?

Comment 3 by pe...@olssononline.se, May 8 2018

That's strange. Did you try to delete it from PolyGerrit as well?

I don't have any extra servers available at the moment, so I'm not able to setup a new instance and try to reproduce it. Is there anything else I can do to help?

Did you test in 2.15.1, or from master?

Comment 4 by pe...@olssononline.se, May 8 2018

I've attached a screen dump so you can see what it looks like for me. In this case I just created a new private change. Then I edited it in the old UI, but I didn't publish the changes yet. Then I switched to PolyGerrit, and I got this.

We never use the funtion to edit a change in the UI, the only reason for noticing it was because of the new drafts behaviour in 2.15.1.
dump.png
65.2 KB View Download

Comment 5 by david.os...@gmail.com, May 8 2018

Project Member
> That's strange. Did you try to delete it from PolyGerrit as well?

No. I havn't trid to delete it. May be this is a misunderstanding?

I only opened the private|edit change in the UI as mentioned in your steps.

When are you getting the "Server error: Not found: edit" error exactly?
Can you share the corresponding server log excerpt?

Comment 6 by david.os...@gmail.com, May 9 2018

Project Member
Cc: -david.os...@gmail.com kaspern@google.com
Labels: Priority-2
Summary: Change edit doesn't load in 2.15.1, the UI reports an error when opening it (was: When uploading an updated patchset to refs/drafts/* in 2.15.1, the UI reports an error when opening it)
I can reproduce it now: I'm using stable-2.15 instead of master.
Apparently the problem was fixed on master.

This request:

  http://localhost:8080/changes/test_project~1/revisions/edit/edit?list

returning:

  404 Not Found
  Not found: edit

Comment 7 by pe...@olssononline.se, May 9 2018

Ahh, sounds great! Probably something that needs to be backported to 2.15 branch then?

Comment 8 by david.os...@gmail.com, May 9 2018

Project Member
Status: Accepted (was: AwaitingInformation)
It seems that "edit" revision is contained twice in the URL.
On master this request is correct:

  http://localhost:8080/changes/test_project~1/edit?list

and produces valid response:

"
)]}'
{
  "commit": {
    "commit": "751cf047334938b1397c75d661739c29b64d5b12",
    "parents": [
      {
        "commit": "ea190c484949e2c294f248117ff9a1b4d9d6f15a"
      }
    ],
    "author": {
      "name": "David Ostrovsky",
[...]
"

Investigating ...

Comment 9 by david.pu...@gmail.com, May 9 2018

What about this patch that is only on master?

https://gerrit-review.googlesource.com/c/gerrit/+/152552

Comment 10 by david.pu...@gmail.com, May 9 2018

Ignore previous comment.  It was unrelated.

Comment 11 by david.pu...@gmail.com, May 9 2018

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/177111

Comment 12 by david.os...@gmail.com, May 9 2018

Project Member
Labels: -Priority-2 FixedIn-2.15.2
Status: Submitted (was: ChangeUnderReview)

Comment 13 by david.os...@gmail.com, May 9 2018

Project Member
Labels: Priority-2

Comment 14 by logan@google.com, May 11 2018

Project Member
ReleasedIn: 500.0

Comment 15 by kaspern@google.com, May 14 2018

Project Member
Status: Released (was: Submitted)

Sign in to add a comment