New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 12 users

Issue metadata

Status: Released
Owner:
Closed: Nov 20
Cc:
Components:
ReleasedIn: 516.0



Sign in to add a comment
link

Issue 8882: Layout for 12+ labels pushes file list far below the fold

Reported by olivier@google.com, May 1 2018

Issue description

Affected Version:

What steps will reproduce the problem?
<scrubbed>

What is the expected output?
Dashboard with pending/incoming/submitted changes

What do you see instead?
no immediate issue.


Please provide any additional information below.

Problems start when going to a particular change.
See gerrit.png (old ui) and gerrit_new.png (new ui) for explicit differences.
What jumps first is the shear unreadability of the new ui.
It's divided into three columns, with inefficient use of space. The right column has way too many entries, with a "Show more button".
The left column takes way too much space to display the reviewer and approval information.
The center column is more than 70% blank, and that's for a descriptive changelist. A "Fix Build" patch will contain one line.

The MAIN issue is that from this view, I don't see the files. I have to scroll down which is a terrible design, since files is the most important part of a changelist. It makes any patch much less obvious and confusing.

Other things are cosmetic, e.g text seems to take twice as much space, at the minimum I would expect parameters similar to gmail (default/comfortable/compact), which I guess takes time to get used to.

<attachments scrubbed>
 

Comment 1 by jrn@google.com, May 1 2018

Project Member
Labels: Restrict-View-Google

Comment 2 by jrn@google.com, May 1 2018

Project Member
Marked restrict-view-google because of screenshots and URLs for internal projects.

Comment 3 by logan@google.com, May 1 2018

Project Member
Cc: arnabb@google.com
Labels: Hotlist-ChangeMetadata UX-Incoming Triaged-Yes Priority-3
Summary: Layout for 12+ labels pushes file list far below the fold (was: new gerrit UI is bad)

Comment 4 by logan@google.com, May 3 2018

Project Member
 Issue 8903  has been merged into this issue.

Comment 5 by logan@google.com, May 3 2018

Project Member
Labels: -Priority-3 Priority-2
Owner: kaspern@google.com
I think we should come up with a stopgap solution for this before the June 4 deadline when we remove the option of using the GWT UI from googlesource.com.

Arnab, you've said you wanted to plan an incremental approach to the layout changes you're working on. This seems like one good area to focus on in the immediate term.

Comment 6 by arnabb@google.com, May 3 2018

Project Member
Yes Logan, that makes sense.

Comment 7 by kaspern@google.com, May 4 2018

Project Member
Issue 8919 has been merged into this issue.

Comment 8 by logan@google.com, May 7 2018

Project Member
 Issue 8921  has been merged into this issue.

Comment 9 by logan@google.com, May 15 2018

Project Member
Labels: -UX-Incoming UX-Current

Comment 10 by kaspern@google.com, May 22 2018

Project Member
Cc: kaspern@google.com
 Issue 8975  has been merged into this issue.

Comment 11 by kaspern@google.com, May 31 2018

Project Member
 Issue 9117  has been merged into this issue.

Comment 12 by kaspern@google.com, Jun 1 2018

Project Member
Description: Show this description

Comment 13 by kaspern@google.com, Jun 1 2018

Project Member
Labels: -Restrict-View-Google
Removing RVG as this issue has had quite a bit of traffic and the scrubbed description is adequate for the issue.

Comment 14 by kaspern@google.com, Jun 7 2018

Project Member
 Issue 9197  has been merged into this issue.

Comment 15 by dahlstrom@google.com, Jun 7 2018

This is a really frustrating UX—so frustrating I continually switch back away from PolyGerrit despite the insistent “This UI is going away“ modal dialogs.

Comment 16 by kaspern@google.com, Jun 7 2018

Project Member
Status: Started (was: New)

Comment 17 by kaspern@google.com, Jun 11 2018

Project Member
Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/gerrit/+/184290

Comment 18 by kaspern@google.com, Jun 11 2018

Project Member
For those interested -- the plan here is to replace the existing label display and submit requirement section with chips that have hovercards. This takes up significantly less vertical space, and also makes the UI more useful at-a-glance.
Screen Shot 2018-06-11 at 3.27.42 PM.png
99 KB View Download
Screen Shot 2018-06-11 at 3.29.14 PM.png
106 KB View Download

Comment 19 by thomasmu...@yahoo.com, Jun 11 2018

Project Member
Will that work in mobile and tablets?

Comment 20 by kaspern@google.com, Jun 13 2018

Project Member
Status: Submitted (was: ChangeUnderReview)

Comment 21 by wyatta@google.com, Jun 18 2018

Project Member
ReleasedIn: 515.0

Comment 22 by wyatta@google.com, Jun 20 2018

Project Member
ReleasedIn: 516.0

Comment 23 by kaspern@google.com, Jun 20 2018

Project Member
Cc: -kaspern@google.com
Status: AwaitingInformation (was: Submitted)
We've had to roll back this solution due to  Issue 9283 .

I've implemented a slightly different fix that uses screen real-estate slightly better on medium-to-small screens [1] [2] -- I'd love to hear if this UX has made life a bit easier for this specific pain point. 

[1] Change: https://gerrit-review.googlesource.com/c/gerrit/+/184930
[2] Demo: https://imgur.com/a/AGxSpXG

Comment 24 by kaspern@google.com, Jun 25 2018

Project Member
Ping! Would love some feedback on Gerrit's current state.

Comment 25 by sgreens@google.com, Jun 25 2018

It's a clear improvement! For our 14-label project I can now see the first changed file without scrolling. I would like to see more changes in this same vein, though, as it's not yet as usable as the old UI and still has a ton of whitespace

Comment 26 by eugenesusla@google.com, Jun 25 2018

Same exact sentiment on my part(looking back at ag/4281895) - seems much more compact now which is great, though still not quite at the level as it was in the old UI

Comment 27 by wyatta@google.com, Jun 27 2018

Project Member
Labels: -Priority-2 Priority-3

Comment 28 by kaspern@google.com, Jul 30 2018

Project Member
Cc: smithdc@google.com
Hi all,

Please have a look at these mocks! Notably, we've:

- Modified the label and submit requirements layout to be more dense (already live)
- Removed all information in the "Change metadata" section (above the labels) not pertinent to accounts (reviewers, assignee, owner, etc etc)
- Placed that information in a bar right below the change number/status/title to allow it to better occupy horizontal space

How do you all feel about these changes? Any and all feedback is appreciated!

Comment 29 by kaspern@google.com, Jul 30 2018

Project Member
Also of note: any bits of information you see left out of these mocks (strategy, for instance) is _not_ going away in the actual UI -- it's just left out of these specific mocks.

Comment 30 by sgreens@google.com, Jul 30 2018

I support these changes

Comment 31 by thomasmu...@yahoo.com, Jul 30 2018

Project Member
I also support those changes, they look really nice!

Comment 32 by matthias...@gmail.com, Jul 31 2018

Project Member
+1, these changes looks nice.

Took me a while to understand that the strange link "am-<UUID>" appearing in image #3 is actually the topic you added in the step before.

Comment 33 Deleted

Comment 34 by david.os...@gmail.com, Sep 17

Project Member
The  Issue 9723  may be related for the re-design of the change screen. The question is where the signed push verification result icon should be shown?

Comment 35 by luca.mil...@gmail.com, Nov 20

Project Member
Labels: FixedIn-2.16
Status: Released (was: AwaitingInformation)

Sign in to add a comment