New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 8882 link

Starred by 11 users

Issue metadata

Status: AwaitingInformation
Owner:
Cc:
Components:
ReleasedIn: 516.0



Sign in to add a comment

Layout for 12+ labels pushes file list far below the fold

Reported by olivier@google.com, May 1

Issue description

Affected Version:

What steps will reproduce the problem?
<scrubbed>

What is the expected output?
Dashboard with pending/incoming/submitted changes

What do you see instead?
no immediate issue.


Please provide any additional information below.

Problems start when going to a particular change.
See gerrit.png (old ui) and gerrit_new.png (new ui) for explicit differences.
What jumps first is the shear unreadability of the new ui.
It's divided into three columns, with inefficient use of space. The right column has way too many entries, with a "Show more button".
The left column takes way too much space to display the reviewer and approval information.
The center column is more than 70% blank, and that's for a descriptive changelist. A "Fix Build" patch will contain one line.

The MAIN issue is that from this view, I don't see the files. I have to scroll down which is a terrible design, since files is the most important part of a changelist. It makes any patch much less obvious and confusing.

Other things are cosmetic, e.g text seems to take twice as much space, at the minimum I would expect parameters similar to gmail (default/comfortable/compact), which I guess takes time to get used to.

<attachments scrubbed>




 
Project Member

Comment 1 by jrn@google.com, May 1

Labels: Restrict-View-Google
Project Member

Comment 2 by jrn@google.com, May 1

Marked restrict-view-google because of screenshots and URLs for internal projects.
Project Member

Comment 3 by logan@google.com, May 1

Cc: arnabb@google.com
Labels: Hotlist-ChangeMetadata UX-Incoming Triaged-Yes Priority-3
Summary: Layout for 12+ labels pushes file list far below the fold (was: new gerrit UI is bad)
Project Member

Comment 4 by logan@google.com, May 3

 Issue 8903  has been merged into this issue.
Project Member

Comment 5 by logan@google.com, May 3

Labels: -Priority-3 Priority-2
Owner: kaspern@google.com
I think we should come up with a stopgap solution for this before the June 4 deadline when we remove the option of using the GWT UI from googlesource.com.

Arnab, you've said you wanted to plan an incremental approach to the layout changes you're working on. This seems like one good area to focus on in the immediate term.
Project Member

Comment 6 by arnabb@google.com, May 3

Yes Logan, that makes sense.
Project Member

Comment 7 by kaspern@google.com, May 4

Issue 8919 has been merged into this issue.
Project Member

Comment 8 by logan@google.com, May 7

 Issue 8921  has been merged into this issue.
Project Member

Comment 9 by logan@google.com, May 15

Labels: -UX-Incoming UX-Current
Project Member

Comment 10 by kaspern@google.com, May 22

Cc: kaspern@google.com
 Issue 8975  has been merged into this issue.
Project Member

Comment 11 by kaspern@google.com, May 31

 Issue 9117  has been merged into this issue.
Project Member

Comment 12 by kaspern@google.com, Jun 1

Description: Show this description
Project Member

Comment 13 by kaspern@google.com, Jun 1

Labels: -Restrict-View-Google
Removing RVG as this issue has had quite a bit of traffic and the scrubbed description is adequate for the issue.
Project Member

Comment 14 by kaspern@google.com, Jun 7

 Issue 9197  has been merged into this issue.
This is a really frustrating UX—so frustrating I continually switch back away from PolyGerrit despite the insistent “This UI is going away“ modal dialogs.
Project Member

Comment 16 by kaspern@google.com, Jun 7

Status: Started (was: New)
Project Member

Comment 17 by kaspern@google.com, Jun 11

Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/gerrit/+/184290
Project Member

Comment 18 by kaspern@google.com, Jun 11

For those interested -- the plan here is to replace the existing label display and submit requirement section with chips that have hovercards. This takes up significantly less vertical space, and also makes the UI more useful at-a-glance.
Screen Shot 2018-06-11 at 3.27.42 PM.png
99 KB View Download
Screen Shot 2018-06-11 at 3.29.14 PM.png
106 KB View Download
Project Member

Comment 19 by thomasmu...@yahoo.com, Jun 11

Will that work in mobile and tablets?
Project Member

Comment 20 by kaspern@google.com, Jun 13

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 21 by wyatta@google.com, Jun 18

ReleasedIn: 515.0
Project Member

Comment 22 by wyatta@google.com, Jun 20

ReleasedIn: 516.0
Project Member

Comment 23 by kaspern@google.com, Jun 20

Cc: -kaspern@google.com
Status: AwaitingInformation (was: Submitted)
We've had to roll back this solution due to  Issue 9283 .

I've implemented a slightly different fix that uses screen real-estate slightly better on medium-to-small screens [1] [2] -- I'd love to hear if this UX has made life a bit easier for this specific pain point. 

[1] Change: https://gerrit-review.googlesource.com/c/gerrit/+/184930
[2] Demo: https://imgur.com/a/AGxSpXG
Project Member

Comment 24 by kaspern@google.com, Jun 25

Ping! Would love some feedback on Gerrit's current state.
It's a clear improvement! For our 14-label project I can now see the first changed file without scrolling. I would like to see more changes in this same vein, though, as it's not yet as usable as the old UI and still has a ton of whitespace
Same exact sentiment on my part(looking back at ag/4281895) - seems much more compact now which is great, though still not quite at the level as it was in the old UI
Project Member

Comment 27 by wyatta@google.com, Jun 27

Labels: -Priority-2 Priority-3
Project Member

Comment 28 by kaspern@google.com, Jul 30

Cc: smithdc@google.com
Hi all,

Please have a look at these mocks! Notably, we've:

- Modified the label and submit requirements layout to be more dense (already live)
- Removed all information in the "Change metadata" section (above the labels) not pertinent to accounts (reviewers, assignee, owner, etc etc)
- Placed that information in a bar right below the change number/status/title to allow it to better occupy horizontal space

How do you all feel about these changes? Any and all feedback is appreciated!
Project Member

Comment 29 by kaspern@google.com, Jul 30

Also of note: any bits of information you see left out of these mocks (strategy, for instance) is _not_ going away in the actual UI -- it's just left out of these specific mocks.
I support these changes
Project Member

Comment 31 by thomasmu...@yahoo.com, Jul 30

I also support those changes, they look really nice!
Project Member

Comment 32 by matthias...@gmail.com, Jul 31

+1, these changes looks nice.

Took me a while to understand that the strange link "am-<UUID>" appearing in image #3 is actually the topic you added in the step before.

Comment 33 Deleted

Project Member

Comment 34 by david.os...@gmail.com, Sep 17

The Issue 9723 may be related for the re-design of the change screen. The question is where the signed push verification result icon should be shown?

Sign in to add a comment