New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 10 users

Issue metadata

Status: Released
Owner: ----
Closed: Jul 12
Cc:
ReleasedIn: 526.0

Blocking:
issue chromium:767439



Sign in to add a comment

Add user and/or project setting for defaulting new changes to wip=true

Project Member Reported by jmad...@chromium.org, Apr 27

Issue description

In ANGLE Gerrit we upload non-squashed stacks of patches. We don't have the same ability that Chromium has to manage the WIP setting through the client upload, so we could benefit from having the ability to set on our project to default changes to WIP.

This would allow us to have the same workflow as Chromium - new uploads are marked WIP, and then after "start review", subsequent uploads don't reset the WIP status.

Happy to provide more explanation/justification if desired.

 
Project Member

Comment 1 by logan@google.com, Apr 30

Labels: Triaged-Yes Priority-3 Hotlist-WIP
Cc: ynovikov@chromium.org
+1
Cc: fjhenigman@chromium.org
+1
Project Member

Comment 4 by kbr@chromium.org, May 5

Cc: kbr@chromium.org
+1

+1
Project Member

Comment 6 by thomasmu...@yahoo.com, May 7

This use to be supported, then we removed that. I guess we could re add it back?
Blocking: chromium:767439
thomasmulhall410@yahoo.com, that sounds reasonable to us. Any updates on this?
Project Member

Comment 9 by david.os...@gmail.com, Jun 8

Status: Accepted (was: New)
Project Member

Comment 10 by david.os...@gmail.com, Jun 10

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/183910
Project Member

Comment 11 by david.os...@gmail.com, Jun 10

Components: -PolyGerrit
Project Member

Comment 12 by david.os...@gmail.com, Jun 10

CL for user specific setting:

https://gerrit-review.googlesource.com/c/gerrit/+/183970
Project Member

Comment 13 by david.os...@gmail.com, Jul 12

Status: Submitted (was: ChangeUnderReview)
Awesome, thanks David! Will watch for the release.
Labels: FixedIn-2.15.3
Status: Released (was: Submitted)
Project Member

Comment 17 by wyatta@google.com, Jul 24

ReleasedIn: 526.0
Big thank you to David and those involved in getting this pushed out! I can see it now in the Chromium Gerrit.

Sign in to add a comment