New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 10 users

Issue metadata

Status: Released
Owner: ----
Closed: Jul 2018
Cc:
ReleasedIn: 526.0

Blocking:
issue 9956
issue chromium:767439



Sign in to add a comment
link

Issue 8866: Add user and/or project setting for defaulting new changes to wip=true

Reported by jmad...@chromium.org, Apr 27 2018 Project Member

Issue description

In ANGLE Gerrit we upload non-squashed stacks of patches. We don't have the same ability that Chromium has to manage the WIP setting through the client upload, so we could benefit from having the ability to set on our project to default changes to WIP.

This would allow us to have the same workflow as Chromium - new uploads are marked WIP, and then after "start review", subsequent uploads don't reset the WIP status.

Happy to provide more explanation/justification if desired.
 

Comment 1 by logan@google.com, Apr 30 2018

Project Member
Labels: Triaged-Yes Priority-3 Hotlist-WIP

Comment 2 by ynovikov@chromium.org, May 4 2018

Cc: ynovikov@chromium.org
+1

Comment 3 by fjhenigman@chromium.org, May 4 2018

Cc: fjhenigman@chromium.org
+1

Comment 4 by kbr@chromium.org, May 5 2018

Project Member
Cc: kbr@chromium.org
+1

Comment 5 by lucferron@chromium.org, May 7 2018

+1

Comment 6 by thomasmu...@yahoo.com, May 7 2018

Project Member
This use to be supported, then we removed that. I guess we could re add it back?

Comment 7 by jmad...@chromium.org, May 8 2018

Blocking: chromium:767439

Comment 8 by jmad...@chromium.org, Jun 8 2018

thomasmulhall410@yahoo.com, that sounds reasonable to us. Any updates on this?

Comment 9 by david.os...@gmail.com, Jun 8 2018

Project Member
Status: Accepted (was: New)

Comment 10 by david.os...@gmail.com, Jun 10 2018

Project Member
Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/183910

Comment 11 by david.os...@gmail.com, Jun 10 2018

Project Member
Components: -PolyGerrit

Comment 12 by david.os...@gmail.com, Jun 10 2018

Project Member

Comment 13 by david.os...@gmail.com, Jul 12 2018

Project Member
Status: Submitted (was: ChangeUnderReview)

Comment 14 by jmad...@chromium.org, Jul 12 2018

Awesome, thanks David! Will watch for the release.

Comment 15 by david.pu...@gmail.com, Jul 18 2018

Labels: FixedIn-2.15.3

Comment 16 by david.pu...@gmail.com, Jul 18 2018

Status: Released (was: Submitted)

Comment 17 by wyatta@google.com, Jul 24 2018

Project Member
ReleasedIn: 526.0

Comment 18 by jmad...@chromium.org, Jul 24 2018

Big thank you to David and those involved in getting this pushed out! I can see it now in the Chromium Gerrit.

Comment 19 by jmad...@chromium.org, Oct 31

Blocking: 9956

Sign in to add a comment