New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Submitted
Owner: ----
Closed: Apr 2018
Cc:



Sign in to add a comment
link

Issue 8850: reviewerin: query returns results for users added as CC when notedb is enabled

Reported by david.pu...@gmail.com, Apr 25 2018 Project Member

Issue description

*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.15

What steps will reproduce the problem?
1. Run a site with notedb enabled
2. Create a group and add user-1 and user-2
3. Create two changes
4. On change-1 add user-1 as reviewer
5. On change-2 add user-2 as CC
6. Run a query "reviewerin:group"

What is the expected output?

Result should include only change-1 since this is the one where the user is added as reviewer. The other change where the reviewer is CC should not be included.


What do you see instead?

Both changes are included.

Please provide any additional information below.

This is a change in behaviour since 2.14.

A test for the described expected behavior was added on stable-2.14 [1] and passes.

When merged up to stable-2.15 [2] the same test fails [3].

[1] https://gerrit-review.googlesource.com/c/gerrit/+/174310
[2] https://gerrit-review.googlesource.com/c/gerrit/+/174350
[3] https://gerrit-ci.gerritforge.com/job/Gerrit-verifier-bazel/47087/consoleText
 

Comment 1 by david.pu...@gmail.com, Apr 26 2018

Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/174430

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Comment 5 by david.pu...@gmail.com, Apr 26 2018

Sorry for the spam if anyone received multiple comment notifications.

Comment 6 by david.pu...@gmail.com, Apr 27 2018

Labels: FixedIn-2.15.2
Status: Submitted (was: ChangeUnderReview)

Sign in to add a comment