New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Apr 2018
Cc:
Components:



Sign in to add a comment
link

Issue 8740: deps.js file takes 450ms to download and is not cached

Reported by cbruni@chromium.org, Apr 11 2018

Issue description

I'm not familiar with the details of gerrit, but it seems that this simple deps.js file takes ages to download given its relatively small size of 1.9 KB.

It seems this file wouldn't change much, yet it's marked as no-cache if I'm not mistaken.
Though probably the deps.js file is not really an offender, it seems suspicious that most file requests happen right after this one finished (at around 750ms, see Screenshot)


RESPONSE HEADERS from DevTools:
alt-svc: hq=":443"; ma=2592000; quic=51303432; quic=51303431; quic=51303339; quic=51303335,quic=":443"; ma=2592000; v="42,41,39,35"
cache-control: no-cache, no-store, max-age=0, must-revalidate
content-length: 1779
content-security-policy-report-only: object-src 'none';script-src 'self' *.googlesource.com www.google-analytics.com apis.google.com www.google.com 'unsafe-inline' 'unsafe-eval';base-uri 'self' https://cdn.googlesource.com;report-uri https://csp-collector.appspot.com/csp/gerritcodereview/484.0
content-type: text/html; charset=utf-8
date: Wed, 11 Apr 2018 21:20:22 GMT
etag: dyUcxz5_lJfev_I5ZDCuXg
expires: Mon, 01 Jan 1990 00:00:00 GMT
pragma: no-cache
set-cookie: XSRF_TOKEN=ANR1CjjU5qOhZrEjauAD7Q-VY_hW-iY_h1YmX4qqbbrlnSof0oH4lTlY_AMQAKYT9qpogi8t6jb54tm30R9Tf7wGZQjoGNcLwg; Path=/; Secure
status: 200
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-xss-protection: 1; mode=block
 
Screen Shot 2018-04-11 at 23.23.10.png
138 KB View Download

Comment 1 by thomasmu...@yahoo.com, Apr 11 2018

Project Member
Components: PolyGerrit

Comment 2 by wyatta@google.com, Apr 11 2018

Project Member
I can share what I know at this stage:

The deps.js file is not something we're intentionally loading, it's an artifact of the way we're using the closure compiler, and I suspect it's related to the Google-internal compiler.

I also believe part of the reason it takes so long is because the request gets routed to the HTML index for the app, which naturally fails to parse as JS.

At one point, we made Google-internal changes the PG build rules to avoid this issue, but for whatever reason these measures are no-longer effective.

One thing I've developed as a potential stop-gap solution is [1]. This may work as a speedy fix to make the app quicker again.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/168850

Comment 3 by kaspern@google.com, Apr 12 2018

Project Member
Cc: kaspern@google.com

Comment 4 by kaspern@google.com, Apr 12 2018

Project Member
Status: Submitted (was: New)

Comment 5 by kaspern@google.com, Apr 13 2018

Project Member
Status: Released (was: Submitted)

Comment 6 by luca.mil...@gmail.com, Nov 20

Project Member
Labels: FixedIn-2.16

Comment 7 by david.pu...@gmail.com, Feb 5

Labels: FixedIn-2.15.10

Sign in to add a comment