New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 8722 link

Starred by 2 users

Issue metadata

Status: Released
Owner:
Closed: May 2018
Cc:
Components:
ReleasedIn: 500.0



Sign in to add a comment

Polygerrit assignee suggestion should only suggest accounts that can see the change

Project Member Reported by david.pu...@gmail.com, Apr 10 2018

Issue description

*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.15

What steps will reproduce the problem?

1. Create a change for a project with restricted read access
2. Go to the change screen and start typing the name of a user who can't see the change in the assignee input box.

What is the expected output?

Users who can't see the change are not suggested as assignee.

What do you see instead?

Users that can't see the change are suggested as assignee.


Please provide any additional information below.

Fixed on the backend and in GWT by  issue 5181 

 
Project Member

Comment 1 by logan@google.com, Apr 16 2018

Labels: -Priority-3 Hotlist-GWT Hotlist-ChangeMetadata Triaged-Yes Priority-2
Owner: kaspern@google.com
See docs for the "cansee:" operator that should be added to the account suggestion query:

https://gerrit-review.googlesource.com/Documentation/user-search-accounts.html#search-operators

Project Member

Comment 2 by kaspern@google.com, May 3 2018

Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/176030
Project Member

Comment 3 by kaspern@google.com, May 3 2018

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 4 by wyatta@google.com, May 4 2018

ReleasedIn: 493.0
Labels: FixedIn-2.15.2
Project Member

Comment 6 by wyatta@google.com, May 7 2018

Status: Released (was: Submitted)
Project Member

Comment 7 by logan@google.com, May 8 2018

Labels: -FixedIn-2.15.2
Status: Accepted (was: Released)
The fix for this may have broken group suggestions ( issue 8957 ).
Project Member

Comment 8 by logan@google.com, May 8 2018

ReleasedIn: ----
Project Member

Comment 9 by kaspern@google.com, May 9 2018

Status: Submitted (was: Accepted)
Labels: FixedIn-2.15.2
Project Member

Comment 11 by logan@google.com, May 11 2018

ReleasedIn: 500.0
Project Member

Comment 12 by kaspern@google.com, May 14 2018

Status: Released (was: Submitted)
Project Member

Comment 13 by luca.mil...@gmail.com, Nov 20

Labels: FixedIn-2.16

Sign in to add a comment