New issue
Advanced search Search tips

Issue 8697 link

Starred by 4 users

Issue metadata

Status: Submitted
Owner: ----
Closed: Apr 2018



Sign in to add a comment

Re-add ability to silently ignore invalid votes

Reported by grimb...@gmail.com, Apr 5 2018

Issue description

Affected Version: 2.15

Per the discussion on the mailing list about Jenking Gerrit Trigger no longer working [0].

There needs to be a way to allow for silently ignoring invalid votes. There are many CI systems out there that submit messages post merge and they don't have different configurations for if the change is already merged or not, just a post back value. Not allowing for silent ignore means that CI systems start breaking.

[0] https://groups.google.com/forum/?hl=en#!topic/repo-discuss/nMZo3HMgJSY
 
Project Member

Comment 1 by thomasmu...@yahoo.com, Apr 5 2018

Cc: xchangcheng@google.com han...@google.com david.os...@gmail.com
Project Member

Comment 2 by david.os...@gmail.com, Apr 5 2018

FTR, it was a late cherry-pick to the stable-2.15 branch of
this series: [1], where this change was a part of: [2]. The
reason for the cherry-pick was to fix the  Issue 8191 .

* [1] https://gerrit-review.googlesource.com/#/q/topic:stop-squashing-votes-during-reindexing
* [2] https://gerrit-review.googlesource.com/#/c/gerrit/+/160853
Project Member

Comment 3 by david.os...@gmail.com, Apr 5 2018

Cc: -han...@google.com -xchangcheng@google.com -david.os...@gmail.com
Project Member

Comment 4 by david.os...@gmail.com, Apr 5 2018

Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/170272
Labels: FixedIn-2.15.2
Status: Submitted (was: ChangeUnderReview)

Sign in to add a comment