Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 18 users
Status: WontFix
Owner: ----
Closed: Jan 2015



Sign in to add a comment
UI: "Review and Submit" can lead to confusing error
Reported by docw...@gmail.com, Mar 1 2011 Back to list
Affected Version: 2.1.6.1

What steps will reproduce the problem?
1. Review a new, unreviewed, patch set.
2. Set Code Review to +2
3. Do NOT set verify (leave at 0).
4. Click "Review and Submit".

You get an application error saying you don't have permission to submit.

What is the expected output? What do you see instead?

It should either:

1. Display a helpful message explaining they can only review, not review and submit.
2. Disable the 'review and submit' button unless someone has verified.

Please provide any additional information below.

 
Project Member Comment 1 by nas...@grainawi.org, May 20 2011
Status: Accepted
Not sure what the right solution is, but we should do better than what we do now.
Comment 2 by eg1...@gmail.com, Feb 28 2012
Seems like both would work well, a disabled button and a tool-tip or small text box explaining why it's disabled.
version´╝Ü b917a2ac5a6b88210d3d044a894bf394c1195a59
test and get feedback:
-----------------------------------------
Application Error
Server Error
Cannot submit <change Id>:needs Verified

-----------------------------------------

I think we just need to remove 'Application Error' 
Status: WontFix
No longer relevant after migration to the new change screen.
Sign in to add a comment