New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Released
Closed: Mar 2018
ReleasedIn: 471.0

Sign in to add a comment

Issue 8574: Shift + R doesn't work for the change list view

Reported by, Mar 16 2018 Project Member

Issue description

It shows in the keyboard shortcut dialog that Shift + R should refresh changes, but it gets caught up in 

if (this.shouldSuppressKeyboardShortcut(e) ||
          this.modifierPressed(e)) { return; }

So, the reloading doesn't ever happen. Not sure if we just want to remove this or make it work.

Comment 1 by, Mar 19 2018

Project Member
Labels: Triaged-Yes Priority-2 Hotlist-KeyboardShortcuts
Status: Accepted (was: New)

Comment 2 by, Mar 20 2018

Project Member

Comment 3 by, Mar 21 2018

Project Member
ReleasedIn: 471.0
Status: Released (was: Submitted)

Comment 4 Deleted

Comment 5 by, Apr 4 2018

Sorry, I'm confused. What version was this released in?  Git history seems to indicate that this commit was available in both v2.15-rc4 and v2.15 (final), but I'm using 2.15 (release, not RC), and I still get no reaction when pressing Shift+R.

Also looking at the linked Gerrit change, it looks like the shift+R key binding is supposed to window.location.reload()?  But the old GWT UI would do a light reload via the REST API, which is significantly faster than doing a full window reload.

I see on the change screen, Shift+R works properly and does not perform a full window reload.


I looked at the Chrome "pretty print" version of gr-app.js, and I'm still seeing the old code:

        _handleRKey: function(e) {
            if (this.shouldSuppressKeyboardShortcut(e) || this.modifierPressed(e))

Should I be seeing the changes from that commit already?

Comment 6 by, Apr 4 2018

Project Member
The change does not exist in 2.15, but it is available on master. It would need to be cherrypicked to 2.15, which I've done here:
Screen Shot 2018-04-04 at 8.46.49 AM.png
172 KB View Download

Comment 7 by, Apr 11 2018

Labels: FixedIn-2.15.1

Comment 8 by, Nov 20

Project Member
Labels: FixedIn-2.16

Sign in to add a comment