New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Released
Owner:
Closed: Mar 20
Cc:
Components:
ReleasedIn: 471.0



Sign in to add a comment

Shift + R doesn't work for the change list view

Project Member Reported by beckysiegel@google.com, Mar 16

Issue description

It shows in the keyboard shortcut dialog that Shift + R should refresh changes, but it gets caught up in 

if (this.shouldSuppressKeyboardShortcut(e) ||
          this.modifierPressed(e)) { return; }

So, the reloading doesn't ever happen. Not sure if we just want to remove this or make it work.
 
Project Member

Comment 1 by wyatta@google.com, Mar 19

Labels: Triaged-Yes Priority-2 Hotlist-KeyboardShortcuts
Owner: kaspern@google.com
Status: Accepted (was: New)
Project Member

Comment 2 by kaspern@google.com, Mar 20

Status: Submitted (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/167230
Project Member

Comment 3 by beckysiegel@google.com, Mar 21

ReleasedIn: 471.0
Status: Released (was: Submitted)

Comment 4 Deleted

Sorry, I'm confused. What version was this released in?  Git history seems to indicate that this commit was available in both v2.15-rc4 and v2.15 (final), but I'm using 2.15 (release, not RC), and I still get no reaction when pressing Shift+R.

Also looking at the linked Gerrit change, it looks like the shift+R key binding is supposed to window.location.reload()?  But the old GWT UI would do a light reload via the REST API, which is significantly faster than doing a full window reload.

I see on the change screen, Shift+R works properly and does not perform a full window reload.

UPDATE:

I looked at the Chrome "pretty print" version of gr-app.js, and I'm still seeing the old code:

        _handleRKey: function(e) {
            if (this.shouldSuppressKeyboardShortcut(e) || this.modifierPressed(e))
                return;
            e.preventDefault();
            window.location.reload()
        },

Should I be seeing the changes from that commit already?  https://gerrit-review.googlesource.com/c/gerrit/+/167230
Project Member

Comment 6 by kaspern@google.com, Apr 4

The change does not exist in 2.15, but it is available on master. It would need to be cherrypicked to 2.15, which I've done here: https://gerrit-review.googlesource.com/c/gerrit/+/169990
Screen Shot 2018-04-04 at 8.46.49 AM.png
172 KB View Download
Labels: FixedIn-2.15.1

Sign in to add a comment