New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Released
Owner: ----
Closed: Apr 2018
Cc:
Components:



Sign in to add a comment
link

Issue 8527: Default index.maxLimit leads to UX-fatal error/exception with elasticsearch index type

Reported by marco.mm...@gmail.com, Mar 12 2018 Project Member

Issue description

*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.14

What steps will reproduce the problem?
1. Use elasticsearch as the configured index type, maxLimit unset.
2. Select a change in the UI to view its review details.

What is the expected output?
That change's own review details or usual UI page.

What do you see instead?
The UX-fatal error [1] in the UI, the corresponding error [2] in error_log, and the causing exception [3] in elasticsearch console.

[1] The page you requested was not found, or you do not have permission to view this page.

[2] ERROR com.google.gerrit.elasticsearch.ElasticChangeIndex : {"root_cause":[{"type":"query_phase_execution_exception","reason":"Result window is too large, from + size must be less than or equal to: [10000] but was [2147483647].

[3] QueryPhaseExecutionException[Result window is too large, from + size must be less than or equal to: [10000] but was [2147483647].

Please provide any additional information below.
N/a.
 

Comment 1 by logan@google.com, Mar 12 2018

Project Member
Labels: Hotlist-RelatedChanges Triaged-Yes

Comment 2 by huga...@gmail.com, Mar 13 2018

Project Member
Status: Accepted (was: New)

Comment 3 by marco.mm...@gmail.com, Mar 13 2018

Project Member
Sorry, forgot to provide the workaround: simply configure index.maxLimit to e.g. 9999 (<10000); 10000 might work as well.

Comment 4 by david.pu...@gmail.com, Mar 14 2018

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/#/c/gerrit/+/165832

Comment 5 by david.pu...@gmail.com, Mar 15 2018

Maybe the solution here is to document that for elasticsearch the configured limit should not exceed the index.max_result_window value configured on the elasticsearch server.

Comment 7 by huga...@gmail.com, Mar 15 2018

Project Member
Labels: FixedIn-2.14.8
Status: Submitted (was: ChangeUnderReview)

Comment 8 by david.pu...@gmail.com, Apr 10 2018

Cc: huga...@gmail.com marco.mm...@gmail.com
 Issue 8725  has been merged into this issue.

Comment 9 by huga...@gmail.com, Apr 10 2018

Project Member
The fact that you faced the same issue means that a documentation fix is maybe not enough, we should do something in the init to ask user if he wants to configure index.maxLimit when index type is Elasticsearch

Comment 10 by david.pu...@gmail.com, Apr 10 2018

Status: ChangeUnderReview (was: Submitted)
https://gerrit-review.googlesource.com/#/c/gerrit/+/171151

Comment 11 by huga...@gmail.com, Apr 10 2018

Project Member
Status: Submitted (was: ChangeUnderReview)
Thanks for the change. We will avoid wasting time because we forgot to configure that value, especially for developpers working on/testing Elasticsearch.

Comment 12 by david.pu...@gmail.com, Apr 11 2018

Labels: FixedIn-2.15.2

Comment 13 by david.pu...@gmail.com, Apr 11 2018

Status: Released (was: Submitted)

Comment 14 by david.pu...@gmail.com, Apr 11 2018

Status: Submitted (was: Released)
Accidentally set to released because a search for label:FixedIn-2.15 also includes the ones with FixedIn-2.15.2

Comment 15 by david.pu...@gmail.com, Apr 20 2018

Status: Released (was: Submitted)

Sign in to add a comment