New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 8241 link

Starred by 2 users

Issue metadata

Status: Released
Owner:
Last visit 18 days ago
Closed: Mar 2018
Cc:
Components:
ReleasedIn: 468.0



Sign in to add a comment

Comment threads should be interleaved in the New UI

Project Member Reported by kjharland@google.com, Jan 29 2018

Issue description

Affected Version: 2.15-rc2-2157-g1438975847

What steps will reproduce the problem?
1. Create a new change
2. Get a reviewer to leave comments on the change
3. Respond to reviewer comments

I would expect the comments to be interleaved on a change's details page, which each new response being part of the same section like so:

  file abc.xyz:
    - Reviewer (line 1) comment 1
    - Author response 1
    - Reviewer comment 2
    - Author response 2
    ...
   
    - Reviewer (line 23) comment 1
    - Author response 1
    ...

Instead, the thread is separated by each commenter's group of responses in a new section, like so: 

  Reviewer:
    file abc.xyz:
      - (line 1) comment 1
      - (line 23) comment 1
   
  Author: 
    file abc.xyz:
      - (line 1) response 1
      - (line 23) response 1
      
  Reviewer:
    file abc.xyz:
      - (line 1) comment 2
      - (line 23) comment 2

  Author:
    file abc.xyz:
      - (line 1) response 2
      - (line 23) response 2

  ...


This makes it very difficult to follow a conversation on a change without clicking into the thread itself and going to the file and patchset containing the comment.
 
Project Member

Comment 1 by logan@google.com, Jan 29 2018

Labels: Triaged-Yes Hotlist-Comments Priority-2
Owner: beckysiegel@google.com
Status: Accepted (was: New)
Project Member

Comment 2 by beckysiegel@google.com, Feb 22 2018

Status: Started (was: Accepted)
Project Member

Comment 3 by beckysiegel@google.com, Mar 15 2018

ReleasedIn: 468.0
Status: Submitted (was: Started)
Project Member

Comment 4 by beckysiegel@google.com, Mar 16 2018

Status: Released (was: Submitted)
Project Member

Comment 5 by kaspern@google.com, Sep 14

 Issue 9720  has been merged into this issue.
Labels: FixedIn-2.16

Sign in to add a comment