New issue
Advanced search Search tips

Issue 8202 link

Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Sep 26
Components:



Sign in to add a comment

Current patchset information missing from event stream on 'private-state-changed' to public

Reported by luke.eng...@gmail.com, Jan 23 2018

Issue description

When making a review public ('Unmark private' button pressed), the data sent to the event stream is missing current patchset information. When someone updates a review (comment added, new patchset, etc.) current patchset information is included in the event stream for that event. It should also include that information when a review is made public.

What steps will reproduce the problem?
1. Make a review private (click mark private button)
2. ssh <user>@<gerrit server> gerrit stream-events
3. Unmark a review private (click Unmark private button)

Expected output:
Details about the review, including current patchset information.


Actual output:
The details of the review come back, but they don't include current patchset information.

Additional comments:
The lack of current patchset information requires our tools to do another separate gerrit query via ssh. If someone is making the review public, then current patchset information should be included in the event stream.
 
This behavior is seen in Version 2.15-stable (bf8c5c33de)
Project Member

Comment 2 by logan@google.com, Jan 29 2018

Components: Backend
Project Member

Comment 3 by david.os...@gmail.com, Aug 3

Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/191490
Labels: FixedIn-2.15.4
Status: Submitted (was: ChangeUnderReview)
Status: Released (was: Submitted)

Sign in to add a comment